Re: [edk2] [PATCH 03/10] ArmPkg/ArmLib: remove unused ARM9 support
On Tue, Nov 03, 2015 at 01:23:47PM +0100, Ard Biesheuvel wrote: > On 3 November 2015 at 12:56, Leif Lindholm wrote: > > On Tue, Nov 03, 2015 at 11:16:28AM +0100, Ard Biesheuvel wrote: > >> The ARM9 ArmLib implementation is not referenced anywhere in the > >> tree, and unlikely to be useful going forward, considering that > >> ARM9 outdates even ARMv6. So remove it. > > > > While I agree in principle, I don't think we can safely make too many > > assumptions here - we know the majority of 32-bit ARM UEFI platforms > > are out of tree. > > > > Can we break this out from the current set and keep as a separate > > discussion, giving people a few weeks to respond? > > Sure. > > I don't think it makes sense to fix this code in the same way as I fix > the other versions in this series. Oh, indeed - I would only expect the corrected spelling. / Leif ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 03/10] ArmPkg/ArmLib: remove unused ARM9 support
On 3 November 2015 at 12:56, Leif Lindholm wrote: > On Tue, Nov 03, 2015 at 11:16:28AM +0100, Ard Biesheuvel wrote: >> The ARM9 ArmLib implementation is not referenced anywhere in the >> tree, and unlikely to be useful going forward, considering that >> ARM9 outdates even ARMv6. So remove it. > > While I agree in principle, I don't think we can safely make too many > assumptions here - we know the majority of 32-bit ARM UEFI platforms > are out of tree. > > Can we break this out from the current set and keep as a separate > discussion, giving people a few weeks to respond? > Sure. I don't think it makes sense to fix this code in the same way as I fix the other versions in this series. (Note that the ARM9 code does not even get built if you build ArmPkg/ArmPkg.dsc in isolation) -- Ard. >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf | 43 - >> ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf| 43 - >> ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c | 165 >> ArmPkg/Library/ArmLib/Arm9/Arm9Lib.c | 134 >> ArmPkg/Library/ArmLib/Arm9/Arm9Support.S | 153 -- >> ArmPkg/Library/ArmLib/Arm9/Arm9Support.asm| 153 -- >> 6 files changed, 691 deletions(-) >> >> diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf >> b/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf >> deleted file mode 100644 >> index e8aa056fbfea.. >> --- a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf >> +++ /dev/null >> @@ -1,43 +0,0 @@ >> -#/** @file >> -# Semihosting serail port lib >> -# >> -# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved. >> -# >> -# This program and the accompanying materials >> -# are licensed and made available under the terms and conditions of the >> BSD License >> -# which accompanies this distribution. The full text of the license may be >> found at >> -# http://opensource.org/licenses/bsd-license.php >> -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR >> IMPLIED. >> -# >> -# >> -#**/ >> - >> -[Defines] >> - INF_VERSION= 0x00010005 >> - BASE_NAME = Arm9ArmLib >> - FILE_GUID = 375D70D3-91E0-4374-A540-68BD959EB184 >> - MODULE_TYPE= DXE_DRIVER >> - VERSION_STRING = 1.0 >> - LIBRARY_CLASS = ArmLib >> - >> -[Sources.common] >> - ../Common/Arm/ArmLibSupport.S| GCC >> - ../Common/Arm/ArmLibSupport.asm | RVCT >> - ../Common/ArmLib.c >> - >> - Arm9Support.S| GCC >> - Arm9Support.asm | RVCT >> - >> - Arm9Lib.c >> - Arm9CacheInformation.c >> - >> -[Packages] >> - ArmPkg/ArmPkg.dec >> - MdePkg/MdePkg.dec >> - >> -[LibraryClasses] >> - MemoryAllocationLib >> - >> -[Protocols] >> - gEfiCpuArchProtocolGuid >> diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf >> b/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf >> deleted file mode 100644 >> index 556e3dc5ab2a.. >> --- a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf >> +++ /dev/null >> @@ -1,43 +0,0 @@ >> -#/** @file >> -# Semihosting serail port lib >> -# >> -# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved. >> -# >> -# This program and the accompanying materials >> -# are licensed and made available under the terms and conditions of the >> BSD License >> -# which accompanies this distribution. The full text of the license may be >> found at >> -# http://opensource.org/licenses/bsd-license.php >> -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR >> IMPLIED. >> -# >> -# >> -#**/ >> - >> -[Defines] >> - INF_VERSION= 0x00010005 >> - BASE_NAME = Arm9ArmLibPrePi >> - FILE_GUID = e9b6011f-ee15-4e59-ab8f-a819a081fa54 >> - MODULE_TYPE= DXE_DRIVER >> - VERSION_STRING = 1.0 >> - LIBRARY_CLASS = ArmLib >> - >> -[Sources.common] >> - ../Common/Arm/ArmLibSupport.S| GCC >> - ../Common/Arm/ArmLibSupport.asm | RVCT >> - ../Common/ArmLib.c >> - >> - Arm9Support.S| GCC >> - Arm9Support.asm | RVCT >> - >> - Arm9Lib.c >> - Arm9CacheInformation.c >> - >> -[Packages] >> - ArmPkg/ArmPkg.dec >> - MdePkg/MdePkg.dec >> - >> -[LibraryClasses] >> - PrePiLib >> - >> -[Protocols] >> - gEfiCpuArchProtocolGuid >> diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c >> b/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c >> deleted file mode 100644 >> index f0b5060249fe.. >> --- a/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c >> +++ /dev/null >> @@ -1,165 +0,0 @@ >> -/** @file >> - >> - Copyright (c) 2008 - 2009, Apple Inc. All
Re: [edk2] [PATCH 03/10] ArmPkg/ArmLib: remove unused ARM9 support
On Tue, Nov 03, 2015 at 11:16:28AM +0100, Ard Biesheuvel wrote: > The ARM9 ArmLib implementation is not referenced anywhere in the > tree, and unlikely to be useful going forward, considering that > ARM9 outdates even ARMv6. So remove it. While I agree in principle, I don't think we can safely make too many assumptions here - we know the majority of 32-bit ARM UEFI platforms are out of tree. Can we break this out from the current set and keep as a separate discussion, giving people a few weeks to respond? / Leif > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf | 43 - > ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf| 43 - > ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c | 165 > ArmPkg/Library/ArmLib/Arm9/Arm9Lib.c | 134 > ArmPkg/Library/ArmLib/Arm9/Arm9Support.S | 153 -- > ArmPkg/Library/ArmLib/Arm9/Arm9Support.asm| 153 -- > 6 files changed, 691 deletions(-) > > diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf > b/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf > deleted file mode 100644 > index e8aa056fbfea.. > --- a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf > +++ /dev/null > @@ -1,43 +0,0 @@ > -#/** @file > -# Semihosting serail port lib > -# > -# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD > License > -# which accompanies this distribution. The full text of the license may be > found at > -# http://opensource.org/licenses/bsd-license.php > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > -# > -# > -#**/ > - > -[Defines] > - INF_VERSION= 0x00010005 > - BASE_NAME = Arm9ArmLib > - FILE_GUID = 375D70D3-91E0-4374-A540-68BD959EB184 > - MODULE_TYPE= DXE_DRIVER > - VERSION_STRING = 1.0 > - LIBRARY_CLASS = ArmLib > - > -[Sources.common] > - ../Common/Arm/ArmLibSupport.S| GCC > - ../Common/Arm/ArmLibSupport.asm | RVCT > - ../Common/ArmLib.c > - > - Arm9Support.S| GCC > - Arm9Support.asm | RVCT > - > - Arm9Lib.c > - Arm9CacheInformation.c > - > -[Packages] > - ArmPkg/ArmPkg.dec > - MdePkg/MdePkg.dec > - > -[LibraryClasses] > - MemoryAllocationLib > - > -[Protocols] > - gEfiCpuArchProtocolGuid > diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf > b/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf > deleted file mode 100644 > index 556e3dc5ab2a.. > --- a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf > +++ /dev/null > @@ -1,43 +0,0 @@ > -#/** @file > -# Semihosting serail port lib > -# > -# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD > License > -# which accompanies this distribution. The full text of the license may be > found at > -# http://opensource.org/licenses/bsd-license.php > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > -# > -# > -#**/ > - > -[Defines] > - INF_VERSION= 0x00010005 > - BASE_NAME = Arm9ArmLibPrePi > - FILE_GUID = e9b6011f-ee15-4e59-ab8f-a819a081fa54 > - MODULE_TYPE= DXE_DRIVER > - VERSION_STRING = 1.0 > - LIBRARY_CLASS = ArmLib > - > -[Sources.common] > - ../Common/Arm/ArmLibSupport.S| GCC > - ../Common/Arm/ArmLibSupport.asm | RVCT > - ../Common/ArmLib.c > - > - Arm9Support.S| GCC > - Arm9Support.asm | RVCT > - > - Arm9Lib.c > - Arm9CacheInformation.c > - > -[Packages] > - ArmPkg/ArmPkg.dec > - MdePkg/MdePkg.dec > - > -[LibraryClasses] > - PrePiLib > - > -[Protocols] > - gEfiCpuArchProtocolGuid > diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c > b/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c > deleted file mode 100644 > index f0b5060249fe.. > --- a/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c > +++ /dev/null > @@ -1,165 +0,0 @@ > -/** @file > - > - Copyright (c) 2008 - 2009, Apple Inc. All rights reserved. > - Copyright (c) 2014, ARM Limited. All rights reserved. > - > - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD > License > - which accompanies this distribution. The full text of the license may be > found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER
[edk2] [PATCH 03/10] ArmPkg/ArmLib: remove unused ARM9 support
The ARM9 ArmLib implementation is not referenced anywhere in the
tree, and unlikely to be useful going forward, considering that
ARM9 outdates even ARMv6. So remove it.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf | 43 -
ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf| 43 -
ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c | 165
ArmPkg/Library/ArmLib/Arm9/Arm9Lib.c | 134
ArmPkg/Library/ArmLib/Arm9/Arm9Support.S | 153 --
ArmPkg/Library/ArmLib/Arm9/Arm9Support.asm| 153 --
6 files changed, 691 deletions(-)
diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf
b/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf
deleted file mode 100644
index e8aa056fbfea..
--- a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLib.inf
+++ /dev/null
@@ -1,43 +0,0 @@
-#/** @file
-# Semihosting serail port lib
-#
-# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
-#
-# This program and the accompanying materials
-# are licensed and made available under the terms and conditions of the BSD
License
-# which accompanies this distribution. The full text of the license may be
found at
-# http://opensource.org/licenses/bsd-license.php
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
IMPLIED.
-#
-#
-#**/
-
-[Defines]
- INF_VERSION= 0x00010005
- BASE_NAME = Arm9ArmLib
- FILE_GUID = 375D70D3-91E0-4374-A540-68BD959EB184
- MODULE_TYPE= DXE_DRIVER
- VERSION_STRING = 1.0
- LIBRARY_CLASS = ArmLib
-
-[Sources.common]
- ../Common/Arm/ArmLibSupport.S| GCC
- ../Common/Arm/ArmLibSupport.asm | RVCT
- ../Common/ArmLib.c
-
- Arm9Support.S| GCC
- Arm9Support.asm | RVCT
-
- Arm9Lib.c
- Arm9CacheInformation.c
-
-[Packages]
- ArmPkg/ArmPkg.dec
- MdePkg/MdePkg.dec
-
-[LibraryClasses]
- MemoryAllocationLib
-
-[Protocols]
- gEfiCpuArchProtocolGuid
diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf
b/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf
deleted file mode 100644
index 556e3dc5ab2a..
--- a/ArmPkg/Library/ArmLib/Arm9/Arm9ArmLibPrePi.inf
+++ /dev/null
@@ -1,43 +0,0 @@
-#/** @file
-# Semihosting serail port lib
-#
-# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
-#
-# This program and the accompanying materials
-# are licensed and made available under the terms and conditions of the BSD
License
-# which accompanies this distribution. The full text of the license may be
found at
-# http://opensource.org/licenses/bsd-license.php
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
IMPLIED.
-#
-#
-#**/
-
-[Defines]
- INF_VERSION= 0x00010005
- BASE_NAME = Arm9ArmLibPrePi
- FILE_GUID = e9b6011f-ee15-4e59-ab8f-a819a081fa54
- MODULE_TYPE= DXE_DRIVER
- VERSION_STRING = 1.0
- LIBRARY_CLASS = ArmLib
-
-[Sources.common]
- ../Common/Arm/ArmLibSupport.S| GCC
- ../Common/Arm/ArmLibSupport.asm | RVCT
- ../Common/ArmLib.c
-
- Arm9Support.S| GCC
- Arm9Support.asm | RVCT
-
- Arm9Lib.c
- Arm9CacheInformation.c
-
-[Packages]
- ArmPkg/ArmPkg.dec
- MdePkg/MdePkg.dec
-
-[LibraryClasses]
- PrePiLib
-
-[Protocols]
- gEfiCpuArchProtocolGuid
diff --git a/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c
b/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c
deleted file mode 100644
index f0b5060249fe..
--- a/ArmPkg/Library/ArmLib/Arm9/Arm9CacheInformation.c
+++ /dev/null
@@ -1,165 +0,0 @@
-/** @file
-
- Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2014, ARM Limited. All rights reserved.
-
- This program and the accompanying materials
- are licensed and made available under the terms and conditions of the BSD
License
- which accompanies this distribution. The full text of the license may be
found at
- http://opensource.org/licenses/bsd-license.php
-
- THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
- WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#include
-#include "ArmLibPrivate.h"
-
-ARM_CACHE_TYPE
-EFIAPI
-ArmCacheType (
- VOID
- )
-{
- switch (CACHE_TYPE (ArmCacheInfo ()))
- {
-case CACHE_TYPE_WRITE_BACK: return ARM_CACHE_TYPE_WRITE_BACK;
-default:return ARM_CACHE_TYPE_UNKNOWN;
- }
-}
-
-ARM_CACHE_ARCHITECTURE
-EFIAPI
-ArmCacheArchitecture (
- VOID
- )
-{
- switch (CACHE_ARCHITECTURE (ArmCacheInfo ()))
- {
-case CACHE_ARCHITECTURE_UNIFIED: return ARM_CACHE_ARCHITECTURE_UNIFIED;
-case CACH
