Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC
On 02/01/19 10:50, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 2/1/19 6:34 AM, Shenglei Zhang wrote:
>> Remove content related to UNIXGCC in README.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>>
>> Cc: Jordan Justen
>> Cc: Laszlo Ersek
>> Cc: Ard Biesheuvel
>> Cc: Anthony Perard
>> Cc: Julien Grall
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Shenglei Zhang
>> ---
>> OvmfPkg/README | 19 ---
>> 1 file changed, 19 deletions(-)
>>
>> diff --git a/OvmfPkg/README b/OvmfPkg/README
>> index 68ce0750af..c014d07bfb 100644
>> --- a/OvmfPkg/README
>> +++ b/OvmfPkg/README
>> @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address
>> 0x80. The
>> remaining OVMF firmware then uses this decompressed firmware
>> volume image.
>>
>> -=== UNIXGCC Debug ===
>> -
>> -If you build with the UNIXGCC toolchain, then debugging will be disabled
>> -due to larger image sizes being produced by the UNIXGCC toolchain. The
>> -first choice recommendation is to use GCC48 or newer instead.
>> -
>> -If you must use UNIXGCC, then you can override the build options for
>> -particular libraries and modules in the .dsc to re-enable debugging
>> -selectively. For example:
>> - [Components]
>> - OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf {
>> -
>> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
>> - }
>> - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf {
>> -
>> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
>> - }
>> -
>> === UEFI Windows 7 & Windows 2008 Server ===
>>
>> * One of the '-vga std' and '-vga qxl' QEMU options should be used.
>>
>
> Doesn't it make sense to squash this commit with the previous one as
> "OvmfPkg: Remove UNIXGCC"?
Good point.
Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC
Hi,
On 2/1/19 6:34 AM, Shenglei Zhang wrote:
> Remove content related to UNIXGCC in README.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang
> ---
> OvmfPkg/README | 19 ---
> 1 file changed, 19 deletions(-)
>
> diff --git a/OvmfPkg/README b/OvmfPkg/README
> index 68ce0750af..c014d07bfb 100644
> --- a/OvmfPkg/README
> +++ b/OvmfPkg/README
> @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address
> 0x80. The
> remaining OVMF firmware then uses this decompressed firmware
> volume image.
>
> -=== UNIXGCC Debug ===
> -
> -If you build with the UNIXGCC toolchain, then debugging will be disabled
> -due to larger image sizes being produced by the UNIXGCC toolchain. The
> -first choice recommendation is to use GCC48 or newer instead.
> -
> -If you must use UNIXGCC, then you can override the build options for
> -particular libraries and modules in the .dsc to re-enable debugging
> -selectively. For example:
> - [Components]
> - OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf {
> -
> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
> - }
> - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf {
> -
> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
> - }
> -
> === UEFI Windows 7 & Windows 2008 Server ===
>
> * One of the '-vga std' and '-vga qxl' QEMU options should be used.
>
Doesn't it make sense to squash this commit with the previous one as
"OvmfPkg: Remove UNIXGCC"?
Regards,
Phil.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC
On 02/01/19 06:34, Shenglei Zhang wrote:
> Remove content related to UNIXGCC in README.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang
> ---
> OvmfPkg/README | 19 ---
> 1 file changed, 19 deletions(-)
>
> diff --git a/OvmfPkg/README b/OvmfPkg/README
> index 68ce0750af..c014d07bfb 100644
> --- a/OvmfPkg/README
> +++ b/OvmfPkg/README
> @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address
> 0x80. The
> remaining OVMF firmware then uses this decompressed firmware
> volume image.
>
> -=== UNIXGCC Debug ===
> -
> -If you build with the UNIXGCC toolchain, then debugging will be disabled
> -due to larger image sizes being produced by the UNIXGCC toolchain. The
> -first choice recommendation is to use GCC48 or newer instead.
> -
> -If you must use UNIXGCC, then you can override the build options for
> -particular libraries and modules in the .dsc to re-enable debugging
> -selectively. For example:
> - [Components]
> - OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf {
> -
> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
> - }
> - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf {
> -
> - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
> - }
> -
> === UEFI Windows 7 & Windows 2008 Server ===
>
> * One of the '-vga std' and '-vga qxl' QEMU options should be used.
>
Reviewed-by: Laszlo Ersek
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC
Remove content related to UNIXGCC in README.
https://bugzilla.tianocore.org/show_bug.cgi?id=1377
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Anthony Perard
Cc: Julien Grall
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
OvmfPkg/README | 19 ---
1 file changed, 19 deletions(-)
diff --git a/OvmfPkg/README b/OvmfPkg/README
index 68ce0750af..c014d07bfb 100644
--- a/OvmfPkg/README
+++ b/OvmfPkg/README
@@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address
0x80. The
remaining OVMF firmware then uses this decompressed firmware
volume image.
-=== UNIXGCC Debug ===
-
-If you build with the UNIXGCC toolchain, then debugging will be disabled
-due to larger image sizes being produced by the UNIXGCC toolchain. The
-first choice recommendation is to use GCC48 or newer instead.
-
-If you must use UNIXGCC, then you can override the build options for
-particular libraries and modules in the .dsc to re-enable debugging
-selectively. For example:
- [Components]
- OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf {
-
- GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
- }
- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf {
-
- GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG
- }
-
=== UEFI Windows 7 & Windows 2008 Server ===
* One of the '-vga std' and '-vga qxl' QEMU options should be used.
--
2.18.0.windows.1
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
