Re: [edk2] [PATCH 1/3] QuarkPlatformPkg: Fix build errors

2016-05-12 Thread Kinney, Michael D 
Reviewed-by: Michael Kinney 

Mike

> -Original Message-
> From: Leahy, Leroy P
> Sent: Wednesday, May 11, 2016 4:08 PM
> To: edk2-devel@lists.01.org; Leahy, Leroy P ; Kinney,
> Michael D ; Steele, Kelly 
> Subject: [PATCH 1/3] QuarkPlatformPkg: Fix build errors
> 
> Fix build errors detected with GCC 4.8.4: local variable set but not
> used!
> 
> Change-Id: I5e3cfb46b367a72bd333fd762c22968fbac4e6f9
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lee Leahy 
> ---
>  QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c  | 2 --
>  QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c   | 4 
>  .../Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c| 4 +---
>  QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c | 3 ---
>  .../Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c | 3 ---
>  QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c   | 6 
> --
>  QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c | 5 +
>  7 files changed, 2 insertions(+), 25 deletions(-)
> 
> diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> index b0f0b44..653df45 100644
> --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> @@ -261,9 +261,7 @@ SdtGetNameStringSize (
>  {
>UINTN SegCount;
>UINTN Length;
> -  UINT8 *Name;
> 
> -  Name = Buffer;
>Length = 0;
> 
>//
> diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
> b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
> index aa18cae..f085753 100644
> --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
> +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
> @@ -255,7 +255,6 @@ ApicTableUpdate (
>UINT8  CurrProcessor;
>UINTN  NumberOfCPUs;
>UINTN  NumberOfEnabledCPUs;
> -  UINTN  BufferSize;
>EFI_PROCESSOR_INFORMATION  MpContext;
>ACPI_APIC_STRUCTURE_PTR*ApicPtr;
> 
> @@ -298,7 +297,6 @@ ApicTableUpdate (
>  switch (ApicPtr->AcpiApicCommon.Type) {
> 
>case EFI_ACPI_1_0_PROCESSOR_LOCAL_APIC:
> -BufferSize = sizeof (EFI_PROCESSOR_INFORMATION);
>  ApicPtr->AcpiLocalApic.Flags = 0;
>  ApicPtr->AcpiLocalApic.ApicId = 0;
>  Status = MpService->GetProcessorInfo (
> @@ -562,7 +560,6 @@ AcpiPlatformEntryPoint (
>UINT32FvStatus;
>UINTN Size;
>EFI_ACPI_TABLE_VERSIONVersion;
> -  QNC_DEVICE_ENABLESQNCDeviceEnables;
>EFI_HANDLEHandle;
>UINTN Index;
>PCI_DEVICE_INFO   *PciDeviceInfo;
> @@ -577,7 +574,6 @@ AcpiPlatformEntryPoint (
>TableHandle = 0;
>CurrentTable = NULL;
>mConfigData  = NULL;
> -  QNCDeviceEnables.Uint32 = PcdGet32 (PcdDeviceEnables);
> 
>//
>// Initialize the EFI Driver Library
> diff --git
> a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio
> n.c
> b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio
> n.c
> index d17f5ea..48c2d53 100644
> ---
> a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio
> n.c
> +++
> b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio
> n.c
> @@ -190,7 +190,6 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages)
>CHAR8 
> CurrentLang[SMBIOS_STRING_MAX_LENGTH +
> 1];
>CHAR8 *OptionalStrStart;
>UINT16Offset;
> -  BOOLEAN   LangMatch;
>EFI_STATUSStatus;
>EFI_SMBIOS_HANDLE SmbiosHandle;
>SMBIOS_TABLE_TYPE13   *SmbiosRecord;
> @@ -210,9 +209,8 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages)
>//
>// Try to check if current langcode matches with the langcodes in installed
> languages
>//
> -  LangMatch = FALSE;
>ZeroMem(CurrentLang, SMBIOS_STRING_MAX_LENGTH + 1);
> -  LangMatch = CurrentLanguageMatch (mHiiHandle, , CurrentLang);
> +  CurrentLanguageMatch (mHiiHandle, , CurrentLang);
>LangStrLen = AsciiStrLen(CurrentLang);
> 
>//
> diff --git 
> a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c
> b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c
> index e352000..af6df02 100644
> --- a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c
> +++

[edk2] [PATCH 1/3] QuarkPlatformPkg: Fix build errors

2016-05-11 Thread Lee Leahy 
Fix build errors detected with GCC 4.8.4: local variable set but not
used!

Change-Id: I5e3cfb46b367a72bd333fd762c22968fbac4e6f9
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy 
---
 QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c  | 2 --
 QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c   | 4 
 .../Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c| 4 +---
 QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c | 3 ---
 .../Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c | 3 ---
 QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c   | 6 --
 QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c | 5 +
 7 files changed, 2 insertions(+), 25 deletions(-)

diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c 
b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
index b0f0b44..653df45 100644
--- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
+++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
@@ -261,9 +261,7 @@ SdtGetNameStringSize (
 {
   UINTN SegCount;
   UINTN Length;
-  UINT8 *Name;
 
-  Name = Buffer;
   Length = 0;
 
   //
diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c 
b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
index aa18cae..f085753 100644
--- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
+++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c
@@ -255,7 +255,6 @@ ApicTableUpdate (
   UINT8  CurrProcessor;
   UINTN  NumberOfCPUs;
   UINTN  NumberOfEnabledCPUs;
-  UINTN  BufferSize;
   EFI_PROCESSOR_INFORMATION  MpContext;
   ACPI_APIC_STRUCTURE_PTR*ApicPtr;
 
@@ -298,7 +297,6 @@ ApicTableUpdate (
 switch (ApicPtr->AcpiApicCommon.Type) {
 
   case EFI_ACPI_1_0_PROCESSOR_LOCAL_APIC:
-BufferSize = sizeof (EFI_PROCESSOR_INFORMATION);
 ApicPtr->AcpiLocalApic.Flags = 0;
 ApicPtr->AcpiLocalApic.ApicId = 0;
 Status = MpService->GetProcessorInfo (
@@ -562,7 +560,6 @@ AcpiPlatformEntryPoint (
   UINT32FvStatus;
   UINTN Size;
   EFI_ACPI_TABLE_VERSIONVersion;
-  QNC_DEVICE_ENABLESQNCDeviceEnables;
   EFI_HANDLEHandle;
   UINTN Index;
   PCI_DEVICE_INFO   *PciDeviceInfo;
@@ -577,7 +574,6 @@ AcpiPlatformEntryPoint (
   TableHandle = 0;
   CurrentTable = NULL;
   mConfigData  = NULL;
-  QNCDeviceEnables.Uint32 = PcdGet32 (PcdDeviceEnables);
 
   //
   // Initialize the EFI Driver Library
diff --git 
a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
 
b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
index d17f5ea..48c2d53 100644
--- 
a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
+++ 
b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
@@ -190,7 +190,6 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages)
   CHAR8 
CurrentLang[SMBIOS_STRING_MAX_LENGTH + 1];
   CHAR8 *OptionalStrStart;
   UINT16Offset;
-  BOOLEAN   LangMatch;
   EFI_STATUSStatus;
   EFI_SMBIOS_HANDLE SmbiosHandle;
   SMBIOS_TABLE_TYPE13   *SmbiosRecord;
@@ -210,9 +209,8 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages)
   //
   // Try to check if current langcode matches with the langcodes in installed 
languages
   //
-  LangMatch = FALSE;
   ZeroMem(CurrentLang, SMBIOS_STRING_MAX_LENGTH + 1);
-  LangMatch = CurrentLanguageMatch (mHiiHandle, , CurrentLang);
+  CurrentLanguageMatch (mHiiHandle, , CurrentLang);
   LangStrLen = AsciiStrLen(CurrentLang);
 
   //
diff --git 
a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c 
b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c
index e352000..af6df02 100644
--- a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c
+++ b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c
@@ -38,9 +38,6 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscOemString)
   STRING_REF   TokenToGet;
   EFI_SMBIOS_HANDLESmbiosHandle;
   SMBIOS_TABLE_TYPE11  *SmbiosRecord;
-  EFI_MISC_OEM_STRING  *ForType11InputData;
-
-  ForType11InputData = (EFI_MISC_OEM_STRING *)RecordData;
 
   //
   // First check for invalid parameters.
diff --git 
a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c 
b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c
index 44cc684..52021d8 100644