Re: [edk2] [PATCH 1/6] BaseTools/GenFw ARM: allow R_ARM_REL32 relocations

[Ard Biesheuvel]

(add BaseTools maintainers)

On 23 November 2015 at 17:56, Ard Biesheuvel  wrote:
> R_ARM_REL32 are relative relocations, so we don't need to do anything
> special when performing the ELF to PE/COFF conversion, since our memory
> layout is identical between the two binary formats. So just allow them.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel 
> ---
>  BaseTools/Source/C/GenFw/Elf32Convert.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c 
> b/BaseTools/Source/C/GenFw/Elf32Convert.c
> index a7b077873b40..469394540e6a 100644
> --- a/BaseTools/Source/C/GenFw/Elf32Convert.c
> +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c
> @@ -716,6 +716,7 @@ WriteSections32 (
>  // break skipped
>
>case R_ARM_PC24:
> +  case R_ARM_REL32:
>case R_ARM_XPC25:
>case R_ARM_THM_PC22:
>case R_ARM_THM_JUMP19:
> @@ -844,6 +845,7 @@ WriteRelocations32 (
>// break skipped
>
>  case R_ARM_PC24:
> +case R_ARM_REL32:
>  case R_ARM_XPC25:
>  case R_ARM_THM_PC22:
>  case R_ARM_THM_JUMP19:
> --
> 1.9.1
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 1/6] BaseTools/GenFw ARM: allow R_ARM_REL32 relocations

[Ard Biesheuvel]

R_ARM_REL32 are relative relocations, so we don't need to do anything
special when performing the ELF to PE/COFF conversion, since our memory
layout is identical between the two binary formats. So just allow them.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel 
---
 BaseTools/Source/C/GenFw/Elf32Convert.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c 
b/BaseTools/Source/C/GenFw/Elf32Convert.c
index a7b077873b40..469394540e6a 100644
--- a/BaseTools/Source/C/GenFw/Elf32Convert.c
+++ b/BaseTools/Source/C/GenFw/Elf32Convert.c
@@ -716,6 +716,7 @@ WriteSections32 (
 // break skipped
 
   case R_ARM_PC24:
+  case R_ARM_REL32:
   case R_ARM_XPC25:
   case R_ARM_THM_PC22:
   case R_ARM_THM_JUMP19:
@@ -844,6 +845,7 @@ WriteRelocations32 (
   // break skipped
 
 case R_ARM_PC24:
+case R_ARM_REL32:
 case R_ARM_XPC25:
 case R_ARM_THM_PC22:
 case R_ARM_THM_JUMP19:
-- 
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel