"InternalTlsLib.h" includes "BaseCryptLib.h", but the lib class is not listed in the INF file.
The INF file lists a good number of lib classes, but none of the lib class headers are included by "InternalTlsLib.h". Synchronize both lists, while removing those library classes that aren't actually needed. (IntrinsicLib and OpensslLib have no edk2 class headers.) Cc: Jiaxin Wu <jiaxin...@intel.com> Cc: Qin Long <qin.l...@intel.com> Cc: Siyuan Fu <siyuan...@intel.com> Cc: Ting Ye <ting...@intel.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=915 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- CryptoPkg/Library/TlsLib/TlsLib.inf | 4 +--- CryptoPkg/Library/TlsLib/InternalTlsLib.h | 3 +++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsLib.inf b/CryptoPkg/Library/TlsLib/TlsLib.inf index 44789ceeefa3..dbb737b2a147 100644 --- a/CryptoPkg/Library/TlsLib/TlsLib.inf +++ b/CryptoPkg/Library/TlsLib/TlsLib.inf @@ -36,20 +36,18 @@ [Sources] [Packages] MdePkg/MdePkg.dec CryptoPkg/CryptoPkg.dec [LibraryClasses] + BaseCryptLib BaseLib BaseMemoryLib DebugLib IntrinsicLib - MemoryAllocationLib OpensslLib - PrintLib - UefiRuntimeServicesTableLib [BuildOptions] # # suppress the following warnings so we do not break the build with warnings-as-errors: # C4090: 'function' : different 'const' qualifiers # diff --git a/CryptoPkg/Library/TlsLib/InternalTlsLib.h b/CryptoPkg/Library/TlsLib/InternalTlsLib.h index 88c4e3b38e4e..3f18a461a8d1 100644 --- a/CryptoPkg/Library/TlsLib/InternalTlsLib.h +++ b/CryptoPkg/Library/TlsLib/InternalTlsLib.h @@ -16,12 +16,15 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #define __INTERNAL_TLS_LIB_H__ #undef _WIN32 #undef _WIN64 #include <Library/BaseCryptLib.h> +#include <Library/BaseLib.h> +#include <Library/BaseMemoryLib.h> +#include <Library/DebugLib.h> #include <openssl/ssl.h> #include <openssl/bio.h> #include <openssl/err.h> typedef struct { // -- 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
