Re: [edk2] [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to SetHighSpeedMode

2016-05-12 Thread Kinney, Michael D 
Reviewed-by: Michael Kinney 

Mike

> -Original Message-
> From: Leahy, Leroy P
> Sent: Thursday, May 12, 2016 2:27 PM
> To: edk2-devel@lists.01.org; Leahy, Leroy P ; Kinney,
> Michael D ; Steele, Kelly 
> Subject: [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to 
> SetHighSpeedMode
> 
> Add the missing EFIAPI to fix the inconsistent routine declaration and
> implementation of a protocol service.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lee Leahy 
> ---
>  QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git 
> a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> index 18e85c8..2b5dbe6 100644
> --- a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> +++ b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> @@ -244,6 +244,7 @@ GetErrorReason (
>@return EFI_SUCCESS
>  **/
>  EFI_STATUS
> +EFIAPI
>  SetHighSpeedMode (
>IN  EFI_SD_HOST_IO_PROTOCOL*This,
>IN  BOOLEANEnable
> --
> 1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to SetHighSpeedMode

2016-05-12 Thread Lee Leahy 
Add the missing EFIAPI to fix the inconsistent routine declaration and
implementation of a protocol service.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy 
---
 QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c 
b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
index 18e85c8..2b5dbe6 100644
--- a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
+++ b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
@@ -244,6 +244,7 @@ GetErrorReason (
   @return EFI_SUCCESS
 **/
 EFI_STATUS
+EFIAPI
 SetHighSpeedMode (
   IN  EFI_SD_HOST_IO_PROTOCOL*This,
   IN  BOOLEANEnable
-- 
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to SetHighSpeedMode

2016-05-12 Thread Kinney, Michael D 
Leroy,

The QuarkSocPkg does not support 64-bit.  The DSC file for that package only 
lists IA32.

I agree that protocol services need to be EFIAPI, so please update commit 
message so the reason for the change is to add missing EFIAPI for a protocol
service.

Thanks,

Mike



> -Original Message-
> From: Leahy, Leroy P
> Sent: Wednesday, May 11, 2016 4:09 PM
> To: edk2-devel@lists.01.org; Leahy, Leroy P ; Kinney,
> Michael D ; Steele, Kelly 
> Subject: [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to 
> SetHighSpeedMode
> 
> Fix 64-bit build error detected with GCC4.8 due to inconsistent routine
> declaration and implementation.  Add EFIAPI to fix the build error.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lee Leahy 
> ---
>  QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git 
> a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> index 18e85c8..2b5dbe6 100644
> --- a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> +++ b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
> @@ -244,6 +244,7 @@ GetErrorReason (
>@return EFI_SUCCESS
>  **/
>  EFI_STATUS
> +EFIAPI
>  SetHighSpeedMode (
>IN  EFI_SD_HOST_IO_PROTOCOL*This,
>IN  BOOLEANEnable
> --
> 1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to SetHighSpeedMode

2016-05-11 Thread Lee Leahy 
Fix 64-bit build error detected with GCC4.8 due to inconsistent routine
declaration and implementation.  Add EFIAPI to fix the build error.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy 
---
 QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c 
b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
index 18e85c8..2b5dbe6 100644
--- a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
+++ b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c
@@ -244,6 +244,7 @@ GetErrorReason (
   @return EFI_SUCCESS
 **/
 EFI_STATUS
+EFIAPI
 SetHighSpeedMode (
   IN  EFI_SD_HOST_IO_PROTOCOL*This,
   IN  BOOLEANEnable
-- 
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel