Re: [edk2] [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h

2019-02-11 Thread Leif Lindholm
On Mon, Feb 11, 2019 at 07:03:09PM +0100, Ard Biesheuvel wrote:
> On Mon, 11 Feb 2019 at 19:02, Leif Lindholm  wrote:
> >
> > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> > .vfr rather than local definitions.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm 
> 
> Reviewed-by: Ard Biesheuvel 

Thanks, pushed as d7b29975f8.

> > ---
> >  .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 
> > +
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git 
> > a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr 
> > b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> > index 8a395eac68..25b7b49a3d 100644
> > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> > @@ -15,14 +15,7 @@
> >  #include 
> >  #include 
> >  #include 
> > -
> > -//
> > -// EFI Variable attributes
> > -//
> > -#define EFI_VARIABLE_NON_VOLATILE   0x0001
> > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x0002
> > -#define EFI_VARIABLE_RUNTIME_ACCESS 0x0004
> > -#define EFI_VARIABLE_READ_ONLY  0x0008
> > +#include 
> >
> >  formset
> >guid  = SYNQUACER_PLATFORM_FORMSET_GUID,
> > --
> > 2.11.0
> >
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h

2019-02-11 Thread Ard Biesheuvel
On Mon, 11 Feb 2019 at 19:02, Leif Lindholm  wrote:
>
> Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> .vfr rather than local definitions.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm 

Reviewed-by: Ard Biesheuvel 

> ---
>  .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 
> +
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git 
> a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr 
> b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> index 8a395eac68..25b7b49a3d 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> @@ -15,14 +15,7 @@
>  #include 
>  #include 
>  #include 
> -
> -//
> -// EFI Variable attributes
> -//
> -#define EFI_VARIABLE_NON_VOLATILE   0x0001
> -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x0002
> -#define EFI_VARIABLE_RUNTIME_ACCESS 0x0004
> -#define EFI_VARIABLE_READ_ONLY  0x0008
> +#include 
>
>  formset
>guid  = SYNQUACER_PLATFORM_FORMSET_GUID,
> --
> 2.11.0
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h

2019-02-11 Thread Leif Lindholm
Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
.vfr rather than local definitions.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm 
---
 .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr 
b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
index 8a395eac68..25b7b49a3d 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
@@ -15,14 +15,7 @@
 #include 
 #include 
 #include 
-
-//
-// EFI Variable attributes
-//
-#define EFI_VARIABLE_NON_VOLATILE   0x0001
-#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x0002
-#define EFI_VARIABLE_RUNTIME_ACCESS 0x0004
-#define EFI_VARIABLE_READ_ONLY  0x0008
+#include 
 
 formset
   guid  = SYNQUACER_PLATFORM_FORMSET_GUID,
-- 
2.11.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel