Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-07-02 Thread Leif Lindholm 
On Wed, Jun 27, 2018 at 05:48:42PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at 
> https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

For series:
Reviewed-by: Leif Lindholm 
Pushed as 693bbd8747..63de92e662.

/
Leif

> Sami Mujawar (6):
>   Platform/ARM: FVP: Add module info to file header
>   Platform/ARM: FVP: Fix function documentation
>   Platform/ARM: FVP: Fix variable declaration
>   Platform/ARM: Juno: Add module info to file header
>   Platform/ARM: Juno: Fix function documentation
>   Platform/ARM: Juno: Fix variable declaration
> 
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc   
>  |  3 +-
>  
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
>   | 86 +-
>  
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
>  |  1 +
>  
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
>|  1 +
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc   
>  |  3 +-
>  
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
>   | 93 ++--
>  
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
>  |  1 +
>  
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
>|  1 +
>  8 files changed, 101 insertions(+), 88 deletions(-)
> 
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-29 Thread Evan Lloyd 



> -Original Message-
> From: edk2-devel  On Behalf Of Evan
> Lloyd
> Sent: 27 June 2018 17:58
> To: Sami Mujawar ; edk2-devel@lists.01.org
> Cc: Arvind Chauhan ; Stephanie Hughes-Fitt
> ; nd 
> Subject: Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-
> dynamictables] Fix issues reported by ecc tool
> 
> 
> Signed-off-by: Evan Lloyd 

 [[Evan Lloyd]] Oops, copy pasted wrong line, sorry.
Reviewed-by: Evan Lloyd 

> 
> > -Original Message-
> > From: Sami Mujawar 
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan ; Daniil Egranov
> > ; Thomas Abraham
> ;
> > leif.lindh...@linaro.org; Evan Lloyd ; Matteo
> > Carlini ; Stephanie Hughes-Fitt
> > ; nd 
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables]
> > Fix issues reported by ecc tool
> >
> > This patch series fixes the issues reported by the ecc tool.
> >
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> >
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> >
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc|  3 +-
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c  | 86 +-
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf |  1 +
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf   |  1 +
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc|  3 +-
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c  | 93 ++--
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf   |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> >
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-28 Thread Leif Lindholm 
On Wed, Jun 27, 2018 at 04:58:04PM +, Evan Lloyd wrote:
> 
> Signed-off-by: Evan Lloyd 

Should I take this one (and the one on the other accompanying set) as
Reviewed-by?

/
Leif

> > -Original Message-
> > From: Sami Mujawar 
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan ; Daniil Egranov
> > ; Thomas Abraham
> > ; leif.lindh...@linaro.org; Evan Lloyd
> > ; Matteo Carlini ;
> > Stephanie Hughes-Fitt ; nd
> > 
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> > issues reported by ecc tool
> > 
> > This patch series fixes the issues reported by the ecc tool.
> > 
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> > 
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> > 
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc|  3 +-
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c  | 86 +-
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf |  1 +
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf   |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc|  3 +-
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c  | 93 ++--
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf   |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> > 
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> > 
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-27 Thread Evan Lloyd 


Signed-off-by: Evan Lloyd 

> -Original Message-
> From: Sami Mujawar 
> Sent: 27 June 2018 17:49
> To: edk2-devel@lists.01.org
> Cc: Arvind Chauhan ; Daniil Egranov
> ; Thomas Abraham
> ; leif.lindh...@linaro.org; Evan Lloyd
> ; Matteo Carlini ;
> Stephanie Hughes-Fitt ; nd
> 
> Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> issues reported by ecc tool
> 
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-
> platforms/tree/290_fix_ecc_issues_v1
> 
> Sami Mujawar (6):
>   Platform/ARM: FVP: Add module info to file header
>   Platform/ARM: FVP: Fix function documentation
>   Platform/ARM: FVP: Fix variable declaration
>   Platform/ARM: Juno: Add module info to file header
>   Platform/ARM: Juno: Fix function documentation
>   Platform/ARM: Juno: Fix variable declaration
> 
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> nc|  3 +-
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManager.c  | 86 +-
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManagerDxe.inf |  1 +
> 
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> rmASLTablesLib.inf   |  1 +
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> sc.inc|  3 +-
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManager.c  | 93 ++--
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManagerDxe.inf |  1 +
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> atformASLTablesLib.inf   |  1 +
>  8 files changed, 101 insertions(+), 88 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-27 Thread Sami Mujawar 
This patch series fixes the issues reported by the ecc tool.

The changes can be seen at 
https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

Sami Mujawar (6):
  Platform/ARM: FVP: Add module info to file header
  Platform/ARM: FVP: Fix function documentation
  Platform/ARM: FVP: Fix variable declaration
  Platform/ARM: Juno: Add module info to file header
  Platform/ARM: Juno: Fix function documentation
  Platform/ARM: Juno: Fix variable declaration

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc 
   |  3 +-
 
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
  | 86 +-
 
Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
 |  1 +
 
Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
   |  1 +
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc 
   |  3 +-
 
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
  | 93 ++--
 
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
 |  1 +
 
Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
   |  1 +
 8 files changed, 101 insertions(+), 88 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel