Re: [edk2] [PATCH edk2-platforms v3 4/5] Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot

2019-02-11 Thread Leif Lindholm 
On Tue, Nov 20, 2018 at 05:01:49PM +0800, Ming Huang wrote:
> Linux kernel will recognize NUMA node by processor order,
> and the Node and proximity domain (PXM) will be not identical
> between BIOS and OS kernel after changing to TA(Totem A) boot,
> so adjust the NUMA node number and proximity domain (PXM) to
> match.

Is this a change that should have gone in together with edk2-platforms
cc2b26de91e09be9f9789d553e7b3e079c822efb?
("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot")

What is the visible effect to a user of the partial change?
Failure to boot? Poor performance?

/
Leif

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang 
> ---
>  Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl |  28 +--
>  Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl |  18 +-
>  Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc| 194 
> ++--
>  3 files changed, 120 insertions(+), 120 deletions(-)
> 
> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl 
> b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
> index 87a2da8843e4..27fde2e09bfe 100644
> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
> @@ -212,7 +212,7 @@ Scope(_SB)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x01)
> +Return(0x00)
>}
>  } // Device(PCI0)
>  
> @@ -262,7 +262,7 @@ Device (PCI1)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x01)
> +Return(0x00)
>}
>  } // Device(PCI1)
>  
> @@ -325,7 +325,7 @@ Device (PCI2)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x01)
> +Return(0x00)
>}
>  }
>  
> @@ -374,7 +374,7 @@ Device (PCI3)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x01)
> +Return(0x00)
>}
>  }
>  
> @@ -423,7 +423,7 @@ Device (PCI4)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x01)
> +Return(0x00)
>}
>  }
>  
> @@ -733,7 +733,7 @@ Device (PCI5)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x01)
> +Return(0x00)
>}
>  }
>  
> @@ -866,11 +866,11 @@ Device (PCI6)
>  // Never allow SHPC (no SHPC controller in this system)
>  And(CTRL,0x1D,CTRL)
>  
> -If(LNotEqual(Arg1,One)) {  // Unknown revision
> +If(LNotEqual(Arg1,One)) { // Unknown revision
>Or(CDW1,0x08,CDW1)
>  }
>  
> -If(LNotEqual(CDW3,CTRL)) {  // Capabilities bits were masked
> +If(LNotEqual(CDW3,CTRL)) { // Capabilities bits were masked
>Or(CDW1,0x10,CDW1)
>  }
>  
> @@ -924,7 +924,7 @@ Device (PCI6)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x03)
> +Return(0x02)
>}
>  } // Device(PCI6)
>  
> @@ -974,7 +974,7 @@ Device (PCI7)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x03)
> +Return(0x02)
>}
>  } // Device(PCI7)
>  
> @@ -1038,7 +1038,7 @@ Device (PCI8)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x03)
> +Return(0x02)
>}
>  }// Device(PCI8)
>  
> @@ -1087,7 +1087,7 @@ Device (PCI9)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x03)
> +Return(0x02)
>}
>  }// Device(PCI9)
>  
> @@ -1136,7 +1136,7 @@ Device (PCIA)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x03)
> +Return(0x02)
>}
>  }// Device(PCIA)
>  
> @@ -1210,7 +1210,7 @@ Device (PCIB)
>  
>Method (_PXM, 0, NotSerialized)
>{
> -Return(0x03)
> +Return(0x02)
>}
>  }
>  
> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl 
> b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
> index 08e15c17bf40..994018db96b5 100644
> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
> @@ -53,7 +53,7 @@
>  [0004]  PRI Interrupt : 
>  [0004] GERR Interrupt : 
>  [0004] Sync Interrupt : 
> -[0004]   Proximity Domain : 0001
> +[0004]   Proximity Domain : 
>  [0004] DeviceID mapping index : 0002
>  
>  [0004] Input base : 
> @@ -97,7 +97,7 @@
>  [0004]  PRI Interrupt : 
>  [0004] GERR Interrupt : 
>  [0004] Sync Interrupt : 
> -[0004]   Proximity Domain : 0001
> +[0004]   Proximity Domain : 
>  [0004] DeviceID mapping index : 0001
>  
>  [0004] Input base : 7c00
> @@ -135,7 +135,7 @@
>  [0004]  PRI Interrupt : 
>  [0004] GERR Interrupt : 
>  [0004] Sync Interrupt : 
> -[0004]   Proximity Domain : 0001
> +[0004]   Proximity Domain :

[edk2] [PATCH edk2-platforms v3 4/5] Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot

2018-11-20 Thread Ming Huang 
Linux kernel will recognize NUMA node by processor order,
and the Node and proximity domain (PXM) will be not identical
between BIOS and OS kernel after changing to TA(Totem A) boot,
so adjust the NUMA node number and proximity domain (PXM) to
match.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang 
---
 Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl |  28 +--
 Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl |  18 +-
 Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc| 194 
++--
 3 files changed, 120 insertions(+), 120 deletions(-)

diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl 
b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
index 87a2da8843e4..27fde2e09bfe 100644
--- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
+++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl
@@ -212,7 +212,7 @@ Scope(_SB)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x01)
+Return(0x00)
   }
 } // Device(PCI0)
 
@@ -262,7 +262,7 @@ Device (PCI1)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x01)
+Return(0x00)
   }
 } // Device(PCI1)
 
@@ -325,7 +325,7 @@ Device (PCI2)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x01)
+Return(0x00)
   }
 }
 
@@ -374,7 +374,7 @@ Device (PCI3)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x01)
+Return(0x00)
   }
 }
 
@@ -423,7 +423,7 @@ Device (PCI4)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x01)
+Return(0x00)
   }
 }
 
@@ -733,7 +733,7 @@ Device (PCI5)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x01)
+Return(0x00)
   }
 }
 
@@ -866,11 +866,11 @@ Device (PCI6)
 // Never allow SHPC (no SHPC controller in this system)
 And(CTRL,0x1D,CTRL)
 
-If(LNotEqual(Arg1,One)) {  // Unknown revision
+If(LNotEqual(Arg1,One)) { // Unknown revision
   Or(CDW1,0x08,CDW1)
 }
 
-If(LNotEqual(CDW3,CTRL)) {  // Capabilities bits were masked
+If(LNotEqual(CDW3,CTRL)) { // Capabilities bits were masked
   Or(CDW1,0x10,CDW1)
 }
 
@@ -924,7 +924,7 @@ Device (PCI6)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x03)
+Return(0x02)
   }
 } // Device(PCI6)
 
@@ -974,7 +974,7 @@ Device (PCI7)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x03)
+Return(0x02)
   }
 } // Device(PCI7)
 
@@ -1038,7 +1038,7 @@ Device (PCI8)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x03)
+Return(0x02)
   }
 }// Device(PCI8)
 
@@ -1087,7 +1087,7 @@ Device (PCI9)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x03)
+Return(0x02)
   }
 }// Device(PCI9)
 
@@ -1136,7 +1136,7 @@ Device (PCIA)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x03)
+Return(0x02)
   }
 }// Device(PCIA)
 
@@ -1210,7 +1210,7 @@ Device (PCIB)
 
   Method (_PXM, 0, NotSerialized)
   {
-Return(0x03)
+Return(0x02)
   }
 }
 
diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl 
b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
index 08e15c17bf40..994018db96b5 100644
--- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
+++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl
@@ -53,7 +53,7 @@
 [0004]  PRI Interrupt : 
 [0004] GERR Interrupt : 
 [0004] Sync Interrupt : 
-[0004]   Proximity Domain : 0001
+[0004]   Proximity Domain : 
 [0004] DeviceID mapping index : 0002
 
 [0004] Input base : 
@@ -97,7 +97,7 @@
 [0004]  PRI Interrupt : 
 [0004] GERR Interrupt : 
 [0004] Sync Interrupt : 
-[0004]   Proximity Domain : 0001
+[0004]   Proximity Domain : 
 [0004] DeviceID mapping index : 0001
 
 [0004] Input base : 7c00
@@ -135,7 +135,7 @@
 [0004]  PRI Interrupt : 
 [0004] GERR Interrupt : 
 [0004] Sync Interrupt : 
-[0004]   Proximity Domain : 0001
+[0004]   Proximity Domain : 
 [0004] DeviceID mapping index : 0001
 
 [0004] Input base : 7400
@@ -173,7 +173,7 @@
 [0004]  PRI Interrupt : 
 [0004] GERR Interrupt : 
 [0004] Sync Interrupt : 
-[0004]   Proximity Domain : 0003
+[0004]   Proximity Domain : 0002
 [0004] DeviceID mapping index : 0002
 
 [0004] Input base : 8000
@@ -217,7 +217,7 @@
 [0004]  PRI Interrupt : 
 [0004] GERR Interrupt : 
 [0004] Sync