Re: [edk2] [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem driver

2018-07-26 Thread Zeng, Star 
Reviewed-by: Star Zeng  and pushed the patch at 
b5bd3ed64898db1088a9468446a0d2d0dc7185e8 with changing the title a little to " 
MdeModulePkg FvSimpleFileSystemDxe: Fix memory leak in Read function ".

Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Vladimir 
Olovyannikov
Sent: Thursday, July 26, 2018 3:48 AM
To: edk2-devel@lists.01.org
Cc: Vladimir Olovyannikov 
Subject: [edk2] [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem 
driver

FvSimpleFileSystem on read always allocates a FileBuffer, and never frees it. 
This causes memory leaks. It is especially bad for reading scripts 
line-by-line. In some cases memory leak can exceed 1GB.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vladimir Olovyannikiov 
---
 .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c   | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c 
b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
index 746f2ced708a..fde208594737 100644
--- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
+++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
@@ -704,6 +704,7 @@ FvSimpleFileSystemRead (
 
 Status = FvFsReadFile (File->Instance->FvProtocol, File->FvFileInfo, 
, );
 if (EFI_ERROR (Status)) {
+  FreePool (FileBuffer);
   return EFI_DEVICE_ERROR;
 }
 
@@ -714,6 +715,8 @@ FvSimpleFileSystemRead (
 CopyMem (Buffer, (UINT8*)FileBuffer + File->Position, *BufferSize);
 File->Position += *BufferSize;
 
+FreePool (FileBuffer);
+
 return EFI_SUCCESS;
   }
 }
--
2.18.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem driver

2018-07-26 Thread Ard Biesheuvel 
(add maintainers)

On 25 July 2018 at 21:47, Vladimir Olovyannikov
 wrote:
> FvSimpleFileSystem on read always allocates a FileBuffer, and never frees
> it. This causes memory leaks. It is especially bad for reading scripts
> line-by-line. In some cases memory leak can exceed 1GB.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vladimir Olovyannikiov 
> ---
>  .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c   | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git 
> a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c 
> b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> index 746f2ced708a..fde208594737 100644
> --- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> +++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> @@ -704,6 +704,7 @@ FvSimpleFileSystemRead (
>
>  Status = FvFsReadFile (File->Instance->FvProtocol, File->FvFileInfo, 
> , );
>  if (EFI_ERROR (Status)) {
> +  FreePool (FileBuffer);
>return EFI_DEVICE_ERROR;
>  }
>
> @@ -714,6 +715,8 @@ FvSimpleFileSystemRead (
>  CopyMem (Buffer, (UINT8*)FileBuffer + File->Position, *BufferSize);
>  File->Position += *BufferSize;
>
> +FreePool (FileBuffer);
> +
>  return EFI_SUCCESS;
>}
>  }
> --
> 2.18.0
>
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v1] MdeModulePkg: Fix memory leak in FvSimpleFileSystem driver

2018-07-25 Thread Vladimir Olovyannikov 
FvSimpleFileSystem on read always allocates a FileBuffer, and never frees
it. This causes memory leaks. It is especially bad for reading scripts
line-by-line. In some cases memory leak can exceed 1GB.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vladimir Olovyannikiov 
---
 .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c   | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c 
b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
index 746f2ced708a..fde208594737 100644
--- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
+++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
@@ -704,6 +704,7 @@ FvSimpleFileSystemRead (
 
 Status = FvFsReadFile (File->Instance->FvProtocol, File->FvFileInfo, 
, );
 if (EFI_ERROR (Status)) {
+  FreePool (FileBuffer);
   return EFI_DEVICE_ERROR;
 }
 
@@ -714,6 +715,8 @@ FvSimpleFileSystemRead (
 CopyMem (Buffer, (UINT8*)FileBuffer + File->Position, *BufferSize);
 File->Position += *BufferSize;
 
+FreePool (FileBuffer);
+
 return EFI_SUCCESS;
   }
 }
-- 
2.18.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel