Re: [edk2] [PATCH v1 0/7] Code refinements in UdfDxe

2018-10-16 Thread Zeng, Star 

On 2018/10/15 12:55, Hao Wu wrote:

This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe
for:

A. Refine asserts used for memory allocation failure and error cases that
are possible to happen. Will use error handling logic for them;

B. Address some dead codes within this module.

Cc: Paulo Alcantara 
Cc: Ruiyu Ni 
Cc: Star Zeng 

Hao Wu (7):
   MdeModulePkg/UdfDxe: Use error handling for memory allocation failure
   MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref
   MdeModulePkg/UdfDxe: Use error handling when fail to return LSN
   MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen()
   MdeModulePkg/UdfDxe: Handle dead codes in File.c
   MdeModulePkg/UdfDxe: Remove dead codes in FileName.c
   MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c

  MdeModulePkg/Universal/Disk/UdfDxe/File.c |  19 ++-
  MdeModulePkg/Universal/Disk/UdfDxe/FileName.c |  15 --
  MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 162 
+++-
  3 files changed, 142 insertions(+), 54 deletions(-)


Hao,

Thanks for the patches.

Reviewed-by: Star Zeng  to patch 1 ~ 6.
Some feedback will be sent for patch 7.

Star





___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 0/7] Code refinements in UdfDxe

2018-10-15 Thread Paulo Alcantara 
Hi,

Hao Wu  writes:

> This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe
> for:
>
> A. Refine asserts used for memory allocation failure and error cases that
>are possible to happen. Will use error handling logic for them;
>
> B. Address some dead codes within this module.
>
> Cc: Paulo Alcantara 
> Cc: Ruiyu Ni 
> Cc: Star Zeng 
>
> Hao Wu (7):
>   MdeModulePkg/UdfDxe: Use error handling for memory allocation failure
>   MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref
>   MdeModulePkg/UdfDxe: Use error handling when fail to return LSN
>   MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen()
>   MdeModulePkg/UdfDxe: Handle dead codes in File.c
>   MdeModulePkg/UdfDxe: Remove dead codes in FileName.c
>   MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c
>
>  MdeModulePkg/Universal/Disk/UdfDxe/File.c |  19 ++-
>  MdeModulePkg/Universal/Disk/UdfDxe/FileName.c |  15 --
>  MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 162 
> +++-
>  3 files changed, 142 insertions(+), 54 deletions(-)

Looks good to me. Thanks!

For the series:

Reviewed-by: Paulo Alcantara 

Paulo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v1 0/7] Code refinements in UdfDxe

2018-10-14 Thread Hao Wu 
This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe
for:

A. Refine asserts used for memory allocation failure and error cases that
   are possible to happen. Will use error handling logic for them;

B. Address some dead codes within this module.

Cc: Paulo Alcantara 
Cc: Ruiyu Ni 
Cc: Star Zeng 

Hao Wu (7):
  MdeModulePkg/UdfDxe: Use error handling for memory allocation failure
  MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref
  MdeModulePkg/UdfDxe: Use error handling when fail to return LSN
  MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen()
  MdeModulePkg/UdfDxe: Handle dead codes in File.c
  MdeModulePkg/UdfDxe: Remove dead codes in FileName.c
  MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c

 MdeModulePkg/Universal/Disk/UdfDxe/File.c |  19 ++-
 MdeModulePkg/Universal/Disk/UdfDxe/FileName.c |  15 --
 MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 162 
+++-
 3 files changed, 142 insertions(+), 54 deletions(-)

-- 
2.12.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel