Re: [edk2] [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option

2018-08-23 Thread Ard Biesheuvel 
On 23 August 2018 at 12:29, Laszlo Ersek  wrote:
> On 08/23/18 07:51, Haojian Zhuang wrote:
>> Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
>> the hotkey of boot option won't be registered correctly.
>>
>> Cc: Laszlo Ersek 
>> Cc: Leif Lindholm 
>> Cc: Ard Biesheuvel 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Haojian Zhuang 
>> ---
>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c 
>> b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> index f9c71d430c99..81d36f218700 100644
>> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> @@ -479,7 +479,7 @@ GetPlatformOptions (
>> NULL,
>> BootOptionNumber,
>> 0,
>> -   BootKeys[Index],
>> +   [Index],
>> NULL
>> );
>>  if (EFI_ERROR (Status)) {
>>
>
> I'm sorry I didn't notice this while reviewing the patch that would end
> up as commit 1b6e7633cad8 ("ArmPkg/PlatformBootManagerLib: load platform
> boot options", 2018-06-05). Also, ellipses are tricky; the compiler
> couldn't help.
>
> Please add the following to the commit message, just above the
> Contributed-under line:
>
> Fixes: 1b6e7633cad8135547f337eeef47f446f57a2505
>
> With that:
>
> Reviewed-by: Laszlo Ersek 
>

Pushed as 2b2959dd347388d9a056d8116e02268cb563ef09

Thanks
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option

2018-08-23 Thread Laszlo Ersek 
On 08/23/18 07:51, Haojian Zhuang wrote:
> Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
> the hotkey of boot option won't be registered correctly.
> 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang 
> ---
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c 
> b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index f9c71d430c99..81d36f218700 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -479,7 +479,7 @@ GetPlatformOptions (
> NULL,
> BootOptionNumber,
> 0,
> -   BootKeys[Index],
> +   [Index],
> NULL
> );
>  if (EFI_ERROR (Status)) {
> 

I'm sorry I didn't notice this while reviewing the patch that would end
up as commit 1b6e7633cad8 ("ArmPkg/PlatformBootManagerLib: load platform
boot options", 2018-06-05). Also, ellipses are tricky; the compiler
couldn't help.

Please add the following to the commit message, just above the
Contributed-under line:

Fixes: 1b6e7633cad8135547f337eeef47f446f57a2505

With that:

Reviewed-by: Laszlo Ersek 

Thanks,
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option

2018-08-22 Thread Haojian Zhuang 
Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
the hotkey of boot option won't be registered correctly.

Cc: Laszlo Ersek 
Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang 
---
 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c 
b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
index f9c71d430c99..81d36f218700 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
@@ -479,7 +479,7 @@ GetPlatformOptions (
NULL,
BootOptionNumber,
0,
-   BootKeys[Index],
+   [Index],
NULL
);
 if (EFI_ERROR (Status)) {
-- 
2.7.4

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel