Re: [edk2] [PATCH v1 1/1] BaseTools: remove unused setter functions
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, August 18, 2018 12:18 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools: remove unused setter functions Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/DecBuildData.py | 17 +-- BaseTools/Source/Python/Workspace/DscBuildData.py | 17 +-- BaseTools/Source/Python/Workspace/InfBuildData.py | 30 ++-- 3 files changed, 4 insertions(+), 60 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DecBuildData.py b/BaseTools/Source/Python/Workspace/DecBuildData.py index 7eeca9524529..45beaebc63ef 100644 --- a/BaseTools/Source/Python/Workspace/DecBuildData.py +++ b/BaseTools/Source/Python/Workspace/DecBuildData.py @@ -116,21 +116,6 @@ class DecBuildData(PackageBuildClassObject): def _GetArch(self): return self._Arch -## Set architecture -# -# Changing the default ARCH to another may affect all other information -# because all information in a platform may be ARCH-related. That's -# why we need to clear all internal used members, in order to cause all -# information to be re-retrieved. -# -# @param Value The value of ARCH -# -def _SetArch(self, Value): -if self._Arch == Value: -return -self._Arch = Value -self._Clear() - ## Retrieve all information in [Defines] section # # (Retriving all [Defines] information in one-shot is just to save time.) @@ -469,7 +454,7 @@ class DecBuildData(PackageBuildClassObject): _Macros = property(_GetMacros) -Arch = property(_GetArch, _SetArch) +Arch = property(_GetArch) PackageName = property(_GetPackageName) Guid = property(_GetFileGuid) Version = property(_GetVersion) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index c7f07f464646..a4ad53ee1558 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -308,21 +308,6 @@ class DscBuildData(PlatformBuildClassObject): def _GetArch(self): return self._Arch -## Set architecture -# -# Changing the default ARCH to another may affect all other information -# because all information in a platform may be ARCH-related. That's -# why we need to clear all internal used members, in order to cause all -# information to be re-retrieved. -# -# @param Value The value of ARCH -# -def _SetArch(self, Value): -if self._Arch == Value: -return -self._Arch = Value -self._Clear() - ## Retrieve all information in [Defines] section # # (Retriving all [Defines] information in one-shot is just to save time.) @@ -2849,7 +2834,7 @@ class DscBuildData(PlatformBuildClassObject): self._DecPcds, self._GuidDict = GetDeclaredPcd(self, self._Bdb, self._Arch, self._Target, self._Toolchain, PkgSet) return self._DecPcds _Macros = property(_GetMacros) -Arch= property(_GetArch, _SetArch) +Arch= property(_GetArch) Platform= property(_GetPlatformName) PlatformName= property(_GetPlatformName) Guid= property(_GetFileGuid) diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python/Workspace/InfBuildData.py index 29e68aeb3bf3..8bff96b14942 100644 --- a/BaseTools/Source/Python/Workspace/InfBuildData.py +++ b/BaseTools/Source/Python/Workspace/InfBuildData.py @@ -173,36 +173,10 @@ class InfBuildData(ModuleBuildClassObject): def _GetArch(self): return self._Arch -## Set architecture -# -# Changing the default ARCH to another may affect all other information -# because all information in a platform may be ARCH-related. That's -# why we need to clear all internal used members, in order to cause all -# information to be re-retrieved. -# -# @param Value The value of ARCH -# -def _SetArch(self, Value): -if self._Arch == Value: -return -self._Arch = Value -self._Clear() - ## Return the name of platform employing this module def _GetPlatform(self): return self._Platform -## Change the name of platform employing this module -# -# Changing the default name of platform to another may affect some information -# because they may be PLATFORM-related. That's why we need to clear all internal -# used members, in order to cause all information to be re-retrieved. -# -def _SetPlatform(self, Value): -if self._Platform == Value: -return -self._Platform = Value -
[edk2] [PATCH v1 1/1] BaseTools: remove unused setter functions
Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/DecBuildData.py | 17 +-- BaseTools/Source/Python/Workspace/DscBuildData.py | 17 +-- BaseTools/Source/Python/Workspace/InfBuildData.py | 30 ++-- 3 files changed, 4 insertions(+), 60 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DecBuildData.py b/BaseTools/Source/Python/Workspace/DecBuildData.py index 7eeca9524529..45beaebc63ef 100644 --- a/BaseTools/Source/Python/Workspace/DecBuildData.py +++ b/BaseTools/Source/Python/Workspace/DecBuildData.py @@ -116,21 +116,6 @@ class DecBuildData(PackageBuildClassObject): def _GetArch(self): return self._Arch -## Set architecture -# -# Changing the default ARCH to another may affect all other information -# because all information in a platform may be ARCH-related. That's -# why we need to clear all internal used members, in order to cause all -# information to be re-retrieved. -# -# @param Value The value of ARCH -# -def _SetArch(self, Value): -if self._Arch == Value: -return -self._Arch = Value -self._Clear() - ## Retrieve all information in [Defines] section # # (Retriving all [Defines] information in one-shot is just to save time.) @@ -469,7 +454,7 @@ class DecBuildData(PackageBuildClassObject): _Macros = property(_GetMacros) -Arch = property(_GetArch, _SetArch) +Arch = property(_GetArch) PackageName = property(_GetPackageName) Guid = property(_GetFileGuid) Version = property(_GetVersion) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index c7f07f464646..a4ad53ee1558 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -308,21 +308,6 @@ class DscBuildData(PlatformBuildClassObject): def _GetArch(self): return self._Arch -## Set architecture -# -# Changing the default ARCH to another may affect all other information -# because all information in a platform may be ARCH-related. That's -# why we need to clear all internal used members, in order to cause all -# information to be re-retrieved. -# -# @param Value The value of ARCH -# -def _SetArch(self, Value): -if self._Arch == Value: -return -self._Arch = Value -self._Clear() - ## Retrieve all information in [Defines] section # # (Retriving all [Defines] information in one-shot is just to save time.) @@ -2849,7 +2834,7 @@ class DscBuildData(PlatformBuildClassObject): self._DecPcds, self._GuidDict = GetDeclaredPcd(self, self._Bdb, self._Arch, self._Target, self._Toolchain, PkgSet) return self._DecPcds _Macros = property(_GetMacros) -Arch= property(_GetArch, _SetArch) +Arch= property(_GetArch) Platform= property(_GetPlatformName) PlatformName= property(_GetPlatformName) Guid= property(_GetFileGuid) diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python/Workspace/InfBuildData.py index 29e68aeb3bf3..8bff96b14942 100644 --- a/BaseTools/Source/Python/Workspace/InfBuildData.py +++ b/BaseTools/Source/Python/Workspace/InfBuildData.py @@ -173,36 +173,10 @@ class InfBuildData(ModuleBuildClassObject): def _GetArch(self): return self._Arch -## Set architecture -# -# Changing the default ARCH to another may affect all other information -# because all information in a platform may be ARCH-related. That's -# why we need to clear all internal used members, in order to cause all -# information to be re-retrieved. -# -# @param Value The value of ARCH -# -def _SetArch(self, Value): -if self._Arch == Value: -return -self._Arch = Value -self._Clear() - ## Return the name of platform employing this module def _GetPlatform(self): return self._Platform -## Change the name of platform employing this module -# -# Changing the default name of platform to another may affect some information -# because they may be PLATFORM-related. That's why we need to clear all internal -# used members, in order to cause all information to be re-retrieved. -# -def _SetPlatform(self, Value): -if self._Platform == Value: -return -self._Platform = Value -self._Clear() def _GetHeaderComments(self): if not self._HeaderComments: self._HeaderComments = [] @@ -1158,8 +1132,8 @@ class InfBuildData(ModuleBuildClassObject): return False _Macros = property(_GetMacros) -Arch = prope
