Re: [edk2] [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules.

2018-05-04 Thread Supreeth Venkatesh 
My response inline.

-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 2:53 PM
To: Supreeth Venkatesh 
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com; 
jiewen@intel.com; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; nd 

Subject: Re: [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM 
modules.

Hi Supreeth,

CIL.

On Fri, Apr 06, 2018 at 03:42:21PM +0100, Supreeth Venkatesh wrote:
> This patch corrects the Module Type Header file for Management
> Mode(MM) as specified in PI v1.6 Specification. Also, it updates
> parameter for auto generated template functions from
> EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Achin Gupta 

-Achin & +Jiewen if possible!
[Supreeth] Ok.

Acked-by: Achin Gupta 

cheers,
Achin

> Signed-off-by: Supreeth Venkatesh 
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index 4d9ea1b2a8..8601e4ee70 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -270,7 +270,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);
>  ${END}
>  """)
> @@ -283,7 +283,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -297,7 +297,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -312,7 +312,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -680,7 +680,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);${END}
>  """),
>  }
> @@ -760,7 +760,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -784,8 +784,8 @@ gModuleTypeHeaderFile = {
>  "UEFI_DRIVER"   :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", 
> "Library/UefiDriverEntryPoint.h"],
>  "UEFI_APPLICATION"  :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", 
> "Library/UefiApplicationEntryPoint.h"],
>  "SMM_CORE"  :   ["PiDxe.h", "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/UefiDriverEntryPoint.h"],
> -"MM_STANDALONE" :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/SmmDriverStandaloneEntryPoint.h"],
> -"MM_CORE_STANDALONE" :  ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/SmmCoreStandaloneEntryPoint.h"],
> +"MM_STANDALONE" :   ["PiMm.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/MmDriverStandaloneEntryPoint.h"],
> +"MM_CORE_STANDALONE":   ["PiMm.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/MmCoreStandaloneEntryPoint.h"],
>  "USER_DEFINED"  :   [gBasicHeaderFile]
>  }
>
> --
> 2.16.2
>
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules.

2018-04-30 Thread Achin Gupta 
Hi Supreeth,

CIL.

On Fri, Apr 06, 2018 at 03:42:21PM +0100, Supreeth Venkatesh wrote:
> This patch corrects the Module Type Header file for Management Mode(MM)
> as specified in PI v1.6 Specification. Also, it updates parameter for
> auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
> EFI_MM_SYSTEM_TABLE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Achin Gupta 

-Achin & +Jiewen if possible!

Acked-by: Achin Gupta 

cheers,
Achin

> Signed-off-by: Supreeth Venkatesh 
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py 
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index 4d9ea1b2a8..8601e4ee70 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -270,7 +270,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);
>  ${END}
>  """)
> @@ -283,7 +283,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  
>  {
> @@ -297,7 +297,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  
>  {
> @@ -312,7 +312,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  
>  {
> @@ -680,7 +680,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);${END}
>  """),
>  }
> @@ -760,7 +760,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -784,8 +784,8 @@ gModuleTypeHeaderFile = {
>  "UEFI_DRIVER"   :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", 
> "Library/UefiDriverEntryPoint.h"],
>  "UEFI_APPLICATION"  :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", 
> "Library/UefiApplicationEntryPoint.h"],
>  "SMM_CORE"  :   ["PiDxe.h", "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/UefiDriverEntryPoint.h"],
> -"MM_STANDALONE" :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/SmmDriverStandaloneEntryPoint.h"],
> -"MM_CORE_STANDALONE" :  ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/SmmCoreStandaloneEntryPoint.h"],
> +"MM_STANDALONE" :   ["PiMm.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/MmDriverStandaloneEntryPoint.h"],
> +"MM_CORE_STANDALONE":   ["PiMm.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h", "Library/MmCoreStandaloneEntryPoint.h"],
>  "USER_DEFINED"  :   [gBasicHeaderFile]
>  }
>  
> -- 
> 2.16.2
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules.

2018-04-06 Thread Supreeth Venkatesh 
This patch corrects the Module Type Header file for Management Mode(MM)
as specified in PI v1.6 Specification. Also, it updates parameter for
auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
EFI_MM_SYSTEM_TABLE.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Achin Gupta 
Signed-off-by: Supreeth Venkatesh 
---
 BaseTools/Source/Python/AutoGen/GenC.py | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenC.py 
b/BaseTools/Source/Python/AutoGen/GenC.py
index 4d9ea1b2a8..8601e4ee70 100644
--- a/BaseTools/Source/Python/AutoGen/GenC.py
+++ b/BaseTools/Source/Python/AutoGen/GenC.py
@@ -270,7 +270,7 @@ EFI_STATUS
 EFIAPI
 ${Function} (
   IN EFI_HANDLEImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   );
 ${END}
 """)
@@ -283,7 +283,7 @@ EFI_STATUS
 EFIAPI
 ProcessModuleEntryPointList (
   IN EFI_HANDLEImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 
 {
@@ -297,7 +297,7 @@ EFI_STATUS
 EFIAPI
 ProcessModuleEntryPointList (
   IN EFI_HANDLEImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 
 {
@@ -312,7 +312,7 @@ EFI_STATUS
 EFIAPI
 ProcessModuleEntryPointList (
   IN EFI_HANDLEImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 
 {
@@ -680,7 +680,7 @@ EFI_STATUS
 EFIAPI
 ${Function} (
   IN EFI_HANDLEImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   );${END}
 """),
 }
@@ -760,7 +760,7 @@ VOID
 EFIAPI
 ProcessLibrary${Type}List (
   IN EFI_HANDLEImageHandle,
-  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
+  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
   )
 {
 ${BEGIN}  EFI_STATUS  Status;
@@ -784,8 +784,8 @@ gModuleTypeHeaderFile = {
 "UEFI_DRIVER"   :   ["Uefi.h",  "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", 
"Library/UefiDriverEntryPoint.h"],
 "UEFI_APPLICATION"  :   ["Uefi.h",  "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/UefiBootServicesTableLib.h", 
"Library/UefiApplicationEntryPoint.h"],
 "SMM_CORE"  :   ["PiDxe.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/UefiDriverEntryPoint.h"],
-"MM_STANDALONE" :   ["PiSmm.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/SmmDriverStandaloneEntryPoint.h"],
-"MM_CORE_STANDALONE" :  ["PiSmm.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/SmmCoreStandaloneEntryPoint.h"],
+"MM_STANDALONE" :   ["PiMm.h",  "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/MmDriverStandaloneEntryPoint.h"],
+"MM_CORE_STANDALONE":   ["PiMm.h",  "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/MmCoreStandaloneEntryPoint.h"],
 "USER_DEFINED"  :   [gBasicHeaderFile]
 }
 
-- 
2.16.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel