Re: [edk2] [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls

2018-09-25 Thread Feng, Bob C
Reviewed-by: Bob Feng 

-Original Message-
From: Carsey, Jaben 
Sent: Monday, September 24, 2018 10:28 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Zhu, Yonghong ; 
Gao, Liming 
Subject: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls

every call to GetAprioriSection() is duplicated on the line below.
remove one of the calls.

Cc: Bob Feng 
Cc: Yonghong Zhu 
Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey 
---
 BaseTools/Source/Python/GenFds/FdfParser.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py 
b/BaseTools/Source/Python/GenFds/FdfParser.py
index 821b3edb7592..f6b79764b2a0 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -2121,7 +2121,6 @@ class FdfParser:
 raise Warning("FvNameString found but FvNameGuid was not found", 
self.FileName, self.CurrentLineNumber)
 
 self._GetAprioriSection(FvObj)
-self._GetAprioriSection(FvObj)
 
 while True:
 isInf = self._GetInfStatement(FvObj) @@ -3780,7 +3779,6 @@ class 
FdfParser:
 self._GetFvAlignment(FvObj)
 self._GetFvAttributes(FvObj)
 self._GetAprioriSection(FvObj)
-self._GetAprioriSection(FvObj)
 
 while True:
 IsInf = self._GetInfStatement(FvObj)
--
2.16.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls

2018-09-24 Thread Jaben Carsey
every call to GetAprioriSection() is duplicated on the line below.
remove one of the calls.

Cc: Bob Feng 
Cc: Yonghong Zhu 
Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey 
---
 BaseTools/Source/Python/GenFds/FdfParser.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py 
b/BaseTools/Source/Python/GenFds/FdfParser.py
index 821b3edb7592..f6b79764b2a0 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -2121,7 +2121,6 @@ class FdfParser:
 raise Warning("FvNameString found but FvNameGuid was not found", 
self.FileName, self.CurrentLineNumber)
 
 self._GetAprioriSection(FvObj)
-self._GetAprioriSection(FvObj)
 
 while True:
 isInf = self._GetInfStatement(FvObj)
@@ -3780,7 +3779,6 @@ class FdfParser:
 self._GetFvAlignment(FvObj)
 self._GetFvAttributes(FvObj)
 self._GetAprioriSection(FvObj)
-self._GetAprioriSection(FvObj)
 
 while True:
 IsInf = self._GetInfStatement(FvObj)
-- 
2.16.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel