Re: [edk2] [PATCH v2] MdeModulePkg: Remove redundant library classes and GUIDs
On 2018/8/14 10:27, shenglei wrote: Some redundant library classes and GUIDs have been removed in inf, .c and .h files. https://bugzilla.tianocore.org/show_bug.cgi?id=1044 https://bugzilla.tianocore.org/show_bug.cgi?id=1045 https://bugzilla.tianocore.org/show_bug.cgi?id=1047 https://bugzilla.tianocore.org/show_bug.cgi?id=1049 https://bugzilla.tianocore.org/show_bug.cgi?id=1051 https://bugzilla.tianocore.org/show_bug.cgi?id=1052 https://bugzilla.tianocore.org/show_bug.cgi?id=1053 https://bugzilla.tianocore.org/show_bug.cgi?id=1054 https://bugzilla.tianocore.org/show_bug.cgi?id=1055 https://bugzilla.tianocore.org/show_bug.cgi?id=1056 https://bugzilla.tianocore.org/show_bug.cgi?id=1017 https://bugzilla.tianocore.org/show_bug.cgi?id=1035 https://bugzilla.tianocore.org/show_bug.cgi?id=1033 https://bugzilla.tianocore.org/show_bug.cgi?id=1012 https://bugzilla.tianocore.org/show_bug.cgi?id=1011 Shenglei, Thanks for the new patch. I think you need also add https://bugzilla.tianocore.org/show_bug.cgi?id=1062 into the list above. v2: 1. Correct copyright year. 2. Fix alignment issue in AcpiPlatformDxe.inf. 3. Add DevicePathLib which is removed before in I2cHostDxe.inf. I think the lib can be removed from I2cHostDxe.inf, but not I2cDxe.inf and Ic2BusDxe.inf. 4. Update NvmExpressPei.inf, NvmExpressPei.h, IScsiDxe.inf, IScsiDxe.h, DxeMain.inf, DxeMain.h, PiSmmCore.inf and PiSmmCore.h for https://bugzilla.tianocore.org/show_bug.cgi?id=1062. Add AtaBusDxe.inf into the file list for BZ1062. Thanks, Star Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 1 - MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 1 - .../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 1 - .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf| 1 - MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 1 - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h | 1 - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf | 1 - MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h| 1 - MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf | 1 - MdeModulePkg/Core/Dxe/DxeMain.h| 1 - MdeModulePkg/Core/Dxe/DxeMain.inf | 2 -- MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.h| 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 3 --- MdeModulePkg/Core/PiSmmCore/SmiHandlerProfile.c| 1 - .../Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 +-- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 2 -- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf | 2 -- MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 1 - MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 2 -- MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2 -- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 1 - MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h | 1 - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 1 - MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h| 1 - MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 1 - .../Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf| 1 - 31 files changed, 1 insertion(+), 39 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c index 894da2f2d9..4d907242f3 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf index 3a67c6b909..d1b11318bb 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf @@ -40,7 +40,6 @@ MdeModulePkg/MdeModulePkg.dec [Guids] - gEfiGlobalVariableGuid ## CONSUMES ## GUID gEfiCapsuleReportGuid ## CONSUMES ## GUID gEfiFmpCapsuleGuid ## CONSUMES ## GUID gWindowsUxCapsuleGuid ## CONSUMES ## GUID diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c
[edk2] [PATCH v2] MdeModulePkg: Remove redundant library classes and GUIDs
Some redundant library classes and GUIDs have been removed in inf, .c and .h files. https://bugzilla.tianocore.org/show_bug.cgi?id=1044 https://bugzilla.tianocore.org/show_bug.cgi?id=1045 https://bugzilla.tianocore.org/show_bug.cgi?id=1047 https://bugzilla.tianocore.org/show_bug.cgi?id=1049 https://bugzilla.tianocore.org/show_bug.cgi?id=1051 https://bugzilla.tianocore.org/show_bug.cgi?id=1052 https://bugzilla.tianocore.org/show_bug.cgi?id=1053 https://bugzilla.tianocore.org/show_bug.cgi?id=1054 https://bugzilla.tianocore.org/show_bug.cgi?id=1055 https://bugzilla.tianocore.org/show_bug.cgi?id=1056 https://bugzilla.tianocore.org/show_bug.cgi?id=1017 https://bugzilla.tianocore.org/show_bug.cgi?id=1035 https://bugzilla.tianocore.org/show_bug.cgi?id=1033 https://bugzilla.tianocore.org/show_bug.cgi?id=1012 https://bugzilla.tianocore.org/show_bug.cgi?id=1011 v2: 1. Correct copyright year. 2. Fix alignment issue in AcpiPlatformDxe.inf. 3. Add DevicePathLib which is removed before in I2cHostDxe.inf. 4. Update NvmExpressPei.inf, NvmExpressPei.h, IScsiDxe.inf, IScsiDxe.h, DxeMain.inf, DxeMain.h, PiSmmCore.inf and PiSmmCore.h for https://bugzilla.tianocore.org/show_bug.cgi?id=1062. Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 1 - MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 1 - .../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 1 - .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf| 1 - MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 1 - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.h | 1 - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf | 1 - MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h| 1 - MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf | 1 - MdeModulePkg/Core/Dxe/DxeMain.h| 1 - MdeModulePkg/Core/Dxe/DxeMain.inf | 2 -- MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.h| 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 3 --- MdeModulePkg/Core/PiSmmCore/SmiHandlerProfile.c| 1 - .../Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 +-- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 2 -- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf | 2 -- MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 1 - MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 2 -- MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2 -- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 1 - MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h | 1 - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 1 - MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h| 1 - MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 1 - .../Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf| 1 - 31 files changed, 1 insertion(+), 39 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c index 894da2f2d9..4d907242f3 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf index 3a67c6b909..d1b11318bb 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf @@ -40,7 +40,6 @@ MdeModulePkg/MdeModulePkg.dec [Guids] - gEfiGlobalVariableGuid ## CONSUMES ## GUID gEfiCapsuleReportGuid ## CONSUMES ## GUID gEfiFmpCapsuleGuid ## CONSUMES ## GUID gWindowsUxCapsuleGuid ## CONSUMES ## GUID diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c index 96e9977aad..a77164b436 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c @@ -22,7 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include #include #include -#include #include #include
