Re: [edk2] [PATCH v2] OvmfPkg: Fix VS toolchain build failure

2016-09-21 Thread Laszlo Ersek 
On 09/22/16 03:38, Laszlo Ersek wrote:
> On 09/22/16 03:37, Laszlo Ersek wrote:
>> On 09/22/16 03:21, Dandan Bi wrote:
>>> V2: add the assert codes.
>>>
>>> Cc: Jordan Justen 
>>> Cc: Laszlo Ersek 
>>> Cc: Liming Gao 
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Dandan Bi 
>>> ---
>>>  OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c 
>>> b/OvmfPkg/VirtioGpuDxe/Commands.c
>>> index b369dc3..962087c 100644
>>> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
>>> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
>>> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>>>}
>>>Header->CtxId = 0;
>>>Header->Padding   = 0;
>>>  
>>>ASSERT (RequestSize >= sizeof *Header);
>>> +  ASSERT (RequestSize <= MAX_UINT32);
>>>  
>>>//
>>>// Compose the descriptor chain.
>>>//
>>>VirtioPrepare (>Ring, );
>>> -  VirtioAppendDesc (>Ring, (UINTN)Header, RequestSize,
>>> +  VirtioAppendDesc (>Ring, (UINTN)Header, (UINT32)RequestSize,
>>>  VRING_DESC_F_NEXT, );
>>>VirtioAppendDesc (>Ring, (UINTN), sizeof Response,
>>>  VRING_DESC_F_WRITE, );
>>>  
>>>//
>>>
>>
>> Reviewed-by: Laszlo Ersek 
>>
> 
> Before you commit the patch, can you please change the subject line like
> this:
> 
> OvmfPkg/VirtioGpuDxe: Fix VS toolchain build failure

I just realized you may not have commit rights. I committed this patch
for you: 7f1bf51bdbca.

Thanks!
Laszlo

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2] OvmfPkg: Fix VS toolchain build failure

2016-09-21 Thread Laszlo Ersek 
On 09/22/16 03:37, Laszlo Ersek wrote:
> On 09/22/16 03:21, Dandan Bi wrote:
>> V2: add the assert codes.
>>
>> Cc: Jordan Justen 
>> Cc: Laszlo Ersek 
>> Cc: Liming Gao 
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Dandan Bi 
>> ---
>>  OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c 
>> b/OvmfPkg/VirtioGpuDxe/Commands.c
>> index b369dc3..962087c 100644
>> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
>> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
>> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>>}
>>Header->CtxId = 0;
>>Header->Padding   = 0;
>>  
>>ASSERT (RequestSize >= sizeof *Header);
>> +  ASSERT (RequestSize <= MAX_UINT32);
>>  
>>//
>>// Compose the descriptor chain.
>>//
>>VirtioPrepare (>Ring, );
>> -  VirtioAppendDesc (>Ring, (UINTN)Header, RequestSize,
>> +  VirtioAppendDesc (>Ring, (UINTN)Header, (UINT32)RequestSize,
>>  VRING_DESC_F_NEXT, );
>>VirtioAppendDesc (>Ring, (UINTN), sizeof Response,
>>  VRING_DESC_F_WRITE, );
>>  
>>//
>>
> 
> Reviewed-by: Laszlo Ersek 
> 

Before you commit the patch, can you please change the subject line like
this:

OvmfPkg/VirtioGpuDxe: Fix VS toolchain build failure

Thanks!
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2] OvmfPkg: Fix VS toolchain build failure

2016-09-21 Thread Laszlo Ersek 
On 09/22/16 03:21, Dandan Bi wrote:
> V2: add the assert codes.
> 
> Cc: Jordan Justen 
> Cc: Laszlo Ersek 
> Cc: Liming Gao 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi 
> ---
>  OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
> index b369dc3..962087c 100644
> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>}
>Header->CtxId = 0;
>Header->Padding   = 0;
>  
>ASSERT (RequestSize >= sizeof *Header);
> +  ASSERT (RequestSize <= MAX_UINT32);
>  
>//
>// Compose the descriptor chain.
>//
>VirtioPrepare (>Ring, );
> -  VirtioAppendDesc (>Ring, (UINTN)Header, RequestSize,
> +  VirtioAppendDesc (>Ring, (UINTN)Header, (UINT32)RequestSize,
>  VRING_DESC_F_NEXT, );
>VirtioAppendDesc (>Ring, (UINTN), sizeof Response,
>  VRING_DESC_F_WRITE, );
>  
>//
> 

Reviewed-by: Laszlo Ersek 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v2] OvmfPkg: Fix VS toolchain build failure

2016-09-21 Thread Dandan Bi 
V2: add the assert codes.

Cc: Jordan Justen 
Cc: Laszlo Ersek 
Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi 
---
 OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
index b369dc3..962087c 100644
--- a/OvmfPkg/VirtioGpuDxe/Commands.c
+++ b/OvmfPkg/VirtioGpuDxe/Commands.c
@@ -282,16 +282,17 @@ VirtioGpuSendCommand (
   }
   Header->CtxId = 0;
   Header->Padding   = 0;
 
   ASSERT (RequestSize >= sizeof *Header);
+  ASSERT (RequestSize <= MAX_UINT32);
 
   //
   // Compose the descriptor chain.
   //
   VirtioPrepare (>Ring, );
-  VirtioAppendDesc (>Ring, (UINTN)Header, RequestSize,
+  VirtioAppendDesc (>Ring, (UINTN)Header, (UINT32)RequestSize,
 VRING_DESC_F_NEXT, );
   VirtioAppendDesc (>Ring, (UINTN), sizeof Response,
 VRING_DESC_F_WRITE, );
 
   //
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel