Re: [edk2] [PATCH v2 0/6] ATA PassThru & SATA device path PortMultiplier update

2016-05-11 Thread Tian, Feng 
Looks good to me

Reviewed-by: Feng Tian 

Thanks
Feng

-Original Message-
From: Wu, Hao A 
Sent: Tuesday, May 10, 2016 10:25 AM
To: edk2-devel@lists.01.org; Tian, Feng 
Cc: Wu, Hao A 
Subject: [PATCH v2 0/6] ATA PassThru & SATA device path PortMultiplier update

Changes compared with V1:
1. Update the commit log messages to reflect the correct UEFI spec version
   that the 'PortMultiplier' semantic change is introduced.

2. Update two OVMF library instances to adapt to the 'PortMultiplier'
   semantic change.

The UEFI 2.5 & 2.5 Errata spec updated the description of the port multiplier 
port number parameter in SATA Device Path Node and ATA Pass-Through Protocol.

Now, this parameter should be set to 0x instead of 0 to indicate that an 
ATA device is directly attached on the controller port.

Hao Wu (4):
  MdePkg Protocol/DevicePath.h: Update SATA Device Path comments
  MdePkg Protocol/AtaPassThru.h: Update PortMultiplierPort related
comments
  MdeModulePkg Ata: Use the new (incompatible) PortMultiplierPort
semantics
  MdeModulePkg AtaAtapiPassThru: Fix incorrect parameter description
comment

Laszlo Ersek (2):
  OvmfPkg/QemuNewBootOrderLib: adapt Q35 SATA PMPN to UEFI spec Mantis
1353
  OvmfPkg/QemuBootOrderLib: adapt Q35 SATA PMPN to UEFI spec Mantis 1353

 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c   | 14 ++--
 .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c| 75 +-
 .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h| 12 ++--
 MdePkg/Include/Protocol/AtaPassThru.h  |  8 +--
 MdePkg/Include/Protocol/DevicePath.h   |  4 +-
 .../Library/QemuBootOrderLib/QemuBootOrderLib.c| 10 +--
 .../Library/QemuNewBootOrderLib/QemuBootOrderLib.c | 10 +--
 7 files changed, 88 insertions(+), 45 deletions(-)

--
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v2 0/6] ATA PassThru & SATA device path PortMultiplier update

2016-05-09 Thread Hao Wu 
Changes compared with V1:
1. Update the commit log messages to reflect the correct UEFI spec version
   that the 'PortMultiplier' semantic change is introduced.

2. Update two OVMF library instances to adapt to the 'PortMultiplier'
   semantic change.

The UEFI 2.5 & 2.5 Errata spec updated the description of the port
multiplier port number parameter in SATA Device Path Node and ATA
Pass-Through Protocol.

Now, this parameter should be set to 0x instead of 0 to indicate that
an ATA device is directly attached on the controller port.

Hao Wu (4):
  MdePkg Protocol/DevicePath.h: Update SATA Device Path comments
  MdePkg Protocol/AtaPassThru.h: Update PortMultiplierPort related
comments
  MdeModulePkg Ata: Use the new (incompatible) PortMultiplierPort
semantics
  MdeModulePkg AtaAtapiPassThru: Fix incorrect parameter description
comment

Laszlo Ersek (2):
  OvmfPkg/QemuNewBootOrderLib: adapt Q35 SATA PMPN to UEFI spec Mantis
1353
  OvmfPkg/QemuBootOrderLib: adapt Q35 SATA PMPN to UEFI spec Mantis 1353

 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c   | 14 ++--
 .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c| 75 +-
 .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h| 12 ++--
 MdePkg/Include/Protocol/AtaPassThru.h  |  8 +--
 MdePkg/Include/Protocol/DevicePath.h   |  4 +-
 .../Library/QemuBootOrderLib/QemuBootOrderLib.c| 10 +--
 .../Library/QemuNewBootOrderLib/QemuBootOrderLib.c | 10 +--
 7 files changed, 88 insertions(+), 45 deletions(-)

-- 
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel