Hi Laszlo, Thanks.
Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 21, 2018 11:45 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: Re: [edk2] [PATCH v2 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: implement non-stop mode for SMM On 08/21/18 05:05, Jian J Wang wrote: >> v2 changes: >> fix GCC build error caused by an unused variable in GuardPagePFHandler() > > Since SMM profile feature has already implemented non-stop mode if #PF > occurred, this patch just makes use of the existing implementation to > accommodate heap guard and NULL pointer detection feature. > > Cc: Eric Dong <eric.d...@intel.com<mailto:eric.d...@intel.com>> > Cc: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>> > Cc: Ruiyu Ni <ruiyu...@intel.com<mailto:ruiyu...@intel.com>> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>> > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 43 ++++++++++++------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.nasm | 3 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 58 > +++++++++++++++++++++++- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h | 15 ++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 6 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 43 ++++++++++++------ > 6 files changed, 137 insertions(+), 31 deletions(-) It seems like the changes are no-ops for platforms that set all these PCDs to zero, so from my side Acked-by: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>> Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
