[edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

[Ard Biesheuvel]

The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not
supported by CLANG. So restrict its use to GCC 4.6, which is the oldest
version we support for ARM.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel 
---
 ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf 
b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
index 39c74bf1a3c2..b7149d82c3c5 100644
--- a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+++ b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
@@ -45,5 +45,6 @@ [Packages]
   MdePkg/MdePkg.dec
 
 [BuildOptions]
-  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare -fno-tree-vrp
+  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare
+  *_GCC46_*_CC_FLAGS = -fno-tree-vrp
   RVCT:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC
-- 
2.5.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

[Leif Lindholm]

On Tue, Dec 15, 2015 at 03:24:55PM +0100, Ard Biesheuvel wrote:
> The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not
> supported by CLANG. So restrict its use to GCC 4.6, which is the oldest
> version we support for ARM.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel 
> ---
>  ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf 
> b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> index 39c74bf1a3c2..b7149d82c3c5 100644
> --- a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +++ b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> @@ -45,5 +45,6 @@ [Packages]
>MdePkg/MdePkg.dec
>  
>  [BuildOptions]
> -  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare -fno-tree-vrp
> +  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare
> +  *_GCC46_*_CC_FLAGS = -fno-tree-vrp
>RVCT:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC
> -- 
> 2.5.0

I'm still confused about this patch - the reference you included in
your last response pointed to something saying the issue was resolved
in 4.7.1. So would we not need this for GCC46/GCC47?

/
Leif

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

[Leif Lindholm]

On Tue, Dec 15, 2015 at 03:50:43PM +0100, Ard Biesheuvel wrote:
> On 15 December 2015 at 15:47, Leif Lindholm  wrote:
> > On Tue, Dec 15, 2015 at 03:24:55PM +0100, Ard Biesheuvel wrote:
> >> The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not
> >> supported by CLANG. So restrict its use to GCC 4.6, which is the oldest
> >> version we support for ARM.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.0
> >> Signed-off-by: Ard Biesheuvel 
> >> ---
> >>  ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf 
> >> b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> >> index 39c74bf1a3c2..b7149d82c3c5 100644
> >> --- a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> >> +++ b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> >> @@ -45,5 +45,6 @@ [Packages]
> >>MdePkg/MdePkg.dec
> >>
> >>  [BuildOptions]
> >> -  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare -fno-tree-vrp
> >> +  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare
> >> +  *_GCC46_*_CC_FLAGS = -fno-tree-vrp
> >>RVCT:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC
> >> --
> >> 2.5.0
> >
> > I'm still confused about this patch - the reference you included in
> > your last response pointed to something saying the issue was resolved
> > in 4.7.1. So would we not need this for GCC46/GCC47?
> >
> 
> Happy to add it for 4.7 as well. I just wonder how many users of GCC
> 4.7 are using 4.7.0. And this is assuming that the -fno-tree-vrp is
> there for a reason that applied to the ARM softfloat code at any point
> in the past.
> 
> So I propose we just make it
> 
> >> -  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare -fno-tree-vrp
> >> +  GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare
> >> +  *_GCC46_*_CC_FLAGS = -fno-tree-vrp
> >> +  *_GCC47_*_CC_FLAGS = -fno-tree-vrp
> 
> and be done with it?

That works for me:
Reviewed-by: Leif Lindholm 

/
Leif
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel