Re: [edk2] [PATCH v2 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition

2018-08-16 Thread Leif Lindholm
On Thu, Aug 16, 2018 at 09:49:24AM +0800, Haojian Zhuang wrote:
> Fix the LDO9_VSET register definition in PMIC. LDO9 is used
> by Designware SD controller. Without this fix, SD controller
> fails to operate SD card since lack of right voltage setting.
> 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang 

Reviewed-by: Leif Lindholm 
Pushed as d11581e5fd.

> ---
>  Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h 
> b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
> index 5fbf32267657..6e0587f7783a 100644
> --- a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
> +++ b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
> @@ -58,7 +58,7 @@
>  #define USB3OTG_PHY_CR_CAP_ADDR (1 << 0)
>  
>  #define PMU_REG_BASE0xFFF34000
> -#define PMIC_LDO9_VSET_REG  (PMU_REG_BASE + (0x068 << 2))
> +#define PMIC_LDO9_VSET_REG  (PMU_REG_BASE + (0x06b << 2))
>  #define LDO9_VSET_MASK  (7 << 0)
>  
>  #define PMIC_LDO16_ONOFF_ECO_REG(PMU_REG_BASE + (0x078 << 2))
> -- 
> 2.7.4
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH v2 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition

2018-08-15 Thread Haojian Zhuang
Fix the LDO9_VSET register definition in PMIC. LDO9 is used
by Designware SD controller. Without this fix, SD controller
fails to operate SD card since lack of right voltage setting.

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang 
---
 Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h 
b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
index 5fbf32267657..6e0587f7783a 100644
--- a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
+++ b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
@@ -58,7 +58,7 @@
 #define USB3OTG_PHY_CR_CAP_ADDR (1 << 0)
 
 #define PMU_REG_BASE0xFFF34000
-#define PMIC_LDO9_VSET_REG  (PMU_REG_BASE + (0x068 << 2))
+#define PMIC_LDO9_VSET_REG  (PMU_REG_BASE + (0x06b << 2))
 #define LDO9_VSET_MASK  (7 << 0)
 
 #define PMIC_LDO16_ONOFF_ECO_REG(PMU_REG_BASE + (0x078 << 2))
-- 
2.7.4

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel