Re: [edk2] [PATCH v3 0/3] Remove unnecessary NULL pointer check.

2019-01-22 Thread Wu, Hao A
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, January 18, 2019 3:18 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan; Wu, Hao A; Gao, Liming; Wu
> Subject: [PATCH v3 0/3] Remove unnecessary NULL pointer check.
> 
> v3: Updated the first patch to check the instance token.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
> 
> Since the value retrieved from the list Entry can't be the NULL
> pointer, the unnecessary check can be removed.

The series is good to me:
Reviewed-by: Hao Wu 

Best Regards,
Hao Wu

> 
> Cc: Ye Ting 
> Cc: Fu Siyuan 
> Cc: Wu Hao A 
> Cc: Gao Liming 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin  
> Jiaxin Wu (3):
>   MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.
>   NetworkPkg/IScsiDxe: Remove unnecessary NULL pointer check.
>   NetworkPkg/DnsDxe: Remove unnecessary NULL pointer check.
> 
>  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c  | 11 --
>  NetworkPkg/DnsDxe/DnsDriver.c  | 22 
> ---
>  NetworkPkg/IScsiDxe/IScsiConfig.c  |  6 +
>  3 files changed, 14 insertions(+), 25 deletions(-)
> 
> --
> 2.17.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH v3 0/3] Remove unnecessary NULL pointer check.

2019-01-17 Thread Jiaxin Wu
v3: Updated the first patch to check the instance token.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469

Since the value retrieved from the list Entry can't be the NULL
pointer, the unnecessary check can be removed.

Cc: Ye Ting 
Cc: Fu Siyuan 
Cc: Wu Hao A 
Cc: Gao Liming 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin https://lists.01.org/mailman/listinfo/edk2-devel