Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Hi Jiewen, On Mon, Jun 18, 2018 at 03:12:46PM +, Yao, Jiewen wrote: > Yes. I think so. > > However, I found the V3 just contains partial of the patch. It is hard to > find some V2 and some V3. > Also this series includes multiple package. We need different package > maintainer to push different patches. > > I recommend we do in this way: > Please split this big one into 3 - BaseTool patch, ArmPkg patch, and > StandaloneMmPkg patch. > > Then BaseTool maintainer can push BaseTool patch, ArmPkg maintainer can push > ArmPkg patch, and I can help push StandaloneMmPkg patch. Thomas and Sugosh will refactor the patches and repost since Supreeth is on holiday. I started late but would like to finish reviewing the Arm specific bits in the StandaloneMmPkg before they are merged. Will not take more than 2 days. Could you please merge after I ack. Hope that is fine? cheers, Achin > > Thank you > Yao Jiewen > > > -Original Message- > > From: Thomas Abraham [mailto:thomas.abra...@arm.com] > > Sent: Monday, June 18, 2018 6:07 AM > > To: Sughosh Ganu > > Cc: Supreeth Venkatesh ; > > edk2-devel@lists.01.org; Yao, Jiewen ; Gao, Liming > > > > Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core > > Interface for AARCH64 Platforms *** > > > > On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu wrote: > > > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh > > > wrote: > > >> *** > > >> This patchset v3 contains only the patches that got feedback/comments > > frome the previous revision v2. > > >> The patches are > > >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. > > >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point > > library. > > >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules. > > >> > > >> Changes Since v2: > > >> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update > > header file for MM modules." > > >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit > > "StandaloneMmPkg: Add an AArch64 specific entry point library." > > >> > > >> Changes Since v1: > > >> (*) Reorder and Reword commits. > > >> (*) Reorganize structure of StandaloneMmPkg and rename libraries. > > >> (*) Address Review Comments from Achin, Jiewen and Daniil. > > >> *** > > >> Supreeth Venkatesh (17): > > >> ArmPkg: Add PCDs needed for MM communication driver. > > >> ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. > > >> ArmPkg/Include: Add MM interface SVC return codes. > > >> ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. > > >> ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. > > >> StandaloneMmPkg: Delete StandaloneMmPkg file. > > >> StandaloneMmPkg/FvLib: Add a common FV Library for management > > mode. > > >> StandaloneMmPkg/MemLib: Add Standalone MM instance of memory > > check > > >> library. > > >> StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation > > library. > > >> StandaloneMmPkg/HobLib: Add HOB Library for management mode. > > >> StandaloneMmPkg: MM driver entry point library. > > >> StandaloneMmPkg/Core: Implementation of Standalone MM Core > > Module. > > >> StandaloneMmPkg: Add an AArch64 specific entry point library. > > >> StandaloneMmPkg: Add CPU driver suitable for ARM Platforms. > > >> StandaloneMmPkg: Describe the declaration and definition files. > > >> ArmPkg: Extra action to update permissions for S-ELO MM Image. > > >> BaseTools/AutoGen: Update header file for MM modules. > > > > > > Tested all changes for RAS error injection and error handling on > > > SGI575 platform. > > > > > > Tested-by: Sughosh Ganu > > > > > > -sughosh > > > > There have been no further comments on this series. Can this patch > > series be merged? > > > > Thanks, > > Thomas. > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Yes. I think so. However, I found the V3 just contains partial of the patch. It is hard to find some V2 and some V3. Also this series includes multiple package. We need different package maintainer to push different patches. I recommend we do in this way: Please split this big one into 3 - BaseTool patch, ArmPkg patch, and StandaloneMmPkg patch. Then BaseTool maintainer can push BaseTool patch, ArmPkg maintainer can push ArmPkg patch, and I can help push StandaloneMmPkg patch. Thank you Yao Jiewen > -Original Message- > From: Thomas Abraham [mailto:thomas.abra...@arm.com] > Sent: Monday, June 18, 2018 6:07 AM > To: Sughosh Ganu > Cc: Supreeth Venkatesh ; > edk2-devel@lists.01.org; Yao, Jiewen ; Gao, Liming > > Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core > Interface for AARCH64 Platforms *** > > On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu wrote: > > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh > > wrote: > >> *** > >> This patchset v3 contains only the patches that got feedback/comments > frome the previous revision v2. > >> The patches are > >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. > >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point > library. > >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules. > >> > >> Changes Since v2: > >> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update > header file for MM modules." > >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit > "StandaloneMmPkg: Add an AArch64 specific entry point library." > >> > >> Changes Since v1: > >> (*) Reorder and Reword commits. > >> (*) Reorganize structure of StandaloneMmPkg and rename libraries. > >> (*) Address Review Comments from Achin, Jiewen and Daniil. > >> *** > >> Supreeth Venkatesh (17): > >> ArmPkg: Add PCDs needed for MM communication driver. > >> ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. > >> ArmPkg/Include: Add MM interface SVC return codes. > >> ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. > >> ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. > >> StandaloneMmPkg: Delete StandaloneMmPkg file. > >> StandaloneMmPkg/FvLib: Add a common FV Library for management > mode. > >> StandaloneMmPkg/MemLib: Add Standalone MM instance of memory > check > >> library. > >> StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation > library. > >> StandaloneMmPkg/HobLib: Add HOB Library for management mode. > >> StandaloneMmPkg: MM driver entry point library. > >> StandaloneMmPkg/Core: Implementation of Standalone MM Core > Module. > >> StandaloneMmPkg: Add an AArch64 specific entry point library. > >> StandaloneMmPkg: Add CPU driver suitable for ARM Platforms. > >> StandaloneMmPkg: Describe the declaration and definition files. > >> ArmPkg: Extra action to update permissions for S-ELO MM Image. > >> BaseTools/AutoGen: Update header file for MM modules. > > > > Tested all changes for RAS error injection and error handling on > > SGI575 platform. > > > > Tested-by: Sughosh Ganu > > > > -sughosh > > There have been no further comments on this series. Can this patch > series be merged? > > Thanks, > Thomas. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu wrote: > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh > wrote: >> *** >> This patchset v3 contains only the patches that got feedback/comments frome >> the previous revision v2. >> The patches are >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point >> library. >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules. >> >> Changes Since v2: >> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update >> header file for MM modules." >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit >> "StandaloneMmPkg: Add an AArch64 specific entry point library." >> >> Changes Since v1: >> (*) Reorder and Reword commits. >> (*) Reorganize structure of StandaloneMmPkg and rename libraries. >> (*) Address Review Comments from Achin, Jiewen and Daniil. >> *** >> Supreeth Venkatesh (17): >> ArmPkg: Add PCDs needed for MM communication driver. >> ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. >> ArmPkg/Include: Add MM interface SVC return codes. >> ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. >> ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. >> StandaloneMmPkg: Delete StandaloneMmPkg file. >> StandaloneMmPkg/FvLib: Add a common FV Library for management mode. >> StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check >> library. >> StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library. >> StandaloneMmPkg/HobLib: Add HOB Library for management mode. >> StandaloneMmPkg: MM driver entry point library. >> StandaloneMmPkg/Core: Implementation of Standalone MM Core Module. >> StandaloneMmPkg: Add an AArch64 specific entry point library. >> StandaloneMmPkg: Add CPU driver suitable for ARM Platforms. >> StandaloneMmPkg: Describe the declaration and definition files. >> ArmPkg: Extra action to update permissions for S-ELO MM Image. >> BaseTools/AutoGen: Update header file for MM modules. > > Tested all changes for RAS error injection and error handling on > SGI575 platform. > > Tested-by: Sughosh Ganu > > -sughosh There have been no further comments on this series. Can this patch series be merged? Thanks, Thomas. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Thanks for Testing. Appreciate it. Supreeth -Original Message- From: Sughosh Ganu Sent: Wednesday, June 6, 2018 6:20 AM To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org; jiewen@intel.com; liming@intel.com Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms *** On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh wrote: > *** > This patchset v3 contains only the patches that got feedback/comments frome > the previous revision v2. > The patches are > [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. > [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library. > [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules. > > Changes Since v2: > (*) Address feedback provided for the commit "BaseTools/AutoGen: Update > header file for MM modules." > (*) Edit parameters for the StandaloneMmCpu Driver in the commit > "StandaloneMmPkg: Add an AArch64 specific entry point library." > > Changes Since v1: > (*) Reorder and Reword commits. > (*) Reorganize structure of StandaloneMmPkg and rename libraries. > (*) Address Review Comments from Achin, Jiewen and Daniil. > *** > Supreeth Venkatesh (17): > ArmPkg: Add PCDs needed for MM communication driver. > ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. > ArmPkg/Include: Add MM interface SVC return codes. > ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. > ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. > StandaloneMmPkg: Delete StandaloneMmPkg file. > StandaloneMmPkg/FvLib: Add a common FV Library for management mode. > StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check > library. > StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library. > StandaloneMmPkg/HobLib: Add HOB Library for management mode. > StandaloneMmPkg: MM driver entry point library. > StandaloneMmPkg/Core: Implementation of Standalone MM Core Module. > StandaloneMmPkg: Add an AArch64 specific entry point library. > StandaloneMmPkg: Add CPU driver suitable for ARM Platforms. > StandaloneMmPkg: Describe the declaration and definition files. > ArmPkg: Extra action to update permissions for S-ELO MM Image. > BaseTools/AutoGen: Update header file for MM modules. Tested all changes for RAS error injection and error handling on SGI575 platform. Tested-by: Sughosh Ganu -sughosh IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh wrote: > *** > This patchset v3 contains only the patches that got feedback/comments frome > the previous revision v2. > The patches are > [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. > [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library. > [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules. > > Changes Since v2: > (*) Address feedback provided for the commit "BaseTools/AutoGen: Update > header file for MM modules." > (*) Edit parameters for the StandaloneMmCpu Driver in the commit > "StandaloneMmPkg: Add an AArch64 specific entry point library." > > Changes Since v1: > (*) Reorder and Reword commits. > (*) Reorganize structure of StandaloneMmPkg and rename libraries. > (*) Address Review Comments from Achin, Jiewen and Daniil. > *** > Supreeth Venkatesh (17): > ArmPkg: Add PCDs needed for MM communication driver. > ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. > ArmPkg/Include: Add MM interface SVC return codes. > ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. > ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. > StandaloneMmPkg: Delete StandaloneMmPkg file. > StandaloneMmPkg/FvLib: Add a common FV Library for management mode. > StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check > library. > StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library. > StandaloneMmPkg/HobLib: Add HOB Library for management mode. > StandaloneMmPkg: MM driver entry point library. > StandaloneMmPkg/Core: Implementation of Standalone MM Core Module. > StandaloneMmPkg: Add an AArch64 specific entry point library. > StandaloneMmPkg: Add CPU driver suitable for ARM Platforms. > StandaloneMmPkg: Describe the declaration and definition files. > ArmPkg: Extra action to update permissions for S-ELO MM Image. > BaseTools/AutoGen: Update header file for MM modules. Tested all changes for RAS error injection and error handling on SGI575 platform. Tested-by: Sughosh Ganu -sughosh ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
*** This patchset v3 contains only the patches that got feedback/comments frome the previous revision v2. The patches are [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library. [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules. Changes Since v2: (*) Address feedback provided for the commit "BaseTools/AutoGen: Update header file for MM modules." (*) Edit parameters for the StandaloneMmCpu Driver in the commit "StandaloneMmPkg: Add an AArch64 specific entry point library." Changes Since v1: (*) Reorder and Reword commits. (*) Reorganize structure of StandaloneMmPkg and rename libraries. (*) Address Review Comments from Achin, Jiewen and Daniil. *** Supreeth Venkatesh (17): ArmPkg: Add PCDs needed for MM communication driver. ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. ArmPkg/Include: Add MM interface SVC return codes. ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0. StandaloneMmPkg: Delete StandaloneMmPkg file. StandaloneMmPkg/FvLib: Add a common FV Library for management mode. StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check library. StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library. StandaloneMmPkg/HobLib: Add HOB Library for management mode. StandaloneMmPkg: MM driver entry point library. StandaloneMmPkg/Core: Implementation of Standalone MM Core Module. StandaloneMmPkg: Add an AArch64 specific entry point library. StandaloneMmPkg: Add CPU driver suitable for ARM Platforms. StandaloneMmPkg: Describe the declaration and definition files. ArmPkg: Extra action to update permissions for S-ELO MM Image. BaseTools/AutoGen: Update header file for MM modules. ArmPkg/ArmPkg.dec |3 + .../MmCommunicationDxe/MmCommunication.c | 408 +++ .../MmCommunicationDxe/MmCommunication.inf| 50 + ArmPkg/Include/IndustryStandard/ArmMmSvc.h|9 +- .../AArch64/ArmMmuStandaloneMmCoreLib.c | 195 +++ .../ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf | 37 + .../DebugPeCoffExtraActionLib.c | 185 ++- .../DebugPeCoffExtraActionLib.inf |7 + BaseTools/Source/Python/AutoGen/GenC.py | 16 +- StandaloneMmPkg |0 StandaloneMmPkg/Core/Dependency.c | 389 ++ StandaloneMmPkg/Core/Dispatcher.c | 1071 + StandaloneMmPkg/Core/FwVol.c | 104 ++ StandaloneMmPkg/Core/Handle.c | 533 .../Core/InstallConfigurationTable.c | 178 +++ StandaloneMmPkg/Core/Locate.c | 496 StandaloneMmPkg/Core/Mmi.c| 337 ++ StandaloneMmPkg/Core/Notify.c | 203 StandaloneMmPkg/Core/Page.c | 384 ++ StandaloneMmPkg/Core/Pool.c | 287 + StandaloneMmPkg/Core/StandaloneMmCore.c | 708 +++ StandaloneMmPkg/Core/StandaloneMmCore.h | 903 ++ StandaloneMmPkg/Core/StandaloneMmCore.inf | 80 ++ .../Core/StandaloneMmCorePrivateData.h| 66 + .../StandaloneMmCpu/AArch64/EventHandle.c | 208 .../StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 219 .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 64 + .../AArch64/StandaloneMmCpu.inf | 59 + StandaloneMmPkg/Include/Guid/MmCoreData.h | 133 ++ StandaloneMmPkg/Include/Guid/MmFvDispatch.h | 38 + .../Include/Guid/MmramMemoryReserve.h | 62 + StandaloneMmPkg/Include/Guid/MpInformation.h | 41 + .../AArch64/StandaloneMmCoreEntryPoint.h | 214 StandaloneMmPkg/Include/Library/FvLib.h | 109 ++ .../Library/StandaloneMmCoreEntryPoint.h | 101 ++ .../Library/StandaloneMmDriverEntryPoint.h| 148 +++ .../Include/Library/StandaloneMmMemLib.h | 140 +++ StandaloneMmPkg/Include/StandaloneMm.h| 36 + StandaloneMmPkg/Library/FvLib/FvLib.c | 386 ++ StandaloneMmPkg/Library/FvLib/FvLib.inf | 57 + .../AArch64/CreateHobList.c | 200 +++ .../AArch64/SetPermissions.c | 275 + .../AArch64/StandaloneMmCoreEntryPoint.c | 287 + .../StandaloneMmCoreEntryPoint.inf| 55 + .../AArch64/StandaloneMmCoreHobLibInternal.c | 64 + .../StandaloneMmCoreHobLib.c | 608 ++ .../StandaloneMmCoreHobLib.inf| 47 + .../StandaloneMmCoreMemoryAllocationLib.c | 907 ++ .../StandaloneMmCoreMemoryAllocationLib.inf | 49 + ...StandaloneMmCoreMemoryAllocationServices.h | 38 + .../StandaloneMmDriverEntryPoint.c| 99 ++ .../StandaloneMmDriverEntryPoint.inf | 41 + .../AArch64/StandaloneMmMemLibInternal.c | 49 +
