Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, February 01, 2019 5:40 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support > LockBox enlarge in UpdateLockBox() > > Hi Hao, > > On 02/01/19 06:47, Hao Wu wrote: > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 > > > > This commit will add the support to enlarge a LockBox when using the > > LockBoxLib API UpdateLockBox(). > > > > Please note that the new support will ONLY work for LockBox with attribute > > LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. > > > > The functional uni-test for the commit is available at: > > https://github.com/hwu25/edk2/tree/lockbox_unitest > > > > Cc: Jian J Wang > > Cc: Ray Ni > > Cc: Star Zeng > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Hao Wu > > --- > > MdeModulePkg/Include/Library/LockBoxLib.h | 7 +- > > MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c | 7 +- > > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c | 5 +- > > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c | 5 +- > > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.c | 72 > ++-- > > 5 files changed, 86 insertions(+), 10 deletions(-) > > > > diff --git a/MdeModulePkg/Include/Library/LockBoxLib.h > b/MdeModulePkg/Include/Library/LockBoxLib.h > > index 5921731419..addce3bd4a 100644 > > --- a/MdeModulePkg/Include/Library/LockBoxLib.h > > +++ b/MdeModulePkg/Include/Library/LockBoxLib.h > > @@ -2,7 +2,7 @@ > >This library is only intended to be used by DXE modules that need save > >confidential information to LockBox and get it by PEI modules in S3 > > phase. > > > > -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > > +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions > > @@ -85,7 +85,10 @@ SetLockBoxAttributes ( > >@retval RETURN_SUCCESSthe information is saved successfully. > >@retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, > or Length is 0. > >@retval RETURN_NOT_FOUND the requested GUID not found. > > - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to > hold new information. > > + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, > > +the original buffer to too small to > > hold new > information. > > + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, > > +no enough resource to save the > > information. > >@retval RETURN_ACCESS_DENIED it is too late to invoke this interface > >@retval RETURN_NOT_STARTEDit is too early to invoke this > > interface > >@retval RETURN_UNSUPPORTEDthe service is not supported by > implementaion. > > diff --git a/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > b/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > > index c40dfea398..0adda1e2a9 100644 > > --- a/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > > +++ b/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > > @@ -1,6 +1,6 @@ > > /** @file > > > > -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > > +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions > > @@ -76,7 +76,10 @@ SetLockBoxAttributes ( > >@retval RETURN_SUCCESSthe information is saved successfully. > >@retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, > or Length is 0. > >@retval RETURN_NOT_FOUND the requested GUID not found. > > - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to > hold new information. > > + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, > > +the original buffer to too small to > > hold new > information. > > + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, > > +no enough reso
Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()
Hi Hao, On 02/01/19 06:47, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 > > This commit will add the support to enlarge a LockBox when using the > LockBoxLib API UpdateLockBox(). > > Please note that the new support will ONLY work for LockBox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. > > The functional uni-test for the commit is available at: > https://github.com/hwu25/edk2/tree/lockbox_unitest > > Cc: Jian J Wang > Cc: Ray Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > MdeModulePkg/Include/Library/LockBoxLib.h | 7 +- > MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c | 7 +- > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c | 5 +- > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c | 5 +- > MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.c | 72 > ++-- > 5 files changed, 86 insertions(+), 10 deletions(-) > > diff --git a/MdeModulePkg/Include/Library/LockBoxLib.h > b/MdeModulePkg/Include/Library/LockBoxLib.h > index 5921731419..addce3bd4a 100644 > --- a/MdeModulePkg/Include/Library/LockBoxLib.h > +++ b/MdeModulePkg/Include/Library/LockBoxLib.h > @@ -2,7 +2,7 @@ >This library is only intended to be used by DXE modules that need save >confidential information to LockBox and get it by PEI modules in S3 phase. > > -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > > This program and the accompanying materials > are licensed and made available under the terms and conditions > @@ -85,7 +85,10 @@ SetLockBoxAttributes ( >@retval RETURN_SUCCESSthe information is saved successfully. >@retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or > Length is 0. >@retval RETURN_NOT_FOUND the requested GUID not found. > - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold > new information. > + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, > +the original buffer to too small to hold > new information. > + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, > +no enough resource to save the > information. >@retval RETURN_ACCESS_DENIED it is too late to invoke this interface >@retval RETURN_NOT_STARTEDit is too early to invoke this interface >@retval RETURN_UNSUPPORTEDthe service is not supported by > implementaion. > diff --git a/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > b/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > index c40dfea398..0adda1e2a9 100644 > --- a/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > +++ b/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c > @@ -1,6 +1,6 @@ > /** @file > > -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. > +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > > This program and the accompanying materials > are licensed and made available under the terms and conditions > @@ -76,7 +76,10 @@ SetLockBoxAttributes ( >@retval RETURN_SUCCESSthe information is saved successfully. >@retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or > Length is 0. >@retval RETURN_NOT_FOUND the requested GUID not found. > - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold > new information. > + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, > +the original buffer to too small to hold > new information. > + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute > LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, > +no enough resource to save the > information. >@retval RETURN_ACCESS_DENIED it is too late to invoke this interface >@retval RETURN_NOT_STARTEDit is too early to invoke this interface >@retval RETURN_UNSUPPORTEDthe service is not supported by > implementaion. > diff --git a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > index 0428decbac..5ee563b71f 100644 > --- a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > +++ b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c > @@ -300,7 +300,10 @@ SetLockBoxAttributes ( >@retval RETURN_SUCCESSthe information is saved successfully. >@retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or > Length is 0. >@retval RETURN_NOT_FOUND the requested GUID not found. > - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold > new information. > + @retval RETURN
Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()
Reviewed-by: Ray Ni -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support will ONLY work for LockBox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. The functional uni-test for the commit is available at: https://github.com/hwu25/edk2/tree/lockbox_unitest Cc: Jian J Wang Cc: Ray Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- MdeModulePkg/Include/Library/LockBoxLib.h | 7 +- MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c | 7 +- MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c | 5 +- MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c | 5 +- MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.c | 72 ++-- 5 files changed, 86 insertions(+), 10 deletions(-) diff --git a/MdeModulePkg/Include/Library/LockBoxLib.h b/MdeModulePkg/Include/Library/LockBoxLib.h index 5921731419..addce3bd4a 100644 --- a/MdeModulePkg/Include/Library/LockBoxLib.h +++ b/MdeModulePkg/Include/Library/LockBoxLib.h @@ -2,7 +2,7 @@ This library is only intended to be used by DXE modules that need save confidential information to LockBox and get it by PEI modules in S3 phase. -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions @@ -85,7 +85,10 @@ SetLockBoxAttributes ( @retval RETURN_SUCCESSthe information is saved successfully. @retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or Length is 0. @retval RETURN_NOT_FOUND the requested GUID not found. - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold new information. + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, +the original buffer to too small to hold new information. + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, +no enough resource to save the information. @retval RETURN_ACCESS_DENIED it is too late to invoke this interface @retval RETURN_NOT_STARTEDit is too early to invoke this interface @retval RETURN_UNSUPPORTEDthe service is not supported by implementaion. diff --git a/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c b/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c index c40dfea398..0adda1e2a9 100644 --- a/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c +++ b/MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.c @@ -1,6 +1,6 @@ /** @file -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions @@ -76,7 +76,10 @@ SetLockBoxAttributes ( @retval RETURN_SUCCESSthe information is saved successfully. @retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or Length is 0. @retval RETURN_NOT_FOUND the requested GUID not found. - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold new information. + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, +the original buffer to too small to hold new information. + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, +no enough resource to save the information. @retval RETURN_ACCESS_DENIED it is too late to invoke this interface @retval RETURN_NOT_STARTEDit is too early to invoke this interface @retval RETURN_UNSUPPORTEDthe service is not supported by implementaion. diff --git a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c index 0428decbac..5ee563b71f 100644 --- a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c +++ b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.c @@ -300,7 +300,10 @@ SetLockBoxAttributes ( @retval RETURN_SUCCESSthe information is saved successfully. @retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or Length is 0. @retval RETURN_NOT_FOUND the requested GUID not found. - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold new information. + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, +the original buffer to too small to hold new information. + @retval RETURN_OUT_OF_RESOURCES for lockbox with att
