Re: [edk2] [PATCH v3 edk2-platforms 0/6] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms
So, I'm actually mostly happy with this set, but this cover letter is incorrect. On Wed, Nov 21, 2018 at 06:14:51PM +0530, Chandni Cherukuri wrote: > Changes since v1: > - No code changes, posting this series again with correct patch subject Plenty of code changes. Stopped the masking and shifting of platform/config IDs. > This patch series adds support for two new Arm's SGI platforms - > SGI-Clark.Ares and SGI-Clark.Helios. The first patch in this > series adds support to use a new binding added to the system-id > node for Platform Identification. The second patch refactors the > ACPI tables to prevent duplication of ACPI tables. The common > ACPI tables for SGI platforms are put in the AcpiTables folder. > Dsdt.asl and Madt.aslc remain in the platform specific folder. > The rest of the patches add support for the two new SGI platforms. I am not super happy that the Change from COM1 -> \\_SB.COM0 got folded into Patch number 2, but I'm not going to ask for a v4 over it. For the series: Reviewed-by: Leif Lindholm Pushed as 86c75fc51f..77ae8610df. > Chandni Cherukuri (6): > Platform/ARM/Sgi: Adapt to changes in system-id DT node. > Platform/ARM/Sgi: Refactor ACPI tables for SGI platforms > Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform > Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform > Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform > Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform > > Platform/ARM/SgiPkg/SgiPlatform.dec | 2 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf | 58 - > Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 58 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf| 58 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 58 + > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 2 +- > Platform/ARM/SgiPkg/Include/SgiPlatform.h| 6 + > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c| 33 +-- > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 50 ++-- > Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc | 88 +++ > Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc | 87 +++ > Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc | 152 > +++ > Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 106 > Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc | 59 + > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc | 90 --- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 2 +- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Fadt.aslc | 87 --- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Gtdt.aslc | 152 > --- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Iort.aslc | 106 > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Mcfg.aslc | 59 - > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Spcr.aslc | 77 -- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Ssdt.asl | 95 --- > Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 116 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc| 171 > + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl | 262 > +++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc | 266 > > Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc | 77 ++ > Platform/ARM/SgiPkg/AcpiTables/Ssdt.asl | 93 +++ > 31 files changed, 1722 insertions(+), 758 deletions(-) > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf > create mode 100644 > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Fadt.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Gtdt.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Iort.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Mcfg.aslc > delete mode 100644
[edk2] [PATCH v3 edk2-platforms 0/6] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms
Changes since v1: - No code changes, posting this series again with correct patch subject This patch series adds support for two new Arm's SGI platforms - SGI-Clark.Ares and SGI-Clark.Helios. The first patch in this series adds support to use a new binding added to the system-id node for Platform Identification. The second patch refactors the ACPI tables to prevent duplication of ACPI tables. The common ACPI tables for SGI platforms are put in the AcpiTables folder. Dsdt.asl and Madt.aslc remain in the platform specific folder. The rest of the patches add support for the two new SGI platforms. Chandni Cherukuri (6): Platform/ARM/Sgi: Adapt to changes in system-id DT node. Platform/ARM/Sgi: Refactor ACPI tables for SGI platforms Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform Platform/ARM/SgiPkg/SgiPlatform.dec | 2 + Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +- Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +- Platform/ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf | 58 - Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 58 + Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf| 58 + Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 58 + Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 2 +- Platform/ARM/SgiPkg/Include/SgiPlatform.h| 6 + Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c| 33 +-- Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 50 ++-- Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc | 88 +++ Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc | 87 +++ Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc | 152 +++ Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 106 Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc | 59 + Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc | 90 --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 2 +- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Fadt.aslc | 87 --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Gtdt.aslc | 152 --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Iort.aslc | 106 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Mcfg.aslc | 59 - Platform/ARM/SgiPkg/AcpiTables/Sgi575/Spcr.aslc | 77 -- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Ssdt.asl | 95 --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 116 + Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc| 171 + Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl | 262 +++ Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc | 266 Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc | 77 ++ Platform/ARM/SgiPkg/AcpiTables/Ssdt.asl | 93 +++ 31 files changed, 1722 insertions(+), 758 deletions(-) delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Fadt.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Gtdt.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Iort.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Mcfg.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Spcr.aslc delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Ssdt.asl create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Ssdt.asl -- 2.7.4 ___ edk2-devel mailing list
