Re: [edk2] [PATCH v7 0/4] enhance MMC

2016-11-23 Thread Ard Biesheuvel 
On 23 November 2016 at 07:08, Haojian Zhuang  wrote:
> v7:
>   * Add revision checking.
>

Thanks for the hard work and the quick turnaround, but I'm afraid
we're not quite there yet.

Please find my comments in response to the individual patches

> v6:
>   * Reformat the last 5 patches after 4 MMC patches of this series merged.
>   * Squash original #5 and #6 patches together.
>   * Fix according comments.
>
> v5:
>   * Remove patch on MediaId.
>   * Squash two PL180 patches together.
>
> v4:
>   * Fix PL180 hang in some cases. Since the proper variable length
> isn't set for CMD6 & ACMD51.
>
> v3:
>   * Fix PL180 hang because of CMD6 & ACMD51 not supported.
>
> v2:
>   * Fix print error with missing parameter.
>   * Change CMD51 to ACMD51.
>   * Add the protection after CMD55 for SD. If there's no
> response of CMD55, skip to send ACMD51.
>
> v1:
>   * Wait OCR busy bit free according to eMMC spec.
>   * Define ECSD structure.
>   * Add interface to set IO bus width and speed.
>   * Support to access multiple blocks.
>
> Haojian Zhuang (4):
>   MmcDxe: add interface to change io width and speed
>   MmcDxe: set iospeed and bus width in SD stack
>   PL180: update for indentifying SD
>   MmcDxe: expand to support multiple blocks
>
>  ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c|  29 ++-
>  EmbeddedPkg/Include/Protocol/MmcHost.h   |  36 ++-
>  EmbeddedPkg/Universal/MmcDxe/Mmc.h   |  25 ++
>  EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c| 176 +-
>  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291 
> ++-
>  5 files changed, 487 insertions(+), 70 deletions(-)
>
> --
> 2.7.4
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v7 0/4] enhance MMC

2016-11-22 Thread Haojian Zhuang 
v7:
  * Add revision checking.

v6:
  * Reformat the last 5 patches after 4 MMC patches of this series merged.
  * Squash original #5 and #6 patches together.
  * Fix according comments.

v5:
  * Remove patch on MediaId.
  * Squash two PL180 patches together.

v4:
  * Fix PL180 hang in some cases. Since the proper variable length
isn't set for CMD6 & ACMD51.

v3:
  * Fix PL180 hang because of CMD6 & ACMD51 not supported.

v2:
  * Fix print error with missing parameter.
  * Change CMD51 to ACMD51.
  * Add the protection after CMD55 for SD. If there's no
response of CMD55, skip to send ACMD51.

v1:
  * Wait OCR busy bit free according to eMMC spec.
  * Define ECSD structure.
  * Add interface to set IO bus width and speed.
  * Support to access multiple blocks.

Haojian Zhuang (4):
  MmcDxe: add interface to change io width and speed
  MmcDxe: set iospeed and bus width in SD stack
  PL180: update for indentifying SD
  MmcDxe: expand to support multiple blocks

 ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c|  29 ++-
 EmbeddedPkg/Include/Protocol/MmcHost.h   |  36 ++-
 EmbeddedPkg/Universal/MmcDxe/Mmc.h   |  25 ++
 EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c| 176 +-
 EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291 ++-
 5 files changed, 487 insertions(+), 70 deletions(-)

-- 
2.7.4

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel