Re: [edk2] [Patch] BaseTools: Fixed a key error code bug.
Cool. -Original Message- From: Zhu, Yonghong Sent: Sunday, October 21, 2018 7:50 PM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: RE: [edk2] [Patch] BaseTools: Fixed a key error code bug. Hi Bob, I fixed this issue by below patch, I will check in the patch soon. https://lists.01.org/pipermail/edk2-devel/2018-October/031161.html Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF Sent: Sunday, October 21, 2018 7:42 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Fixed a key error code bug. There is a code bug that used a wrong key. This Patch is to correct it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index f2146a7790..87d6107035 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -567,12 +567,12 @@ class WorkspaceAutoGen(AutoGen): if (Name, Guid) not in DecPcds: EdkLogger.error( 'build', PARSER_ERROR, "PCD (%s.%s) used in FDF is not declared in DEC files." % (Guid, Name), -File = self.FdfProfile.PcdFileLineDict[Name, Guid][0], -Line = self.FdfProfile.PcdFileLineDict[Name, Guid][1] +File = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][0], +Line = self.FdfProfile.PcdFileLineDict[Name, + Guid,Fileds][1] ) else: # Check whether Dynamic or DynamicEx PCD used in FDF file. If used, build break and give a error message. if (Name, Guid, TAB_PCDS_FIXED_AT_BUILD) in DecPcdsKey \ or (Name, Guid, TAB_PCDS_PATCHABLE_IN_MODULE) in DecPcdsKey \ @@ -581,12 +581,12 @@ class WorkspaceAutoGen(AutoGen): elif (Name, Guid, TAB_PCDS_DYNAMIC) in DecPcdsKey or (Name, Guid, TAB_PCDS_DYNAMIC_EX) in DecPcdsKey: EdkLogger.error( 'build', PARSER_ERROR, "Using Dynamic or DynamicEx type of PCD [%s.%s] in FDF file is not allowed." % (Guid, Name), -File = self.FdfProfile.PcdFileLineDict[Name, Guid][0], -Line = self.FdfProfile.PcdFileLineDict[Name, Guid][1] +File = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][0], +Line = + self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][1] ) Pa = PlatformAutoGen(self, self.MetaFile, Target, Toolchain, Arch) # # Explicitly collect platform's dynamic PCDs -- 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] BaseTools: Fixed a key error code bug.
Hi Bob, I fixed this issue by below patch, I will check in the patch soon. https://lists.01.org/pipermail/edk2-devel/2018-October/031161.html Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF Sent: Sunday, October 21, 2018 7:42 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Fixed a key error code bug. There is a code bug that used a wrong key. This Patch is to correct it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index f2146a7790..87d6107035 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -567,12 +567,12 @@ class WorkspaceAutoGen(AutoGen): if (Name, Guid) not in DecPcds: EdkLogger.error( 'build', PARSER_ERROR, "PCD (%s.%s) used in FDF is not declared in DEC files." % (Guid, Name), -File = self.FdfProfile.PcdFileLineDict[Name, Guid][0], -Line = self.FdfProfile.PcdFileLineDict[Name, Guid][1] +File = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][0], +Line = self.FdfProfile.PcdFileLineDict[Name, + Guid,Fileds][1] ) else: # Check whether Dynamic or DynamicEx PCD used in FDF file. If used, build break and give a error message. if (Name, Guid, TAB_PCDS_FIXED_AT_BUILD) in DecPcdsKey \ or (Name, Guid, TAB_PCDS_PATCHABLE_IN_MODULE) in DecPcdsKey \ @@ -581,12 +581,12 @@ class WorkspaceAutoGen(AutoGen): elif (Name, Guid, TAB_PCDS_DYNAMIC) in DecPcdsKey or (Name, Guid, TAB_PCDS_DYNAMIC_EX) in DecPcdsKey: EdkLogger.error( 'build', PARSER_ERROR, "Using Dynamic or DynamicEx type of PCD [%s.%s] in FDF file is not allowed." % (Guid, Name), -File = self.FdfProfile.PcdFileLineDict[Name, Guid][0], -Line = self.FdfProfile.PcdFileLineDict[Name, Guid][1] +File = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][0], +Line = + self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][1] ) Pa = PlatformAutoGen(self, self.MetaFile, Target, Toolchain, Arch) # # Explicitly collect platform's dynamic PCDs -- 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] BaseTools: Fixed a key error code bug.
There is a code bug that used a wrong key. This Patch is to correct it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index f2146a7790..87d6107035 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -567,12 +567,12 @@ class WorkspaceAutoGen(AutoGen): if (Name, Guid) not in DecPcds: EdkLogger.error( 'build', PARSER_ERROR, "PCD (%s.%s) used in FDF is not declared in DEC files." % (Guid, Name), -File = self.FdfProfile.PcdFileLineDict[Name, Guid][0], -Line = self.FdfProfile.PcdFileLineDict[Name, Guid][1] +File = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][0], +Line = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][1] ) else: # Check whether Dynamic or DynamicEx PCD used in FDF file. If used, build break and give a error message. if (Name, Guid, TAB_PCDS_FIXED_AT_BUILD) in DecPcdsKey \ or (Name, Guid, TAB_PCDS_PATCHABLE_IN_MODULE) in DecPcdsKey \ @@ -581,12 +581,12 @@ class WorkspaceAutoGen(AutoGen): elif (Name, Guid, TAB_PCDS_DYNAMIC) in DecPcdsKey or (Name, Guid, TAB_PCDS_DYNAMIC_EX) in DecPcdsKey: EdkLogger.error( 'build', PARSER_ERROR, "Using Dynamic or DynamicEx type of PCD [%s.%s] in FDF file is not allowed." % (Guid, Name), -File = self.FdfProfile.PcdFileLineDict[Name, Guid][0], -Line = self.FdfProfile.PcdFileLineDict[Name, Guid][1] +File = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][0], +Line = self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][1] ) Pa = PlatformAutoGen(self, self.MetaFile, Target, Toolchain, Arch) # # Explicitly collect platform's dynamic PCDs -- 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
