Re: [edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF > Sent: Thursday, October 18, 2018 1:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options for > PcdValueInit tool. > > PcdValueInit tool is Arch independent, the Arch specific > build options should be removed from PcdValueInit makefile. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob C Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py > b/BaseTools/Source/Python/Workspace/DscBuildData.py > index 19ac71ac09..47f5033953 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject): > if Tool != 'CC': > continue > > if Target == "*" or Target == self._Target: > if Tag == "*" or Tag == self._Toolchain: > -if Arch == "*" or Arch == self.Arch: > +if Arch == "*": > if Tool not in BuildOptions: > BuildOptions[Tool] = OrderedDict() > if Attr != "FLAGS" or Attr not in BuildOptions[Tool] > or self.BuildOptions[Options].startswith('='): > BuildOptions[Tool][Attr] = > self.BuildOptions[Options] > else: > -- > 2.18.0.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > BobCF > Sent: Wednesday, October 17, 2018 10:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Remove Arch specific build options for > PcdValueInit tool. > > PcdValueInit tool is Arch independent, the Arch specific > build options should be removed from PcdValueInit makefile. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob C Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py > b/BaseTools/Source/Python/Workspace/DscBuildData.py > index 19ac71ac09..47f5033953 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject): > if Tool != 'CC': > continue > > if Target == "*" or Target == self._Target: > if Tag == "*" or Tag == self._Toolchain: > -if Arch == "*" or Arch == self.Arch: > +if Arch == "*": > if Tool not in BuildOptions: > BuildOptions[Tool] = OrderedDict() > if Attr != "FLAGS" or Attr not in BuildOptions[Tool] > or > self.BuildOptions[Options].startswith('='): > BuildOptions[Tool][Attr] = > self.BuildOptions[Options] > else: > -- > 2.18.0.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] BaseTools: Remove Arch specific build options for PcdValueInit tool.
PcdValueInit tool is Arch independent, the Arch specific build options should be removed from PcdValueInit makefile. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob C Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index 19ac71ac09..47f5033953 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -2344,11 +2344,11 @@ class DscBuildData(PlatformBuildClassObject): if Tool != 'CC': continue if Target == "*" or Target == self._Target: if Tag == "*" or Tag == self._Toolchain: -if Arch == "*" or Arch == self.Arch: +if Arch == "*": if Tool not in BuildOptions: BuildOptions[Tool] = OrderedDict() if Attr != "FLAGS" or Attr not in BuildOptions[Tool] or self.BuildOptions[Options].startswith('='): BuildOptions[Tool][Attr] = self.BuildOptions[Options] else: -- 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel