Re: [edk2] [Patch] BaseTools: ignore the binary LIB file in gen_libs

2016-06-14 Thread Gao, Liming
Reviewed-by: Liming Gao 

-Original Message-
From: Zhu, Yonghong 
Sent: Monday, June 13, 2016 6:08 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming 
Subject: [Patch] BaseTools: ignore the binary LIB file in gen_libs

For single module build, it would call gen_libs target. then if it use
binary LIB file, it cause build failure.

Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu 
---
 BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py 
b/BaseTools/Source/Python/AutoGen/GenMake.py
index be07e46..c8c5fc5 100644
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -865,11 +865,12 @@ cleanlib:
 
self.BuildTargetList.append(self._BUILD_TARGET_TEMPLATE.Replace(TargetDict))
 
 ## For creating makefile targets for dependent libraries
 def ProcessDependentLibrary(self):
 for LibraryAutoGen in self._AutoGenObject.LibraryAutoGenList:
-
self.LibraryBuildDirectoryList.append(self.PlaceMacro(LibraryAutoGen.BuildDir, 
self.Macros))
+if not LibraryAutoGen.IsBinaryModule:
+
self.LibraryBuildDirectoryList.append(self.PlaceMacro(LibraryAutoGen.BuildDir, 
self.Macros))
 
 ## Return a list containing source file's dependencies
 #
 #   @param  FileListThe list of source files
 #   @param  ForceInculeList The list of files which will be included 
forcely
-- 
2.6.1.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [Patch] BaseTools: ignore the binary LIB file in gen_libs

2016-06-13 Thread Yonghong Zhu
For single module build, it would call gen_libs target. then if it use
binary LIB file, it cause build failure.

Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu 
---
 BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py 
b/BaseTools/Source/Python/AutoGen/GenMake.py
index be07e46..c8c5fc5 100644
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -865,11 +865,12 @@ cleanlib:
 
self.BuildTargetList.append(self._BUILD_TARGET_TEMPLATE.Replace(TargetDict))
 
 ## For creating makefile targets for dependent libraries
 def ProcessDependentLibrary(self):
 for LibraryAutoGen in self._AutoGenObject.LibraryAutoGenList:
-
self.LibraryBuildDirectoryList.append(self.PlaceMacro(LibraryAutoGen.BuildDir, 
self.Macros))
+if not LibraryAutoGen.IsBinaryModule:
+
self.LibraryBuildDirectoryList.append(self.PlaceMacro(LibraryAutoGen.BuildDir, 
self.Macros))
 
 ## Return a list containing source file's dependencies
 #
 #   @param  FileListThe list of source files
 #   @param  ForceInculeList The list of files which will be included 
forcely
-- 
2.6.1.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel