Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
Liming, I saw MdeModulePkg only builds MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf at EBC arch. You mean even the *unused* library INF files will be considered? Why? Sorry I am still confused. Thanks, Star -Original Message- From: Gao, Liming Sent: Friday, October 26, 2018 11:43 AM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch Star: Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect PCD information from all INF files list in DSC/FDF. But before, only the used library INF files are considered. This change is to decide which PCD is really used, then generate the structure PCD value in the early phase. With this change, SmmLockBoxPeiLib library instance can't be used for EBC arch. This patch fixes it. Thanks Liming > -Original Message- > From: Zeng, Star > Sent: Friday, October 26, 2018 11:29 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib > library instance for IA32/X64 arch > > On 2018/10/26 9:57, Liming Gao wrote: > > SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this > > PCD is defined in MdeModulePkg.dec for IA32 and X64 only. > > Could we explain more in the commit log about why this change is not > needed before but required now? > > Thanks, > Star > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao > > Cc: Star Zeng > > --- > > MdeModulePkg/MdeModulePkg.dsc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc index 2465d39..e88516d 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -120,6 +120,8 @@ > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/Pe > > iExtractGuidedSectionLib.inf > > + > > +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] > > > > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf > > > > [LibraryClasses.common.DXE_CORE] > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
Star: Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect PCD information from all INF files list in DSC/FDF. But before, only the used library INF files are considered. This change is to decide which PCD is really used, then generate the structure PCD value in the early phase. With this change, SmmLockBoxPeiLib library instance can't be used for EBC arch. This patch fixes it. Thanks Liming > -Original Message- > From: Zeng, Star > Sent: Friday, October 26, 2018 11:29 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library > instance for IA32/X64 arch > > On 2018/10/26 9:57, Liming Gao wrote: > > SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is > > defined in MdeModulePkg.dec for IA32 and X64 only. > > Could we explain more in the commit log about why this change is not > needed before but required now? > > Thanks, > Star > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao > > Cc: Star Zeng > > --- > > MdeModulePkg/MdeModulePkg.dsc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > > index 2465d39..e88516d 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -120,6 +120,8 @@ > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > > + > > +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] > > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf > > > > [LibraryClasses.common.DXE_CORE] > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
On 2018/10/26 9:57, Liming Gao wrote: SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is defined in MdeModulePkg.dec for IA32 and X64 only. Could we explain more in the commit log about why this change is not needed before but required now? Thanks, Star Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 2465d39..e88516d 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -120,6 +120,8 @@ HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf + +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf [LibraryClasses.common.DXE_CORE] ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is defined in MdeModulePkg.dec for IA32 and X64 only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 2465d39..e88516d 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -120,6 +120,8 @@ HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf + +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf [LibraryClasses.common.DXE_CORE] -- 2.10.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
