Re: [edk2] [Patch V2 2/3] Vlv2TbltDevicePkg: Fix build failure issue after ECP cleanup

2019-03-19 Thread Qian, Yi
Reviewed by Qian, Yi 

Thanks
Qian Yi

> -Original Message-
> From: Sun, Zailiang
> Sent: Tuesday, March 19, 2019 4:36 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David ; Qian, Yi 
> Subject: [Patch V2 2/3] Vlv2TbltDevicePkg: Fix build failure issue after ECP
> cleanup
> 
> In V2: no new changes
> 
> Moved stuff in the three old packages IA32FamilyCpuPkg, Vlv2BinaryPkg and
> Vlv2MiscBinariesPkg into a new package Vlv2SocBinPkg. Updated the build
> scripts
> and added build instructions in Readme.md.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: David Wei 
> Cc: Zailiang Sun 
> Cc: Yi Qian 
> ---
>  Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf | 177
> ++
> ++--
> ---
>  Vlv2TbltDevicePkg/Build_IFWI.bat|  35 
> -
> --
>  Vlv2TbltDevicePkg/Library/MultiPlatformLib/MultiPlatformLib.inf | 166
> ++
> +--
> -
>  Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.inf | 156
> ++
> --
> 
>  Vlv2TbltDevicePkg/PlatformCpuInfoDxe/PlatformCpuInfoDxe.inf | 122
> ++
> +++-
>  Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf   | 246
> ++
> ++
> +++--
> -
>  Vlv2TbltDevicePkg/PlatformPei/PlatformPei.inf   | 270
> ++
> ++
> +++---
> 
>  Vlv2TbltDevicePkg/PlatformPkg.fdf   |   8 
> 
>  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc   |   4 ++--
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc|   4 ++--
>  Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.inf   |   2 +-
>  Vlv2TbltDevicePkg/Readme.md |  75
> ++
> +
>  Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat |   4 ++--
>  Vlv2TbltDevicePkg/bld_vlv.bat   | 110
> +--
> ---
>  14 files changed, 727 insertions(+), 652 deletions(-)
> 
> diff --git
> a/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
> b/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
> index 4e2ec32ac6..8ca7a663cd 100644
> --- a/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
> +++ b/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
> @@ -1,90 +1,89 @@
> -## @file
> -# Implements a Tunnel Mountain specific flash update program.  This will
> allow
> -# users to update all regions of the flash as needed in a given update.
> -#
> -# Copyright (c) 2006  - 2014, Intel Corporation. All rights reserved.
> -#
> 
> -# This program and the accompanying materials are licensed and made
> available under
> 
> -# the terms and conditions of the BSD License that accompanies this
> distribution.
> 
> -# The full text of the license may be found at
> 
> -# http://opensource.org/licenses/bsd-license.php.
> 
> -#
> 
> -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> 
> -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> 
> -#
> 
> -#
> -#
> -##
> -
> -[Defines]
> -  INF_VERSION= 0x00010005
> -  BASE_NAME  = FirmwareUpdate
> -  FILE_GUID  = AEFAF26C-FB6D-4fef-AF7A-9D78FF201FCA
> -  MODULE_TYPE= UEFI_APPLICATION
> -  VERSION_STRING = 1.0
> -  ENTRY_POINT= ShellCEntryLib
> -
> -#
> -# The following information is for reference only and not required by the
> build tools.
> -#
> -#  VALID_ARCHITECTURES   = X64
> -#
> -
> -[Sources]
> -  FirmwareUpdateStrings.uni
> -  FirmwareUpdate.c
> -  FirmwareUpdate.h
> -
> -[Packages]
> -  MdeModulePkg/MdeModulePkg.dec
> -  MdePkg/MdePkg.dec
> -  IA32FamilyCpuPkg/IA32FamilyCpuPkg.dec
> - 

[edk2] [Patch V2 2/3] Vlv2TbltDevicePkg: Fix build failure issue after ECP cleanup

2019-03-19 Thread Zailiang Sun
In V2: no new changes

Moved stuff in the three old packages IA32FamilyCpuPkg, Vlv2BinaryPkg and
Vlv2MiscBinariesPkg into a new package Vlv2SocBinPkg. Updated the build scripts
and added build instructions in Readme.md.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei 
Cc: Zailiang Sun 
Cc: Yi Qian 
---
 Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf | 177 
-
 Vlv2TbltDevicePkg/Build_IFWI.bat|  35 
---
 Vlv2TbltDevicePkg/Library/MultiPlatformLib/MultiPlatformLib.inf | 166 
+++---
 Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.inf | 156 
++--
 Vlv2TbltDevicePkg/PlatformCpuInfoDxe/PlatformCpuInfoDxe.inf | 122 
+-
 Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf   | 246 
+++---
 Vlv2TbltDevicePkg/PlatformPei/PlatformPei.inf   | 270 
+++---
 Vlv2TbltDevicePkg/PlatformPkg.fdf   |   8 
 Vlv2TbltDevicePkg/PlatformPkgIA32.dsc   |   4 ++--
 Vlv2TbltDevicePkg/PlatformPkgX64.dsc|   4 ++--
 Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.inf   |   2 +-
 Vlv2TbltDevicePkg/Readme.md |  75 
+++
 Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat |   4 ++--
 Vlv2TbltDevicePkg/bld_vlv.bat   | 110 
+-
 14 files changed, 727 insertions(+), 652 deletions(-)

diff --git a/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf 
b/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
index 4e2ec32ac6..8ca7a663cd 100644
--- a/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
+++ b/Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.inf
@@ -1,90 +1,89 @@
-## @file
-# Implements a Tunnel Mountain specific flash update program.  This will allow
-# users to update all regions of the flash as needed in a given update.
-#
-# Copyright (c) 2006  - 2014, Intel Corporation. All rights reserved.
-#  


-# This program and the accompanying materials are licensed and made available 
under

-# the terms and conditions of the BSD License that accompanies this 
distribution.  

-# The full text of the license may be found at 


-# http://opensource.org/licenses/bsd-license.php.  


-#  


-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,


-# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.

-#  


-#
-#
-##
-
-[Defines]
-  INF_VERSION= 0x00010005
-  BASE_NAME  = FirmwareUpdate
-  FILE_GUID  = AEFAF26C-FB6D-4fef-AF7A-9D78FF201FCA
-  MODULE_TYPE= UEFI_APPLICATION
-  VERSION_STRING = 1.0
-  ENTRY_POINT= ShellCEntryLib
-
-#
-# The following information is for reference only and not required by the 
build tools.
-#
-#  VALID_ARCHITECTURES   = X64
-#
-
-[Sources]
-  FirmwareUpdateStrings.uni
-  FirmwareUpdate.c
-  FirmwareUpdate.h
-
-[Packages]
-  MdeModulePkg/MdeModulePkg.dec
-  MdePkg/MdePkg.dec
-  IA32FamilyCpuPkg/IA32FamilyCpuPkg.dec
-  Vlv2TbltDevicePkg/PlatformPkg.dec
-  Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
-  ShellPkg/ShellPkg.dec
-
-[LibraryClasses]
-  BaseLib
-  BaseMemoryLib
-  CacheMaintenanceLib