Re: [edk2] [Patch v2 1/1] AppPkg/Python remove improper characters from pyconfig.h
Reviewed-by: Erik Bjorge -Original Message- From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] Sent: Tuesday, November 3, 2015 10:37 AM To: edk2-devel@lists.01.org; Carsey, Jaben ; Bjorge, Erik C ; Rosenbaum, Lee G Subject: [Patch v2 1/1] AppPkg/Python remove improper characters from pyconfig.h AppPkg: Within the Ia32 and X64 pyconfig.h files, there are 178 occurrences of an accent character, `, being used instead of a regular single quote, ', within comments. Replace all occurrences of ` within comments with '. Example: OLD: `foobar' NEW: 'foobar' The same changes are applied to both AppPkg/Applications/Python/Ia32/pyconfig.h and AppPkg/Applications/Python/X64/pyconfig.h. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daryl McDaniel *** a/AppPkg/Applications/Python/X64/pyconfig.h-revBASE.svn001.tmp.hFri Mar 23 17:19:06 2012 --- b/AppPkg/Applications/Python/X64/pyconfig.h Tue Oct 20 12:43:43 2015 *** *** 58,88 the case on Motorola V4 (R40V4.2) */ #undef GETTIMEOFDAY_NO_TZ ! /* Define to 1 if you have the `acosh' function. */ #undef HAVE_ACOSH /* struct addrinfo (netdb.h) */ #undef HAVE_ADDRINFO ! /* Define to 1 if you have the `alarm' function. */ #undef HAVE_ALARM /* Define this if your time.h defines altzone. */ #undef HAVE_ALTZONE ! /* Define to 1 if you have the `asinh' function. */ #undef HAVE_ASINH /* Define to 1 if you have the header file. */ #undef HAVE_ASM_TYPES_H ! /* Define to 1 if you have the `atanh' function. */ #undef HAVE_ATANH /* Define if GCC supports __attribute__((format(PyArg_ParseTuple, 2, 3))) */ #undef HAVE_ATTRIBUTE_FORMAT_PARSETUPLE ! /* Define to 1 if you have the `bind_textdomain_codeset' function. */ #undef HAVE_BIND_TEXTDOMAIN_CODESET /* Define to 1 if you have the header file. */ --- 58,88 the case on Motorola V4 (R40V4.2) */ #undef GETTIMEOFDAY_NO_TZ ! /* Define to 1 if you have the 'acosh' function. */ #undef HAVE_ACOSH /* struct addrinfo (netdb.h) */ #undef HAVE_ADDRINFO ! /* Define to 1 if you have the 'alarm' function. */ #undef HAVE_ALARM /* Define this if your time.h defines altzone. */ #undef HAVE_ALTZONE ! /* Define to 1 if you have the 'asinh' function. */ #undef HAVE_ASINH /* Define to 1 if you have the header file. */ #undef HAVE_ASM_TYPES_H ! /* Define to 1 if you have the 'atanh' function. */ #undef HAVE_ATANH /* Define if GCC supports __attribute__((format(PyArg_ParseTuple, 2, 3))) */ #undef HAVE_ATTRIBUTE_FORMAT_PARSETUPLE ! /* Define to 1 if you have the 'bind_textdomain_codeset' function. */ #undef HAVE_BIND_TEXTDOMAIN_CODESET /* Define to 1 if you have the header file. */ *** *** 112,139 /* Define this if you have the type _Bool. */ #define HAVE_C99_BOOL 1 ! /* Define to 1 if you have the `chflags' function. */ #undef HAVE_CHFLAGS ! /* Define to 1 if you have the `chown' function. */ #undef HAVE_CHOWN /* Define if you have the 'chroot' function. */ #undef HAVE_CHROOT ! /* Define to 1 if you have the `clock' function. */ #define HAVE_CLOCK1 ! /* Define to 1 if you have the `confstr' function. */ #undef HAVE_CONFSTR /* Define to 1 if you have the header file. */ #undef HAVE_CONIO_H ! /* Define to 1 if you have the `copysign' function. */ #undef HAVE_COPYSIGN ! /* Define to 1 if you have the `ctermid' function. */ #undef HAVE_CTERMID /* Define if you have the 'ctermid_r' function. */ --- 112,139 /* Define this if you have the type _Bool. */ #define HAVE_C99_BOOL 1 ! /* Define to 1 if you have the 'chflags' function. */ #undef HAVE_CHFLAGS ! /* Define to 1 if you have the 'chown' function. */ #undef HAVE_CHOWN /* Define if you have the 'chroot' function. */ #undef HAVE_CHROOT ! /* Define to 1 if you have the 'clock' function. */ #define HAVE_CLOCK1 ! /* Define to 1 if you have the 'confstr' function. */ #undef HAVE_CONFSTR /* Define to 1 if you have the header file. */ #undef HAVE_CONIO_H ! /* Define to 1 if you have the 'copysign' function. */ #undef HAVE_COPYSIGN ! /* Define to 1 if you have the 'ctermid' function. */ #undef HAVE_CTERMID /* Define if you have the 'ctermid_r' function. */ *** *** 151,169 /* Define if you have the 'resize_term' function. */ #undef HAVE_CURSES_RESIZE_TERM ! /* Define to 1 if you have the declaration of `isfinite', and to 0 if you don't. */ #define HAVE_DECL_ISFINITE0 ! /* Define to 1 if you have the declaration of `isinf', and to 0 if you don't. */ #define HAVE_DECL_ISINF 1 ! /* Define to 1 if you have the declaration of `isnan', and to 0 if you don't. */ #define HAVE_DECL_ISNAN 1 ! /* Define to 1 if you have the declaration of `tzname', and to
Re: [edk2] [Patch v2 1/1] AppPkg/Python remove improper characters from pyconfig.h
Reviewed-by: Jaben Carsey > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Tuesday, November 03, 2015 10:37 AM > To: edk2-devel@lists.01.org; Carsey, Jaben ; > Bjorge, Erik C ; Rosenbaum, Lee G > > Subject: [Patch v2 1/1] AppPkg/Python remove improper characters from > pyconfig.h > Importance: High > > AppPkg: Within the Ia32 and X64 pyconfig.h files, there are 178 occurrences > of an accent character, `, being used instead of a regular single quote, ', > within comments. > > Replace all occurrences of ` within comments with '. Example: > OLD: `foobar' > NEW: 'foobar' > > The same changes are applied to both > AppPkg/Applications/Python/Ia32/pyconfig.h and > AppPkg/Applications/Python/X64/pyconfig.h. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Daryl McDaniel > > > *** a/AppPkg/Applications/Python/X64/pyconfig.h-revBASE.svn001.tmp.h > Fri > Mar 23 17:19:06 2012 > --- b/AppPkg/Applications/Python/X64/pyconfig.h Tue Oct 20 12:43:43 > 2015 > *** > *** 58,88 > the case on Motorola V4 (R40V4.2) */ > #undef GETTIMEOFDAY_NO_TZ > > ! /* Define to 1 if you have the `acosh' function. */ > #undef HAVE_ACOSH > > /* struct addrinfo (netdb.h) */ > #undef HAVE_ADDRINFO > > ! /* Define to 1 if you have the `alarm' function. */ > #undef HAVE_ALARM > > /* Define this if your time.h defines altzone. */ > #undef HAVE_ALTZONE > > ! /* Define to 1 if you have the `asinh' function. */ > #undef HAVE_ASINH > > /* Define to 1 if you have the header file. */ > #undef HAVE_ASM_TYPES_H > > ! /* Define to 1 if you have the `atanh' function. */ > #undef HAVE_ATANH > > /* Define if GCC supports __attribute__((format(PyArg_ParseTuple, 2, 3))) > */ > #undef HAVE_ATTRIBUTE_FORMAT_PARSETUPLE > > ! /* Define to 1 if you have the `bind_textdomain_codeset' function. */ > #undef HAVE_BIND_TEXTDOMAIN_CODESET > > /* Define to 1 if you have the header file. */ > --- 58,88 > the case on Motorola V4 (R40V4.2) */ > #undef GETTIMEOFDAY_NO_TZ > > ! /* Define to 1 if you have the 'acosh' function. */ > #undef HAVE_ACOSH > > /* struct addrinfo (netdb.h) */ > #undef HAVE_ADDRINFO > > ! /* Define to 1 if you have the 'alarm' function. */ > #undef HAVE_ALARM > > /* Define this if your time.h defines altzone. */ > #undef HAVE_ALTZONE > > ! /* Define to 1 if you have the 'asinh' function. */ > #undef HAVE_ASINH > > /* Define to 1 if you have the header file. */ > #undef HAVE_ASM_TYPES_H > > ! /* Define to 1 if you have the 'atanh' function. */ > #undef HAVE_ATANH > > /* Define if GCC supports __attribute__((format(PyArg_ParseTuple, 2, 3))) > */ > #undef HAVE_ATTRIBUTE_FORMAT_PARSETUPLE > > ! /* Define to 1 if you have the 'bind_textdomain_codeset' function. */ > #undef HAVE_BIND_TEXTDOMAIN_CODESET > > /* Define to 1 if you have the header file. */ > *** > *** 112,139 > /* Define this if you have the type _Bool. */ > #define HAVE_C99_BOOL 1 > > ! /* Define to 1 if you have the `chflags' function. */ > #undef HAVE_CHFLAGS > > ! /* Define to 1 if you have the `chown' function. */ > #undef HAVE_CHOWN > > /* Define if you have the 'chroot' function. */ > #undef HAVE_CHROOT > > ! /* Define to 1 if you have the `clock' function. */ > #define HAVE_CLOCK1 > > ! /* Define to 1 if you have the `confstr' function. */ > #undef HAVE_CONFSTR > > /* Define to 1 if you have the header file. */ > #undef HAVE_CONIO_H > > ! /* Define to 1 if you have the `copysign' function. */ > #undef HAVE_COPYSIGN > > ! /* Define to 1 if you have the `ctermid' function. */ > #undef HAVE_CTERMID > > /* Define if you have the 'ctermid_r' function. */ > --- 112,139 > /* Define this if you have the type _Bool. */ > #define HAVE_C99_BOOL 1 > > ! /* Define to 1 if you have the 'chflags' function. */ > #undef HAVE_CHFLAGS > > ! /* Define to 1 if you have the 'chown' function. */ > #undef HAVE_CHOWN > > /* Define if you have the 'chroot' function. */ > #undef HAVE_CHROOT > > ! /* Define to 1 if you have the 'clock' function. */ > #define HAVE_CLOCK1 > > ! /* Define to 1 if you have the 'confstr' function. */ > #undef HAVE_CONFSTR > > /* Define to 1 if you have the header file. */ > #undef HAVE_CONIO_H > > ! /* Define to 1 if you have the 'copysign' function. */ > #undef HAVE_COPYSIGN > > ! /* Define to 1 if you have the 'ctermid' function. */ > #undef HAVE_CTERMID > > /* Define if you have the 'ctermid_r' function. */ > *** > *** 151,169 > /* Define if you have the 'resize_term' function. */ > #undef HAVE_CURSES_RESIZE_TERM > > ! /* Define to 1 if you have the declaration of `isfinite', and to 0 if you > don't. */ > #define HAVE_DECL_ISFINITE0 > > ! /* Define to 1 if you have the de
[edk2] [Patch v2 1/1] AppPkg/Python remove improper characters from pyconfig.h
AppPkg: Within the Ia32 and X64 pyconfig.h files, there are 178 occurrences of an accent character, `, being used instead of a regular single quote, ', within comments. Replace all occurrences of ` within comments with '. Example: OLD: `foobar' NEW: 'foobar' The same changes are applied to both AppPkg/Applications/Python/Ia32/pyconfig.h and AppPkg/Applications/Python/X64/pyconfig.h. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daryl McDaniel *** a/AppPkg/Applications/Python/X64/pyconfig.h-revBASE.svn001.tmp.hFri Mar 23 17:19:06 2012 --- b/AppPkg/Applications/Python/X64/pyconfig.h Tue Oct 20 12:43:43 2015 *** *** 58,88 the case on Motorola V4 (R40V4.2) */ #undef GETTIMEOFDAY_NO_TZ ! /* Define to 1 if you have the `acosh' function. */ #undef HAVE_ACOSH /* struct addrinfo (netdb.h) */ #undef HAVE_ADDRINFO ! /* Define to 1 if you have the `alarm' function. */ #undef HAVE_ALARM /* Define this if your time.h defines altzone. */ #undef HAVE_ALTZONE ! /* Define to 1 if you have the `asinh' function. */ #undef HAVE_ASINH /* Define to 1 if you have the header file. */ #undef HAVE_ASM_TYPES_H ! /* Define to 1 if you have the `atanh' function. */ #undef HAVE_ATANH /* Define if GCC supports __attribute__((format(PyArg_ParseTuple, 2, 3))) */ #undef HAVE_ATTRIBUTE_FORMAT_PARSETUPLE ! /* Define to 1 if you have the `bind_textdomain_codeset' function. */ #undef HAVE_BIND_TEXTDOMAIN_CODESET /* Define to 1 if you have the header file. */ --- 58,88 the case on Motorola V4 (R40V4.2) */ #undef GETTIMEOFDAY_NO_TZ ! /* Define to 1 if you have the 'acosh' function. */ #undef HAVE_ACOSH /* struct addrinfo (netdb.h) */ #undef HAVE_ADDRINFO ! /* Define to 1 if you have the 'alarm' function. */ #undef HAVE_ALARM /* Define this if your time.h defines altzone. */ #undef HAVE_ALTZONE ! /* Define to 1 if you have the 'asinh' function. */ #undef HAVE_ASINH /* Define to 1 if you have the header file. */ #undef HAVE_ASM_TYPES_H ! /* Define to 1 if you have the 'atanh' function. */ #undef HAVE_ATANH /* Define if GCC supports __attribute__((format(PyArg_ParseTuple, 2, 3))) */ #undef HAVE_ATTRIBUTE_FORMAT_PARSETUPLE ! /* Define to 1 if you have the 'bind_textdomain_codeset' function. */ #undef HAVE_BIND_TEXTDOMAIN_CODESET /* Define to 1 if you have the header file. */ *** *** 112,139 /* Define this if you have the type _Bool. */ #define HAVE_C99_BOOL 1 ! /* Define to 1 if you have the `chflags' function. */ #undef HAVE_CHFLAGS ! /* Define to 1 if you have the `chown' function. */ #undef HAVE_CHOWN /* Define if you have the 'chroot' function. */ #undef HAVE_CHROOT ! /* Define to 1 if you have the `clock' function. */ #define HAVE_CLOCK1 ! /* Define to 1 if you have the `confstr' function. */ #undef HAVE_CONFSTR /* Define to 1 if you have the header file. */ #undef HAVE_CONIO_H ! /* Define to 1 if you have the `copysign' function. */ #undef HAVE_COPYSIGN ! /* Define to 1 if you have the `ctermid' function. */ #undef HAVE_CTERMID /* Define if you have the 'ctermid_r' function. */ --- 112,139 /* Define this if you have the type _Bool. */ #define HAVE_C99_BOOL 1 ! /* Define to 1 if you have the 'chflags' function. */ #undef HAVE_CHFLAGS ! /* Define to 1 if you have the 'chown' function. */ #undef HAVE_CHOWN /* Define if you have the 'chroot' function. */ #undef HAVE_CHROOT ! /* Define to 1 if you have the 'clock' function. */ #define HAVE_CLOCK1 ! /* Define to 1 if you have the 'confstr' function. */ #undef HAVE_CONFSTR /* Define to 1 if you have the header file. */ #undef HAVE_CONIO_H ! /* Define to 1 if you have the 'copysign' function. */ #undef HAVE_COPYSIGN ! /* Define to 1 if you have the 'ctermid' function. */ #undef HAVE_CTERMID /* Define if you have the 'ctermid_r' function. */ *** *** 151,169 /* Define if you have the 'resize_term' function. */ #undef HAVE_CURSES_RESIZE_TERM ! /* Define to 1 if you have the declaration of `isfinite', and to 0 if you don't. */ #define HAVE_DECL_ISFINITE0 ! /* Define to 1 if you have the declaration of `isinf', and to 0 if you don't. */ #define HAVE_DECL_ISINF 1 ! /* Define to 1 if you have the declaration of `isnan', and to 0 if you don't. */ #define HAVE_DECL_ISNAN 1 ! /* Define to 1 if you have the declaration of `tzname', and to 0 if you don't. */ #define HAVE_DECL_TZNAME 0 --- 151,169 /* Define if you have the 'resize_term' function. */ #undef HAVE_CURSES_RESIZE_TERM ! /* Define to 1 if you have the declaration of 'isfinite', and to 0 if you don't. */ #define HAVE_DECL_ISFINITE0 ! /* Define to 1 if
