Re: [edk2] [patch] MdeModulePkg/NvmExpressDxe: comments update to meet implementation

[Simon (Xiang) Lian-SSI]

New change looks good to me.
Thanks,
Simon
-Original Message-
From: Wu, Hao A [mailto:hao.a...@intel.com] 
Sent: Tuesday, April 26, 2016 12:05 AM
To: Tian, Feng; edk2-devel@lists.01.org
Cc: Simon (Xiang) Lian-SSI
Subject: RE: [patch] MdeModulePkg/NvmExpressDxe: comments update to meet 
implementation

Reviewed-by: Hao Wu 

Best Regards,
Hao Wu

> -Original Message-
> From: Tian, Feng
> Sent: Tuesday, April 26, 2016 3:01 PM
> To: edk2-devel@lists.01.org
> Cc: Simon Lian-SSI; Wu; Wu, Hao A
> Subject: [patch] MdeModulePkg/NvmExpressDxe: comments update to meet 
> implementation
> 
> Cc: Simon (Xiang) Lian-SSI 
> Cc: Wu, Hao A 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Feng Tian 
> ---
>  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h | 12 +---
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> index 21c6255..6cbef3e 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> @@ -2,7 +2,7 @@
>NvmExpressDxe driver is used to manage non-volatile memory 
> subsystem which follows
>NVM Express specification.
> 
> -  Copyright (c) 2013 - 2015, Intel Corporation. All rights 
> reserved.
> +  Copyright (c) 2013 - 2016, Intel Corporation. All rights 
> + reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of 
> the BSD License
>which accompanies this distribution.  The full text of the license 
> may be found at @@ -101,13 +101,11 @@ struct 
> _NVME_CONTROLLER_PRIVATE_DATA {
>NVME_ADMIN_CONTROLLER_DATA  *ControllerData;
> 
>//
> -  // 6 x 4kB aligned buffers will be carved out of this buffer.
> +  // 4 x 4kB aligned buffers will be carved out of this buffer.
>// 1st 4kB boundary is the start of the admin submission queue.
> -  // 2nd 4kB boundary is the start of the I/O submission queue #1.
> -  // 3rd 4kB boundary is the start of the admin completion queue.
> -  // 4th 4kB boundary is the start of the I/O completion queue #1.
> -  // 5th 4kB boundary is the start of the first PRP list page.
> -  // 6th 4kB boundary is the start of the second PRP list page.
> +  // 2nd 4kB boundary is the start of the admin completion queue.
> +  // 3rd 4kB boundary is the start of I/O submission queue #1.
> +  // 4th 4kB boundary is the start of I/O completion queue #1.
>//
>UINT8   *Buffer;
>UINT8   *BufferPciAddr;
> --
> 2.7.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [patch] MdeModulePkg/NvmExpressDxe: comments update to meet implementation

[Feng Tian]

Cc: Simon (Xiang) Lian-SSI 
Cc: Wu, Hao A 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian 
---
 MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h | 12 +---
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h 
b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
index 21c6255..6cbef3e 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
@@ -2,7 +2,7 @@
   NvmExpressDxe driver is used to manage non-volatile memory subsystem which 
follows
   NVM Express specification.
 
-  Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.
+  Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -101,13 +101,11 @@ struct _NVME_CONTROLLER_PRIVATE_DATA {
   NVME_ADMIN_CONTROLLER_DATA  *ControllerData;
 
   //
-  // 6 x 4kB aligned buffers will be carved out of this buffer.
+  // 4 x 4kB aligned buffers will be carved out of this buffer.
   // 1st 4kB boundary is the start of the admin submission queue.
-  // 2nd 4kB boundary is the start of the I/O submission queue #1.
-  // 3rd 4kB boundary is the start of the admin completion queue.
-  // 4th 4kB boundary is the start of the I/O completion queue #1.
-  // 5th 4kB boundary is the start of the first PRP list page.
-  // 6th 4kB boundary is the start of the second PRP list page.
+  // 2nd 4kB boundary is the start of the admin completion queue.
+  // 3rd 4kB boundary is the start of I/O submission queue #1.
+  // 4th 4kB boundary is the start of I/O completion queue #1.
   //
   UINT8   *Buffer;
   UINT8   *BufferPciAddr;
-- 
2.7.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] MdeModulePkg/NvmExpressDxe: comments update to meet implementation

[Wu, Hao A]

Reviewed-by: Hao Wu 

Best Regards,
Hao Wu

> -Original Message-
> From: Tian, Feng
> Sent: Tuesday, April 26, 2016 3:01 PM
> To: edk2-devel@lists.01.org
> Cc: Simon Lian-SSI; Wu; Wu, Hao A
> Subject: [patch] MdeModulePkg/NvmExpressDxe: comments update to meet
> implementation
> 
> Cc: Simon (Xiang) Lian-SSI 
> Cc: Wu, Hao A 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Feng Tian 
> ---
>  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h | 12 +---
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> index 21c6255..6cbef3e 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h
> @@ -2,7 +2,7 @@
>NvmExpressDxe driver is used to manage non-volatile memory subsystem
> which follows
>NVM Express specification.
> 
> -  Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.
> +  Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be 
> found
> at
> @@ -101,13 +101,11 @@ struct _NVME_CONTROLLER_PRIVATE_DATA {
>NVME_ADMIN_CONTROLLER_DATA  *ControllerData;
> 
>//
> -  // 6 x 4kB aligned buffers will be carved out of this buffer.
> +  // 4 x 4kB aligned buffers will be carved out of this buffer.
>// 1st 4kB boundary is the start of the admin submission queue.
> -  // 2nd 4kB boundary is the start of the I/O submission queue #1.
> -  // 3rd 4kB boundary is the start of the admin completion queue.
> -  // 4th 4kB boundary is the start of the I/O completion queue #1.
> -  // 5th 4kB boundary is the start of the first PRP list page.
> -  // 6th 4kB boundary is the start of the second PRP list page.
> +  // 2nd 4kB boundary is the start of the admin completion queue.
> +  // 3rd 4kB boundary is the start of I/O submission queue #1.
> +  // 4th 4kB boundary is the start of I/O completion queue #1.
>//
>UINT8   *Buffer;
>UINT8   *BufferPciAddr;
> --
> 2.7.1.windows.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel