Re: [edk2] [patch 1/2] ShellPkg/Dp: Add null pointer check

2018-02-08 Thread Gao, Liming 
Reviewed-by: Liming Gao 

>-Original Message-
>From: Bi, Dandan
>Sent: Friday, February 09, 2018 11:10 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Wu, Hao A 
>Subject: [patch 1/2] ShellPkg/Dp: Add null pointer check
>
>Cc: Liming Gao 
>Cc: Hao Wu 
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi 
>---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>index fafc64f..4dd7dd9 100644
>--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>@@ -255,11 +255,11 @@ GetBootPerformanceTable (
> Status = EfiGetSystemConfigurationTable (
>&gEfiAcpi10TableGuid,
>&AcpiTable
>  );
>   }
>-  if (EFI_ERROR(Status)) {
>+  if (EFI_ERROR(Status) || AcpiTable == NULL) {
> return Status;
>   }
>
>   FirmwarePerformanceTable = FindAcpiPtr (
>   (EFI_ACPI_5_0_ROOT_SYSTEM_DESCRIPTION_POINTER
>*)AcpiTable,
>--
>1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [patch 1/2] ShellPkg/Dp: Add null pointer check

2018-02-08 Thread Dandan Bi 
Cc: Liming Gao 
Cc: Hao Wu 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi 
---
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c 
b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
index fafc64f..4dd7dd9 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
@@ -255,11 +255,11 @@ GetBootPerformanceTable (
 Status = EfiGetSystemConfigurationTable (
&gEfiAcpi10TableGuid,
&AcpiTable
  );
   }
-  if (EFI_ERROR(Status)) {
+  if (EFI_ERROR(Status) || AcpiTable == NULL) {
 return Status;
   }
 
   FirmwarePerformanceTable = FindAcpiPtr (
   (EFI_ACPI_5_0_ROOT_SYSTEM_DESCRIPTION_POINTER 
*)AcpiTable,
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel