Re: [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy for connecting devices
On 03/13/18 22:22, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: qemu_bootorder_connect > > Adding tens or hundreds of bootable devices to a QEMU VM config slows > the OVMF and ArmVirtQemu boots to a crawl, several people have reported > in the past. > > There are at least two reasons for this (high pflash traffic due to > heavy nvvar massaging per device, and PCI config space access slowing > down on QEMU as the number of regions increases). However, part of the > pain is self-inflicted in our PlatformBootManagerLib instances: we > connect all bootable devices (for maximum compatibility with the user's > VM config) even if the user doesn't intend to boot off most of them. > > It's oft repeated that the set of devices connected during boot is > platform policy, so this series replaces the culprit > EfiBootManagerConnectAll() calls with a bit smarter algorithm. Thanks everyone for the super quick feedback! Commit range 12957e56d26d..ff1d0fbfbaec. Cheers, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy for connecting devices
On 13 March 2018 at 21:22, Laszlo Ersekwrote: > Repo: https://github.com/lersek/edk2.git > Branch: qemu_bootorder_connect > > Adding tens or hundreds of bootable devices to a QEMU VM config slows > the OVMF and ArmVirtQemu boots to a crawl, several people have reported > in the past. > > There are at least two reasons for this (high pflash traffic due to > heavy nvvar massaging per device, and PCI config space access slowing > down on QEMU as the number of regions increases). However, part of the > pain is self-inflicted in our PlatformBootManagerLib instances: we > connect all bootable devices (for maximum compatibility with the user's > VM config) even if the user doesn't intend to boot off most of them. > > It's oft repeated that the set of devices connected during boot is > platform policy, so this series replaces the culprit > EfiBootManagerConnectAll() calls with a bit smarter algorithm. > > I sought to keep the commit messages under control. > This is really nice. Most platforms I've worked with just connect everything all the time, which is sloppy. I'm glad you fixed this for *VMF Tested-by: Ard Biesheuvel # ArmVirtQemu Reviewed-by: Ard Biesheuvel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel