Re: [edk2] [PATCH 01/37] AppPkg: Removing ipf which is no longer supported from edk2.
> -Original Message- > From: Chen, Chen A > Sent: Tuesday, June 12, 2018 8:43 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > ; Kinney, Michael D > > Subject: [PATCH 01/37] AppPkg: Removing ipf which is no longer supported > from edk2. > Importance: High > > Removing rules for Ipf sources file: > * Remove the source file which path with "ipf" and also listed in > [Sources.IPF] section of INF file. > * Remove the source file which listed in [Components.IPF] section > of DSC file and not listed in any other [Components] section. > * Remove the embedded Ipf code for MDE_CPU_IPF. > > Removing rules for Inf file: > * Remove IPF from VALID_ARCHITECTURES comments. > * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section. > * Remove the INF which only listed in [Components.IPF] section in DSC. > * Remove statements from [BuildOptions] that provide IPF specific flags. > * Remove any IPF sepcific sections. > > Removing rules for Dec file: > * Remove [Includes.IPF] section from Dec. > > Removing rules for Dsc file: > * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC. > * Remove any IPF specific sections. > * Remove statements from [BuildOptions] that provide IPF specific flags. > > Cc: Jaben Carsey > Cc: Michael D Kinney > Signed-off-by: chenc2 > Contributed-under: TianoCore Contribution Agreement 1.1 Reviewed-by: Jaben Carsey > --- > AppPkg/AppPkg.dsc |2 - > AppPkg/Applications/Enquire/Enquire.inf|2 +- > AppPkg/Applications/Hello/Hello.inf|2 +- > .../OrderedCollectionTest.inf |2 +- > AppPkg/Applications/Python/Ipf/pyconfig.h | 1262 > > AppPkg/Applications/Python/PythonCore.inf |3 +- > AppPkg/Applications/Sockets/DataSink/DataSink.inf |2 +- > .../Applications/Sockets/DataSource/DataSource.inf |2 +- > .../Sockets/GetAddrInfo/GetAddrInfo.inf|2 +- > .../Sockets/GetHostByAddr/GetHostByAddr.inf|2 +- > .../Sockets/GetHostByDns/GetHostByDns.inf |2 +- > .../Sockets/GetHostByName/GetHostByName.inf|2 +- > .../Sockets/GetNameInfo/GetNameInfo.inf|2 +- > .../Sockets/GetNetByAddr/GetNetByAddr.inf |2 +- > .../Sockets/GetNetByName/GetNetByName.inf |2 +- > .../Sockets/GetServByName/GetServByName.inf|2 +- > .../Sockets/GetServByPort/GetServByPort.inf|2 +- > AppPkg/Applications/Sockets/OobRx/OobRx.inf|2 +- > AppPkg/Applications/Sockets/OobTx/OobTx.inf|2 +- > AppPkg/Applications/Sockets/RawIp4Rx/RawIp4Rx.inf |2 +- > AppPkg/Applications/Sockets/RawIp4Tx/RawIp4Tx.inf |2 +- > .../Applications/Sockets/RecvDgram/RecvDgram.inf |2 +- > .../Sockets/SetHostName/SetHostName.inf|2 +- > .../Applications/Sockets/SetSockOpt/SetSockOpt.inf |2 +- > .../Applications/Sockets/TftpServer/TftpServer.inf |2 +- > .../Applications/Sockets/WebServer/WebServer.inf |2 +- > 26 files changed, 24 insertions(+), 1289 deletions(-) > delete mode 100644 AppPkg/Applications/Python/Ipf/pyconfig.h > > diff --git a/AppPkg/AppPkg.dsc b/AppPkg/AppPkg.dsc > index 58bc84e4ed..3187fc53b4 100644 > --- a/AppPkg/AppPkg.dsc > +++ b/AppPkg/AppPkg.dsc > @@ -40,8 +40,6 @@ > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|$(DEBUG_PROPERTY > _MASK) > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ER > ROR_LEVEL) > > -[PcdsFixedAtBuild.IPF] > - > [LibraryClasses] ># ># Entry Point Libraries > diff --git a/AppPkg/Applications/Enquire/Enquire.inf > b/AppPkg/Applications/Enquire/Enquire.inf > index b0a0a29320..d6ef88ad39 100644 > --- a/AppPkg/Applications/Enquire/Enquire.inf > +++ b/AppPkg/Applications/Enquire/Enquire.inf > @@ -29,7 +29,7 @@ >ENTRY_POINT= ShellCEntryLib > > # > -# VALID_ARCHITECTURES = IA32 X64 IPF > +# VALID_ARCHITECTURES = IA32 X64 > # > > [Sources] > diff --git a/AppPkg/Applications/Hello/Hello.inf > b/AppPkg/Applications/Hello/Hello.inf > index 739478b443..7c763d3ead 100644 > --- a/AppPkg/Applications/Hello/Hello.inf > +++ b/AppPkg/Applications/Hello/Hello.inf > @@ -21,7 +21,7 @@ >ENTRY_POINT= ShellCEntryLib > > # > -# VALID_ARCHITECTURES = IA32 X64 IPF > +# VALID_ARCHITECTURES = IA32 X64 > # > > [Sources] > diff --git > a/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.inf > b/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.inf > index cfa835b761..b8d94a8cb9 100644 > --- a/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.inf > +++ > b/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.inf > @@ -24,7 +24,7 @@ >ENTRY_POINT= ShellCEntryLib > > # > -# VALID_ARCHITECTURES = IA32 X64 IPF > +#
Re: [edk2] [PATCH 01/37] AppPkg: Removing ipf which is no longer supported from edk2.
On 2018-06-12 20:43:03, chenc2 wrote: > Removing rules for Ipf sources file: > * Remove the source file which path with "ipf" and also listed in > [Sources.IPF] section of INF file. > * Remove the source file which listed in [Components.IPF] section > of DSC file and not listed in any other [Components] section. > * Remove the embedded Ipf code for MDE_CPU_IPF. > > Removing rules for Inf file: > * Remove IPF from VALID_ARCHITECTURES comments. > * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section. > * Remove the INF which only listed in [Components.IPF] section in DSC. > * Remove statements from [BuildOptions] that provide IPF specific flags. > * Remove any IPF sepcific sections. > > Removing rules for Dec file: > * Remove [Includes.IPF] section from Dec. > > Removing rules for Dsc file: > * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC. > * Remove any IPF specific sections. > * Remove statements from [BuildOptions] that provide IPF specific flags. > > Cc: Jaben Carsey > Cc: Michael D Kinney > Signed-off-by: chenc2 I don't think this matches the requirement in Contributions.txt, which says: "Signed-off-by" is the contributor's signature identifying them by their real/legal name and their email address. You can easily fix this by running git config. For example, in my case I would run: $ git config --global user.name "Jordan Justen" After this in the future "git commit -s" will add the correct Signed-off-by automatically. (But, you'll still need to remove the older Signed-off-by tag.) Also, this should fix the committer and author in git log. For example, if you run "git log -1 --pretty=fuller", you will probably see that your name is shown as chenc2 in the author and committer fields. Finally, when you run git send-email, if you specify *.patch, then all patches will be grouped together in a single thread. (Of course, you'll want to make sure you remove all stale patches before running format-patch so extra patches will not be sent.) Thanks, -Jordan > Contributed-under: TianoCore Contribution Agreement 1.1 > --- > AppPkg/AppPkg.dsc |2 - > AppPkg/Applications/Enquire/Enquire.inf|2 +- > AppPkg/Applications/Hello/Hello.inf|2 +- > .../OrderedCollectionTest.inf |2 +- > AppPkg/Applications/Python/Ipf/pyconfig.h | 1262 > > AppPkg/Applications/Python/PythonCore.inf |3 +- > AppPkg/Applications/Sockets/DataSink/DataSink.inf |2 +- > .../Applications/Sockets/DataSource/DataSource.inf |2 +- > .../Sockets/GetAddrInfo/GetAddrInfo.inf|2 +- > .../Sockets/GetHostByAddr/GetHostByAddr.inf|2 +- > .../Sockets/GetHostByDns/GetHostByDns.inf |2 +- > .../Sockets/GetHostByName/GetHostByName.inf|2 +- > .../Sockets/GetNameInfo/GetNameInfo.inf|2 +- > .../Sockets/GetNetByAddr/GetNetByAddr.inf |2 +- > .../Sockets/GetNetByName/GetNetByName.inf |2 +- > .../Sockets/GetServByName/GetServByName.inf|2 +- > .../Sockets/GetServByPort/GetServByPort.inf|2 +- > AppPkg/Applications/Sockets/OobRx/OobRx.inf|2 +- > AppPkg/Applications/Sockets/OobTx/OobTx.inf|2 +- > AppPkg/Applications/Sockets/RawIp4Rx/RawIp4Rx.inf |2 +- > AppPkg/Applications/Sockets/RawIp4Tx/RawIp4Tx.inf |2 +- > .../Applications/Sockets/RecvDgram/RecvDgram.inf |2 +- > .../Sockets/SetHostName/SetHostName.inf|2 +- > .../Applications/Sockets/SetSockOpt/SetSockOpt.inf |2 +- > .../Applications/Sockets/TftpServer/TftpServer.inf |2 +- > .../Applications/Sockets/WebServer/WebServer.inf |2 +- > 26 files changed, 24 insertions(+), 1289 deletions(-) > delete mode 100644 AppPkg/Applications/Python/Ipf/pyconfig.h > > diff --git a/AppPkg/AppPkg.dsc b/AppPkg/AppPkg.dsc > index 58bc84e4ed..3187fc53b4 100644 > --- a/AppPkg/AppPkg.dsc > +++ b/AppPkg/AppPkg.dsc > @@ -40,8 +40,6 @@ >gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|$(DEBUG_PROPERTY_MASK) >gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL) > > -[PcdsFixedAtBuild.IPF] > - > [LibraryClasses] ># ># Entry Point Libraries > diff --git a/AppPkg/Applications/Enquire/Enquire.inf > b/AppPkg/Applications/Enquire/Enquire.inf > index b0a0a29320..d6ef88ad39 100644 > --- a/AppPkg/Applications/Enquire/Enquire.inf > +++ b/AppPkg/Applications/Enquire/Enquire.inf > @@ -29,7 +29,7 @@ >ENTRY_POINT= ShellCEntryLib > > # > -# VALID_ARCHITECTURES = IA32 X64 IPF > +# VALID_ARCHITECTURES = IA32 X64 > # > > [Sources] > diff --git a/AppPkg/Applications/Hello/Hello.inf > b/AppPkg/Applications/Hello/Hello.inf > index 739478b443..7c763d3ead 100644 > --- a/AppPkg/Applications/Hello/Hello.inf > +++ b/AppPkg/Applications/Hello/Hello.inf > @@ -21,7 +21,7 @@
