Re: [edk2] [PATCH 05/12] BeagleBoardPkg: Convert to build FatPkg from source

[Laszlo Ersek]

On 04/06/16 17:14, Jordan Justen wrote:
> Now that FatPkg is open source (and therefore can be included in the
> EDK II tree) we build and use it directly.
> 
> Note: Not build tested
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> ---
>  BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
>  BeagleBoardPkg/BeagleBoardPkg.fdf | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)

Commit 3d1ee3c1d683b9679d6fe2bae6ff07a600d7960f.

I removed the line "Note: Not build tested".

I added the following tags:

Reviewed-by: Ard Biesheuvel 
Reviewed-by: Leif Lindholm 
Build-tested-by: Leif Lindholm 
Build-tested-by: Ard Biesheuvel 

The first two directly from on-list feedback.

The third one: indirectly, from on-list feedback. (See Leif's email.)

The fourth one: from private discussion (see again msgid
<145996312416.2716.2085766076885492369@jljusten-ivb>).

Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 05/12] BeagleBoardPkg: Convert to build FatPkg from source

[Leif Lindholm]

On Wed, Apr 06, 2016 at 08:14:54AM -0700, Jordan Justen wrote:
> Now that FatPkg is open source (and therefore can be included in the
> EDK II tree) we build and use it directly.
> 
> Note: Not build tested

I have build tested it, and no issues found.
Reviewed-by: Leif Lindholm 

Regards,

Leif

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> ---
>  BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
>  BeagleBoardPkg/BeagleBoardPkg.fdf | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc 
> b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 17f9f8e..aedaf4e 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -2,7 +2,7 @@
>  # Beagle board package.
>  #
>  # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>  #
>  #This program and the accompanying materials
>  #are licensed and made available under the terms and conditions of the 
> BSD License
> @@ -427,6 +427,7 @@
>MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> +  FatPkg/EnhancedFatDxe/Fat.inf
>  
>#
># USB
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf 
> b/BeagleBoardPkg/BeagleBoardPkg.fdf
> index b17ad7d..733b5a4 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.fdf
> +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf
> @@ -1,7 +1,7 @@
>  # FLASH layout file for Beagle board.
>  #
>  # Copyright (c) 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>  #
>  #This program and the accompanying materials
>  #are licensed and made available under the terms and conditions of the 
> BSD License
> @@ -159,7 +159,7 @@ FvNameGuid = d0dd3e90-343d-4cb3-8f69-772214989282
>#
>INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> +  INF FatPkg/EnhancedFatDxe/Fat.inf
>INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
>  
>#
> -- 
> 2.7.0
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 05/12] BeagleBoardPkg: Convert to build FatPkg from source

[Ard Biesheuvel]

On 6 April 2016 at 17:14, Jordan Justen  wrote:
> Now that FatPkg is open source (and therefore can be included in the
> EDK II tree) we build and use it directly.
>
> Note: Not build tested
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 

Reviewed-by: Ard Biesheuvel 

> ---
>  BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++-
>  BeagleBoardPkg/BeagleBoardPkg.fdf | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc 
> b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 17f9f8e..aedaf4e 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -2,7 +2,7 @@
>  # Beagle board package.
>  #
>  # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>  #
>  #This program and the accompanying materials
>  #are licensed and made available under the terms and conditions of the 
> BSD License
> @@ -427,6 +427,7 @@
>MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> +  FatPkg/EnhancedFatDxe/Fat.inf
>
>#
># USB
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf 
> b/BeagleBoardPkg/BeagleBoardPkg.fdf
> index b17ad7d..733b5a4 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.fdf
> +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf
> @@ -1,7 +1,7 @@
>  # FLASH layout file for Beagle board.
>  #
>  # Copyright (c) 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>  #
>  #This program and the accompanying materials
>  #are licensed and made available under the terms and conditions of the 
> BSD License
> @@ -159,7 +159,7 @@ FvNameGuid = d0dd3e90-343d-4cb3-8f69-772214989282
>#
>INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> -  INF FatBinPkg/EnhancedFatDxe/Fat.inf
> +  INF FatPkg/EnhancedFatDxe/Fat.inf
>INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
>
>#
> --
> 2.7.0
>
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel