subject:"Re\: \[edk2\] \[PATCH v2 17\/17\] BaseTools\/AutoGen\: Update header file for MM modules."

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

2018-06-04 Thread Supreeth Venkatesh

Liming,

Thanks for the feedback. I have sent v3 of this patch.
Sorry for the delay, I was waiting for feedback on other patches in the patch 
set.

Thanks,
Supreeth

-Original Message-
From: Gao, Liming 
Sent: Monday, May 7, 2018 10:11 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen 
; Achin Gupta ; 
leif.lindh...@linaro.org; ard.biesheu...@linaro.org
Subject: RE: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM 
modules.

Hi,
  This change should map to PiMm.h. I see the version 1 patch uses PiMm.h.

+SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"],
+SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h",
+ "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"],

> -Original Message-
> From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com]
> Sent: Saturday, May 5, 2018 4:41 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Yao, Jiewen ;
> achin.gu...@arm.com; leif.lindh...@linaro.org;
> ard.biesheu...@linaro.org; Supreeth Venkatesh
> 
> Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM 
> modules.
>
> This patch corrects the Module Type Header file for Management
> Mode(MM) as specified in PI v1.6 Specification. Also, it updates
> parameter for auto generated template functions from
> EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Supreeth Venkatesh 
> Reviewed-by: Jiewen Yao 
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index d06252..42753af62e 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -265,7 +265,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);
>  ${END}
>  """)
> @@ -278,7 +278,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -292,7 +292,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -307,7 +307,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -675,7 +675,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);${END}
>  """),
>  }
> @@ -755,7 +755,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
>  SUP_MODULE_UEFI_DRIVER   :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
>  SUP_MODULE_UEFI_APPLICATION  :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
>  SUP_MODULE_SMM_CORE  :   ["PiDxe.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiDriverEntryPoint.h"],
> -SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> -SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> +SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/StandaloneMmDriverEntryPoint.h"],
> +SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h",
> + "Library/DebugLib.h",
> "Library/StandaloneMmCoreEntryPoint.h"],
>  SUP_MODULE_USER_DEFINED  :   [gBasicHeaderFile]
>  }
>
> --
> 2.16.2

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

2018-05-07 Thread Supreeth Venkatesh

Thanks Liming.
With new changes in this file and three-way merge, I have messed this up.
I will resend v3 of this again.

Supreeth

-Original Message-
From: Gao, Liming 
Sent: Monday, May 7, 2018 10:11 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen 
; Achin Gupta ; 
leif.lindh...@linaro.org; ard.biesheu...@linaro.org
Subject: RE: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM 
modules.

Hi,
  This change should map to PiMm.h. I see the version 1 patch uses PiMm.h.

+SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"],
+SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h",
+ "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"],

> -Original Message-
> From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com]
> Sent: Saturday, May 5, 2018 4:41 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Yao, Jiewen ;
> achin.gu...@arm.com; leif.lindh...@linaro.org;
> ard.biesheu...@linaro.org; Supreeth Venkatesh
> 
> Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM 
> modules.
>
> This patch corrects the Module Type Header file for Management
> Mode(MM) as specified in PI v1.6 Specification. Also, it updates
> parameter for auto generated template functions from
> EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Supreeth Venkatesh 
> Reviewed-by: Jiewen Yao 
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index d06252..42753af62e 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -265,7 +265,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);
>  ${END}
>  """)
> @@ -278,7 +278,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -292,7 +292,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -307,7 +307,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>
>  {
> @@ -675,7 +675,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);${END}
>  """),
>  }
> @@ -755,7 +755,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
>  SUP_MODULE_UEFI_DRIVER   :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
>  SUP_MODULE_UEFI_APPLICATION  :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
>  SUP_MODULE_SMM_CORE  :   ["PiDxe.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiDriverEntryPoint.h"],
> -SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> -SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> +SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/StandaloneMmDriverEntryPoint.h"],
> +SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h",
> + "Library/DebugLib.h",
> "Library/StandaloneMmCoreEntryPoint.h"],
>  SUP_MODULE_USER_DEFINED  :   [gBasicHeaderFile]
>  }
>
> --
> 2.16.2

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

2018-05-07 Thread Gao, Liming

Hi, 
  This change should map to PiMm.h. I see the version 1 patch uses PiMm.h.

+SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"],
+SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", 
"Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"],

> -Original Message-
> From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com]
> Sent: Saturday, May 5, 2018 4:41 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming 
> ; Yao, Jiewen ;
> achin.gu...@arm.com; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; 
> Supreeth Venkatesh 
> Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM 
> modules.
> 
> This patch corrects the Module Type Header file for Management Mode(MM)
> as specified in PI v1.6 Specification. Also, it updates parameter for
> auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
> EFI_MM_SYSTEM_TABLE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Supreeth Venkatesh 
> Reviewed-by: Jiewen Yao 
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py 
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index d06252..42753af62e 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -265,7 +265,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);
>  ${END}
>  """)
> @@ -278,7 +278,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
> 
>  {
> @@ -292,7 +292,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
> 
>  {
> @@ -307,7 +307,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
> 
>  {
> @@ -675,7 +675,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>);${END}
>  """),
>  }
> @@ -755,7 +755,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>IN EFI_HANDLEImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>)
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -779,8 +779,8 @@ gModuleTypeHeaderFile = {
>  SUP_MODULE_UEFI_DRIVER   :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"],
>  SUP_MODULE_UEFI_APPLICATION  :   ["Uefi.h",  "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.h"],
>  SUP_MODULE_SMM_CORE  :   ["PiDxe.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/UefiDriverEntryPoint.h"],
> -SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> -SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> +SUP_MODULE_MM_STANDALONE :   ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/StandaloneMmDriverEntryPoint.h"],
> +SUP_MODULE_MM_CORE_STANDALONE :  ["PiSmm.h", "Library/BaseLib.h", 
> "Library/DebugLib.h",
> "Library/StandaloneMmCoreEntryPoint.h"],
>  SUP_MODULE_USER_DEFINED  :   [gBasicHeaderFile]
>  }
> 
> --
> 2.16.2

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

3 matches

Site Navigation

Mail list logo

Footer information