Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-31 Thread Ard Biesheuvel
On 29 May 2018 at 16:31, Kinney, Michael D  wrote:
> Ard,
>
> I broke the series up into multiple series.
>
> I can send out the 4th one this morning so
> you can see the one that uses it.  It is a
> repeat of content that was shared in a single
> series earlier.  I deferred it so we can get
> all the platform updates done first so there
> are no build breaks.
>

Yeah I found the code in question I believe.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Kinney, Michael D
Ard,

I broke the series up into multiple series.

I can send out the 4th one this morning so
you can see the one that uses it.  It is a
repeat of content that was shared in a single
series earlier.  I deferred it so we can get
all the platform updates done first so there
are no build breaks.

Mike

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Tuesday, May 29, 2018 6:08 AM
> To: Gao, Liming 
> Cc: Dong, Eric ; edk2-
> de...@lists.01.org; Yao, Jiewen ;
> Kinney, Michael D ; Zeng,
> Star ; Wei, David
> 
> Subject: Re: [edk2] [Patch v3 0/3] Add
> DisplayUpdateProgressLib for capsules
> 
> Hello Liming,
> 
> On 29 May 2018 at 15:05, Gao, Liming
>  wrote:
> > Do you try to find this one [edk2] [edk2-platforms
> Patch v4 0/6] Add DisplayUpdateProgressLib to platforms?
> >
> 
> No, I am trying to locate the patch that actually
> invokes the new
> PerformFlashWriteWithProgress() function when processing
> the capsule.
> 
> >> -Original Message-
> >> From: edk2-devel [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of Ard Biesheuvel
> >> Sent: Tuesday, May 29, 2018 8:43 PM
> >> To: Kinney, Michael D 
> >> Cc: edk2-devel@lists.01.org; Yao, Jiewen
> ; Dong, Eric
> ; Zeng, Star
> >> ; Wei, David
> 
> >> Subject: Re: [edk2] [Patch v3 0/3] Add
> DisplayUpdateProgressLib for capsules
> >>
> >> On 29 May 2018 at 11:51, Ard Biesheuvel
>  wrote:
> >> > On 29 May 2018 at 11:51, Ard Biesheuvel
>  wrote:
> >> >> On 25 May 2018 at 08:15, Michael D Kinney
>  wrote:
> >> >>>
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
> >> >>>
> >> >>> Based on content from:
> >> >>>
> >> >>>
> >>
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsul
> eSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdat
> eProgress
> >> Lib.h
> >> >>>
> >>
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsul
> eSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgres
> sGraphics
> >> Lib
> >> >>>
> >>
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsul
> eSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgres
> sTextLib
> >> >>>
> >> >>> Updates for V3
> >> >>> ==
> >> >>> * Add Version field to
> EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
> >> >>> * Break up patch series into 4 smaller patch
> series to handle dependencies
> >> >>>   between the edk2 repository and the edk2-
> platforms repository.
> >> >>>   + Patch series for edk2 repo that adds
> DisplayUpdateProgressLib class and
> >> >>> instances.  Defines the
> EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
> >> >>> Adds PerformFlashWriteWithProgress() API to
> the PlatformFlashAccessLib.
> >> >>>   + Patch series for platforms in edk2-platforms
> that use capsules to add the
> >> >>> DisplayUpdateProgressLib mapping to the DSC
> files and add the
> >> >>> PerformFlashWriteWithProgress() API
> implementation to the
> >> >>> PlatformFlashAccessLib implementations.
> >> >>>   + Patch series for platforms in edk2 that use
> capsules to add the
> >> >>> DisplayUpdateProgressLib mapping to the DSC
> files and add the
> >> >>> PerformFlashWriteWithProgress() API
> implementation to the
> >> >>> PlatformFlashAccessLib implementations.
> >> >>>   + Patch for edk2 that adds the use of the
> DisplayUpateProgressLib and the
> >> >>> PerformFlashWriteWithProgress() API .
> >> >>>
> >> >>> Updates for V2
> >> >>> ==
> >> >>> * Change DisplayUpdateProgressGraphicsLib to
> DisplayUpdateProgressLibGraphics
> >> >>> * Change DisplayUpdateProgressTextLib to
> DisplayUpdateProgressLibText
> >> >>> * Clarify that color in Firmware Management
> Progress Protocol is the foreground color
> >> >>> * Add missing parameters to
> PerformFlashWriteWithProgress() function header.
> >> >>> * Update PerformFlashWriteWithProgress() function
> header describing the use of
> >> >>>   the start and end percentage values.
> >> >>> * Update QuarkPlatformPkg
> PerformFl

Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Ard Biesheuvel
Hello Liming,

On 29 May 2018 at 15:05, Gao, Liming  wrote:
> Do you try to find this one [edk2] [edk2-platforms Patch v4 0/6] Add 
> DisplayUpdateProgressLib to platforms?
>

No, I am trying to locate the patch that actually invokes the new
PerformFlashWriteWithProgress() function when processing the capsule.

>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard 
>> Biesheuvel
>> Sent: Tuesday, May 29, 2018 8:43 PM
>> To: Kinney, Michael D 
>> Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Dong, Eric 
>> ; Zeng, Star
>> ; Wei, David 
>> Subject: Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules
>>
>> On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
>> > On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
>> >> On 25 May 2018 at 08:15, Michael D Kinney  
>> >> wrote:
>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>> >>>
>> >>> Based on content from:
>> >>>
>> >>>
>> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgress
>> Lib.h
>> >>>
>> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphics
>> Lib
>> >>>
>> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib
>> >>>
>> >>> Updates for V3
>> >>> ==
>> >>> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
>> >>> * Break up patch series into 4 smaller patch series to handle 
>> >>> dependencies
>> >>>   between the edk2 repository and the edk2-platforms repository.
>> >>>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class 
>> >>> and
>> >>> instances.  Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
>> >>> Adds PerformFlashWriteWithProgress() API to the 
>> >>> PlatformFlashAccessLib.
>> >>>   + Patch series for platforms in edk2-platforms that use capsules to 
>> >>> add the
>> >>> DisplayUpdateProgressLib mapping to the DSC files and add the
>> >>> PerformFlashWriteWithProgress() API implementation to the
>> >>> PlatformFlashAccessLib implementations.
>> >>>   + Patch series for platforms in edk2 that use capsules to add the
>> >>> DisplayUpdateProgressLib mapping to the DSC files and add the
>> >>> PerformFlashWriteWithProgress() API implementation to the
>> >>> PlatformFlashAccessLib implementations.
>> >>>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and 
>> >>> the
>> >>> PerformFlashWriteWithProgress() API .
>> >>>
>> >>> Updates for V2
>> >>> ==
>> >>> * Change DisplayUpdateProgressGraphicsLib to 
>> >>> DisplayUpdateProgressLibGraphics
>> >>> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
>> >>> * Clarify that color in Firmware Management Progress Protocol is the 
>> >>> foreground color
>> >>> * Add missing parameters to PerformFlashWriteWithProgress() function 
>> >>> header.
>> >>> * Update PerformFlashWriteWithProgress() function header describing the 
>> >>> use of
>> >>>   the start and end percentage values.
>> >>> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call 
>> >>> Progress() for
>> >>>   the end precentage.
>> >>> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call 
>> >>> Progress()
>> >>>   for the end precentage.
>> >>>
>> >>> Add DisplayUpdateProgressLib class along implementations for both 
>> >>> graphical
>> >>> (Graphics Output Protocol based) and text (Simple Text Output Protocol 
>> >>> based)
>> >>> consoles.  Also add the EDK II Firmware Management Progress Protocol 
>> >>> that is an
>> >>> optional protocol that provides the progress bar color and a watchdog 
>> >>> timeout
>> >>> value thaty can be used when a firmware image is updated in a firmware 
>> >>> device.
>> >>>
>> >>

Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Gao, Liming
Do you try to find this one [edk2] [edk2-platforms Patch v4 0/6] Add 
DisplayUpdateProgressLib to platforms?

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard 
> Biesheuvel
> Sent: Tuesday, May 29, 2018 8:43 PM
> To: Kinney, Michael D 
> Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Dong, Eric 
> ; Zeng, Star
> ; Wei, David 
> Subject: Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules
> 
> On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
> > On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
> >> On 25 May 2018 at 08:15, Michael D Kinney  
> >> wrote:
> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=801
> >>>
> >>> Based on content from:
> >>>
> >>>
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgress
> Lib.h
> >>>
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphics
> Lib
> >>>
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib
> >>>
> >>> Updates for V3
> >>> ==
> >>> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
> >>> * Break up patch series into 4 smaller patch series to handle dependencies
> >>>   between the edk2 repository and the edk2-platforms repository.
> >>>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class 
> >>> and
> >>> instances.  Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
> >>> Adds PerformFlashWriteWithProgress() API to the 
> >>> PlatformFlashAccessLib.
> >>>   + Patch series for platforms in edk2-platforms that use capsules to add 
> >>> the
> >>> DisplayUpdateProgressLib mapping to the DSC files and add the
> >>> PerformFlashWriteWithProgress() API implementation to the
> >>> PlatformFlashAccessLib implementations.
> >>>   + Patch series for platforms in edk2 that use capsules to add the
> >>> DisplayUpdateProgressLib mapping to the DSC files and add the
> >>> PerformFlashWriteWithProgress() API implementation to the
> >>> PlatformFlashAccessLib implementations.
> >>>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and 
> >>> the
> >>> PerformFlashWriteWithProgress() API .
> >>>
> >>> Updates for V2
> >>> ==
> >>> * Change DisplayUpdateProgressGraphicsLib to 
> >>> DisplayUpdateProgressLibGraphics
> >>> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
> >>> * Clarify that color in Firmware Management Progress Protocol is the 
> >>> foreground color
> >>> * Add missing parameters to PerformFlashWriteWithProgress() function 
> >>> header.
> >>> * Update PerformFlashWriteWithProgress() function header describing the 
> >>> use of
> >>>   the start and end percentage values.
> >>> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call 
> >>> Progress() for
> >>>   the end precentage.
> >>> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call 
> >>> Progress()
> >>>   for the end precentage.
> >>>
> >>> Add DisplayUpdateProgressLib class along implementations for both 
> >>> graphical
> >>> (Graphics Output Protocol based) and text (Simple Text Output Protocol 
> >>> based)
> >>> consoles.  Also add the EDK II Firmware Management Progress Protocol that 
> >>> is an
> >>> optional protocol that provides the progress bar color and a watchdog 
> >>> timeout
> >>> value thaty can be used when a firmware image is updated in a firmware 
> >>> device.
> >>>
> >>> * Add progress support to DxeCapsuleLibFmp
> >>> * Add progress support to SystemFirmwareUpdateDxe
> >>> * Add progress support to PlatformFlashAccessLib class and instances.
> >>> * Reduce Print() calls during a firmware update.
> >>>
> >>> Cc: Sean Brogan 
> >>> Cc: Star Zeng 
> >>> Cc: Eric Dong 
> >>> Cc: Jiewen Yao 
> >>> Cc: David Wei 
> >>> Cc: Mang Guo 
> >>> Cc: Kelly Steele 
> >>>
> >>> Signed-off-by: Michael D Kinney 
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>>
> >>> Michael D Kinney (3):
> >>>   MdeModulePkg: Add DisplayUpdateProgressLib class
> >>>   MdeModulePkg: Add DisplayUpdateProgressLib instances
> >>>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
> >>>
> >>
> >> This message says 0/3, but there appear to be 4 patches in the series???
> >>
> >
> > Never mind, the threading in my email client confused me.
> 
> OK I am still confused
> 
> Where is this patch:
> 
>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
> PerformFlashWriteWithProgress() API .
> 
> ??
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Ard Biesheuvel
On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
> On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
>> On 25 May 2018 at 08:15, Michael D Kinney  wrote:
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>>>
>>> Based on content from:
>>>
>>> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
>>> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphicsLib
>>> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib
>>>
>>> Updates for V3
>>> ==
>>> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
>>> * Break up patch series into 4 smaller patch series to handle dependencies
>>>   between the edk2 repository and the edk2-platforms repository.
>>>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class and
>>> instances.  Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
>>> Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLib.
>>>   + Patch series for platforms in edk2-platforms that use capsules to add 
>>> the
>>> DisplayUpdateProgressLib mapping to the DSC files and add the
>>> PerformFlashWriteWithProgress() API implementation to the
>>> PlatformFlashAccessLib implementations.
>>>   + Patch series for platforms in edk2 that use capsules to add the
>>> DisplayUpdateProgressLib mapping to the DSC files and add the
>>> PerformFlashWriteWithProgress() API implementation to the
>>> PlatformFlashAccessLib implementations.
>>>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
>>> PerformFlashWriteWithProgress() API .
>>>
>>> Updates for V2
>>> ==
>>> * Change DisplayUpdateProgressGraphicsLib to 
>>> DisplayUpdateProgressLibGraphics
>>> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
>>> * Clarify that color in Firmware Management Progress Protocol is the 
>>> foreground color
>>> * Add missing parameters to PerformFlashWriteWithProgress() function header.
>>> * Update PerformFlashWriteWithProgress() function header describing the use 
>>> of
>>>   the start and end percentage values.
>>> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call 
>>> Progress() for
>>>   the end precentage.
>>> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call 
>>> Progress()
>>>   for the end precentage.
>>>
>>> Add DisplayUpdateProgressLib class along implementations for both graphical
>>> (Graphics Output Protocol based) and text (Simple Text Output Protocol 
>>> based)
>>> consoles.  Also add the EDK II Firmware Management Progress Protocol that 
>>> is an
>>> optional protocol that provides the progress bar color and a watchdog 
>>> timeout
>>> value thaty can be used when a firmware image is updated in a firmware 
>>> device.
>>>
>>> * Add progress support to DxeCapsuleLibFmp
>>> * Add progress support to SystemFirmwareUpdateDxe
>>> * Add progress support to PlatformFlashAccessLib class and instances.
>>> * Reduce Print() calls during a firmware update.
>>>
>>> Cc: Sean Brogan 
>>> Cc: Star Zeng 
>>> Cc: Eric Dong 
>>> Cc: Jiewen Yao 
>>> Cc: David Wei 
>>> Cc: Mang Guo 
>>> Cc: Kelly Steele 
>>>
>>> Signed-off-by: Michael D Kinney 
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>
>>> Michael D Kinney (3):
>>>   MdeModulePkg: Add DisplayUpdateProgressLib class
>>>   MdeModulePkg: Add DisplayUpdateProgressLib instances
>>>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
>>>
>>
>> This message says 0/3, but there appear to be 4 patches in the series???
>>
>
> Never mind, the threading in my email client confused me.

OK I am still confused

Where is this patch:

  + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
PerformFlashWriteWithProgress() API .

??
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Ard Biesheuvel
On 29 May 2018 at 11:51, Ard Biesheuvel  wrote:
> On 25 May 2018 at 08:15, Michael D Kinney  wrote:
>> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>>
>> Based on content from:
>>
>> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
>> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphicsLib
>> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib
>>
>> Updates for V3
>> ==
>> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
>> * Break up patch series into 4 smaller patch series to handle dependencies
>>   between the edk2 repository and the edk2-platforms repository.
>>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class and
>> instances.  Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
>> Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLib.
>>   + Patch series for platforms in edk2-platforms that use capsules to add the
>> DisplayUpdateProgressLib mapping to the DSC files and add the
>> PerformFlashWriteWithProgress() API implementation to the
>> PlatformFlashAccessLib implementations.
>>   + Patch series for platforms in edk2 that use capsules to add the
>> DisplayUpdateProgressLib mapping to the DSC files and add the
>> PerformFlashWriteWithProgress() API implementation to the
>> PlatformFlashAccessLib implementations.
>>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
>> PerformFlashWriteWithProgress() API .
>>
>> Updates for V2
>> ==
>> * Change DisplayUpdateProgressGraphicsLib to DisplayUpdateProgressLibGraphics
>> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
>> * Clarify that color in Firmware Management Progress Protocol is the 
>> foreground color
>> * Add missing parameters to PerformFlashWriteWithProgress() function header.
>> * Update PerformFlashWriteWithProgress() function header describing the use 
>> of
>>   the start and end percentage values.
>> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress() 
>> for
>>   the end precentage.
>> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress()
>>   for the end precentage.
>>
>> Add DisplayUpdateProgressLib class along implementations for both graphical
>> (Graphics Output Protocol based) and text (Simple Text Output Protocol based)
>> consoles.  Also add the EDK II Firmware Management Progress Protocol that is 
>> an
>> optional protocol that provides the progress bar color and a watchdog timeout
>> value thaty can be used when a firmware image is updated in a firmware 
>> device.
>>
>> * Add progress support to DxeCapsuleLibFmp
>> * Add progress support to SystemFirmwareUpdateDxe
>> * Add progress support to PlatformFlashAccessLib class and instances.
>> * Reduce Print() calls during a firmware update.
>>
>> Cc: Sean Brogan 
>> Cc: Star Zeng 
>> Cc: Eric Dong 
>> Cc: Jiewen Yao 
>> Cc: David Wei 
>> Cc: Mang Guo 
>> Cc: Kelly Steele 
>>
>> Signed-off-by: Michael D Kinney 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>>
>> Michael D Kinney (3):
>>   MdeModulePkg: Add DisplayUpdateProgressLib class
>>   MdeModulePkg: Add DisplayUpdateProgressLib instances
>>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
>>
>
> This message says 0/3, but there appear to be 4 patches in the series???
>

Never mind, the threading in my email client confused me.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-29 Thread Ard Biesheuvel
On 25 May 2018 at 08:15, Michael D Kinney  wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>
> Based on content from:
>
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphicsLib
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib
>
> Updates for V3
> ==
> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
> * Break up patch series into 4 smaller patch series to handle dependencies
>   between the edk2 repository and the edk2-platforms repository.
>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class and
> instances.  Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
> Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLib.
>   + Patch series for platforms in edk2-platforms that use capsules to add the
> DisplayUpdateProgressLib mapping to the DSC files and add the
> PerformFlashWriteWithProgress() API implementation to the
> PlatformFlashAccessLib implementations.
>   + Patch series for platforms in edk2 that use capsules to add the
> DisplayUpdateProgressLib mapping to the DSC files and add the
> PerformFlashWriteWithProgress() API implementation to the
> PlatformFlashAccessLib implementations.
>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
> PerformFlashWriteWithProgress() API .
>
> Updates for V2
> ==
> * Change DisplayUpdateProgressGraphicsLib to DisplayUpdateProgressLibGraphics
> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
> * Clarify that color in Firmware Management Progress Protocol is the 
> foreground color
> * Add missing parameters to PerformFlashWriteWithProgress() function header.
> * Update PerformFlashWriteWithProgress() function header describing the use of
>   the start and end percentage values.
> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress() 
> for
>   the end precentage.
> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress()
>   for the end precentage.
>
> Add DisplayUpdateProgressLib class along implementations for both graphical
> (Graphics Output Protocol based) and text (Simple Text Output Protocol based)
> consoles.  Also add the EDK II Firmware Management Progress Protocol that is 
> an
> optional protocol that provides the progress bar color and a watchdog timeout
> value thaty can be used when a firmware image is updated in a firmware device.
>
> * Add progress support to DxeCapsuleLibFmp
> * Add progress support to SystemFirmwareUpdateDxe
> * Add progress support to PlatformFlashAccessLib class and instances.
> * Reduce Print() calls during a firmware update.
>
> Cc: Sean Brogan 
> Cc: Star Zeng 
> Cc: Eric Dong 
> Cc: Jiewen Yao 
> Cc: David Wei 
> Cc: Mang Guo 
> Cc: Kelly Steele 
>
> Signed-off-by: Michael D Kinney 
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Michael D Kinney (3):
>   MdeModulePkg: Add DisplayUpdateProgressLib class
>   MdeModulePkg: Add DisplayUpdateProgressLib instances
>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
>

This message says 0/3, but there appear to be 4 patches in the series???


>  .../Include/Library/DisplayUpdateProgressLib.h |  65 +++
>  .../Include/Protocol/FirmwareManagementProgress.h  |  55 +++
>  .../DisplayUpdateProgressLibGraphics.c | 475 
> +
>  .../DisplayUpdateProgressLibGraphics.inf   |  60 +++
>  .../DisplayUpdateProgressLibGraphics.uni   |  18 +
>  .../DisplayUpdateProgressLibText.c | 174 
>  .../DisplayUpdateProgressLibText.inf   |  53 +++
>  .../DisplayUpdateProgressLibText.uni   |  18 +
>  MdeModulePkg/MdeModulePkg.dec  |  11 +
>  MdeModulePkg/MdeModulePkg.dsc  |   3 +
>  .../Include/Library/PlatformFlashAccessLib.h   |  49 ++-
>  .../PlatformFlashAccessLibNull.c   |  70 ++-
>  12 files changed, 1042 insertions(+), 9 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
>  create mode 100644 MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
>  create mode 100644 
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
>  create mode 100644 
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
>  create mode 100644 
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.uni
>  create mode 100644 
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
>  create mode 100644 
> 

Re: [edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

2018-05-28 Thread Yao, Jiewen
Thank you to add Version.

Patch 1,2,3,4 reviewed-by: jiewen@intel.com

Thank you
Yao Jiewen

> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, May 24, 2018 11:16 PM
> To: edk2-devel@lists.01.org
> Cc: Sean Brogan ; Zeng, Star
> ; Dong, Eric ; Yao, Jiewen
> ; Wei, David ; Guo, Mang
> ; Steele, Kelly 
> Subject: [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
> 
> Based on content from:
> 
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCaps
> uleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu
> leUpdatePkg/Library/DisplayUpdateProgressGraphicsLib
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu
> leUpdatePkg/Library/DisplayUpdateProgressTextLib
> 
> Updates for V3
> ==
> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
> * Break up patch series into 4 smaller patch series to handle dependencies
>   between the edk2 repository and the edk2-platforms repository.
>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class and
> instances.  Defines the
> EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
> Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLib.
>   + Patch series for platforms in edk2-platforms that use capsules to add the
> DisplayUpdateProgressLib mapping to the DSC files and add the
> PerformFlashWriteWithProgress() API implementation to the
> PlatformFlashAccessLib implementations.
>   + Patch series for platforms in edk2 that use capsules to add the
> DisplayUpdateProgressLib mapping to the DSC files and add the
> PerformFlashWriteWithProgress() API implementation to the
> PlatformFlashAccessLib implementations.
>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
> PerformFlashWriteWithProgress() API .
> 
> Updates for V2
> ==
> * Change DisplayUpdateProgressGraphicsLib to
> DisplayUpdateProgressLibGraphics
> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
> * Clarify that color in Firmware Management Progress Protocol is the
> foreground color
> * Add missing parameters to PerformFlashWriteWithProgress() function header.
> * Update PerformFlashWriteWithProgress() function header describing the use
> of
>   the start and end percentage values.
> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress()
> for
>   the end precentage.
> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress()
>   for the end precentage.
> 
> Add DisplayUpdateProgressLib class along implementations for both graphical
> (Graphics Output Protocol based) and text (Simple Text Output Protocol based)
> consoles.  Also add the EDK II Firmware Management Progress Protocol that is
> an
> optional protocol that provides the progress bar color and a watchdog timeout
> value thaty can be used when a firmware image is updated in a firmware device.
> 
> * Add progress support to DxeCapsuleLibFmp
> * Add progress support to SystemFirmwareUpdateDxe
> * Add progress support to PlatformFlashAccessLib class and instances.
> * Reduce Print() calls during a firmware update.
> 
> Cc: Sean Brogan 
> Cc: Star Zeng 
> Cc: Eric Dong 
> Cc: Jiewen Yao 
> Cc: David Wei 
> Cc: Mang Guo 
> Cc: Kelly Steele 
> 
> Signed-off-by: Michael D Kinney 
> Contributed-under: TianoCore Contribution Agreement 1.1
> 
> Michael D Kinney (3):
>   MdeModulePkg: Add DisplayUpdateProgressLib class
>   MdeModulePkg: Add DisplayUpdateProgressLib instances
>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
> 
>  .../Include/Library/DisplayUpdateProgressLib.h |  65 +++
>  .../Include/Protocol/FirmwareManagementProgress.h  |  55 +++
>  .../DisplayUpdateProgressLibGraphics.c | 475
> +
>  .../DisplayUpdateProgressLibGraphics.inf   |  60 +++
>  .../DisplayUpdateProgressLibGraphics.uni   |  18 +
>  .../DisplayUpdateProgressLibText.c | 174 
>  .../DisplayUpdateProgressLibText.inf   |  53 +++
>  .../DisplayUpdateProgressLibText.uni   |  18 +
>  MdeModulePkg/MdeModulePkg.dec  |  11 +
>  MdeModulePkg/MdeModulePkg.dsc  |   3 +
>  .../Include/Library/PlatformFlashAccessLib.h   |  49 ++-
>  .../PlatformFlashAccessLibNull.c   |  70 ++-
>  12 files changed, 1042 insertions(+), 9 deletions(-)
>  create mode 100644
> MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
>  create mode 100644
> MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg
> ressLibGraphics.c
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg
> ressLibGraphics.inf
>  create mode 100644