Re: [PATCH] libelf: check decompressed ZSTD size

[Mark Wielaard]

Hi Aleksei,

On Thu, Nov 23, 2023 at 03:31:47PM +, Aleksei Vetrov wrote:
> Decompression functions like __libelf_decompress_zlib check that
> decompressed data has the same size as it was declared in the header
> (size_out argument). The same check is now added to
> __libelf_decompress_zstd to make sure that the whole allocated buffer is
> initialized.
> 
> * libelf/elf_compress.c (__libelf_decompress_zstd): Use return value
>   of ZSTD_decompress to check that decompressed data size is the
>   same as size_out of the buffer that was allocated.

Thanks, this makes sense. If the decompressed size isn't what was
encoded in the Chdr then we could reduce the size of the d_buf/d_size,
but that probably is not what the user expects. Flagging it as
bad/inconsistent data makes sense. Especially since we do the same for
zlib compressed data.

Pushed,

Mark

[PATCH] libelf: check decompressed ZSTD size

[Aleksei Vetrov]

Decompression functions like __libelf_decompress_zlib check that
decompressed data has the same size as it was declared in the header
(size_out argument). The same check is now added to
__libelf_decompress_zstd to make sure that the whole allocated buffer is
initialized.

* libelf/elf_compress.c (__libelf_decompress_zstd): Use return value
  of ZSTD_decompress to check that decompressed data size is the
  same as size_out of the buffer that was allocated.

Signed-off-by: Aleksei Vetrov 
---
 libelf/elf_compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libelf/elf_compress.c b/libelf/elf_compress.c
index c7283c6a..0ad6a32a 100644
--- a/libelf/elf_compress.c
+++ b/libelf/elf_compress.c
@@ -422,7 +422,7 @@ __libelf_decompress_zstd (void *buf_in, size_t size_in, 
size_t size_out)
 }
 
   size_t ret = ZSTD_decompress (buf_out, size_out, buf_in, size_in);
-  if (ZSTD_isError (ret))
+  if (unlikely (ZSTD_isError (ret)) || unlikely (ret != size_out))
 {
   free (buf_out);
   __libelf_seterrno (ELF_E_DECOMPRESS_ERROR);
-- 
2.43.0.rc1.413.gea7ed67945-goog

[Bug general/30975] elfutils incorrectly reports core files with non-contiguous segments

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30975

--- Comment #7 from Aaron Merey  ---
(In reply to Pablo Galindo Salgado from comment #6)
> Hi, I can confirm that this indeed fixes the issue. Thanks to everyone
> involved. Fantastic work!

Thanks Pablo, glad to hear!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/30975] elfutils incorrectly reports core files with non-contiguous segments

[pablogsal at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30975

--- Comment #6 from Pablo Galindo Salgado  ---
Hi, I can confirm that this indeed fixes the issue. Thanks to everyone
involved. Fantastic work!

-- 
You are receiving this mail because:
You are on the CC list for the bug.