Re: [PATCH 1/2] libdw: Use INTUSE with dwarf_get_units

[Mark Wielaard]

Hi Aaron,

On Wed, Dec 06, 2023 at 08:35:03PM -0500, Aaron Merey wrote:
> Add INTDECL for dwarf_get_units and call dwarf_get_units with INTUSE.

This is obviously OK. Although it is a bit of a micro-optimization.

Thanks,

Mark

Re: [PATCH] tests: fix build against upcoming `gcc-14` (`-Werror=calloc-transposed-args`)

[Mark Wielaard]

Hi Sergei,

On Thu, 2023-12-21 at 09:23 +, Sergei Trofimovich wrote:
> `gcc-14` added a new `-Wcalloc-transposed-args` warning recently. It
> detected minor infelicity in `calloc()` API usage in `elfutils`:
> 
> elfstrmerge.c: In function 'main':
> elfstrmerge.c:450:32: error:
>   'calloc' sizes specified with 'sizeof' in the earlier argument and not 
> in the later argument [-Werror=calloc-transposed-args]
>   450 |   newscnbufs = calloc (sizeof (void *), newshnums);
>   |^~~~
> elfstrmerge.c:450:32: note: earlier argument should specify number of 
> elements, later size of each element
> 

Thanks, looks good. Pushed.

Cheers,

Mark

[PATCH] tests: fix build against upcoming `gcc-14` (`-Werror=calloc-transposed-args`)

[Sergei Trofimovich]

`gcc-14` added a new `-Wcalloc-transposed-args` warning recently. It
detected minor infelicity in `calloc()` API usage in `elfutils`:

elfstrmerge.c: In function 'main':
elfstrmerge.c:450:32: error:
  'calloc' sizes specified with 'sizeof' in the earlier argument and not in 
the later argument [-Werror=calloc-transposed-args]
  450 |   newscnbufs = calloc (sizeof (void *), newshnums);
  |^~~~
elfstrmerge.c:450:32: note: earlier argument should specify number of 
elements, later size of each element

Signed-off-by: Sergei Trofimovich 
---
 tests/elfstrmerge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/elfstrmerge.c b/tests/elfstrmerge.c
index 56350bb9..4eb58bbb 100644
--- a/tests/elfstrmerge.c
+++ b/tests/elfstrmerge.c
@@ -447,7 +447,7 @@ main (int argc, char **argv)
 }
 
   newshnums = shdrnum - 1;
-  newscnbufs = calloc (sizeof (void *), newshnums);
+  newscnbufs = calloc (newshnums, sizeof (void *));
   if (newscnbufs == NULL)
 fail_errno ("Couldn't allocate memory for new section buffers", NULL);
 
-- 
2.42.0