Re: [elinks-dev] Sponsor development of the key motion.
This bug has to be fixed properly, otherwise, this is really interfering with
the default elinks behaviour. If we can fix this cursor geometry issue, I will
surely ask them to include it in the mainstream.
Thanks a lot.
On Tue, Aug 14, 2007 at 07:59:14PM +0200, Witold Filipczyk wrote:
Here is the patch.
Kalle, Jonas, could apply them (key motion patches) to the mainstream ELinks?
move-link-down-line, move-link-prev-line, etc.:
Change mode to NAVIGATE_LINKWISE to preserve the link position when
going back.
---
commit 14b37d0362f9963cb2803d08d2c3e6e84574cdbe
tree 062545598ae45bf519f7e825b0302542061bbf34
parent 2045574edca170a47b1e9f1e05cd210bdae8a49a
author Witold Filipczyk [EMAIL PROTECTED] Tue, 14 Aug 2007 19:56:02 +0200
committer Witold Filipczyk [EMAIL PROTECTED] Tue, 14 Aug 2007 19:56:02 +0200
src/viewer/text/view.c | 25 -
1 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/src/viewer/text/view.c b/src/viewer/text/view.c
index 887f301..a0ebefa 100644
--- a/src/viewer/text/view.c
+++ b/src/viewer/text/view.c
@@ -201,8 +201,13 @@ move_link_prev_line(struct session *ses, struct
document_view *doc_view)
if (!last) last = link;
else if (link-points[0].x last-points[0].x) last =
link;
}
- if (last)
- return move_cursor_rel(ses, doc_view, last-points[0].x
- x1, last-points[0].y - y1);
+ if (last) {
+ enum frame_event_status status = move_cursor_rel(ses,
doc_view,
+ last-points[0].x - x1, last-points[0].y - y1);
+
+ ses-navigate_mode = NAVIGATE_LINKWISE;
+ return status;
+ }
}
return FRAME_EVENT_OK;
}
@@ -245,8 +250,13 @@ move_link_next_line(struct session *ses, struct
document_view *doc_view)
if (!last) last = link;
else if (link-points[0].x last-points[0].x) last =
link;
}
- if (last)
- return move_cursor_rel(ses, doc_view, last-points[0].x
- x1, last-points[0].y - y1);
+ if (last) {
+ enum frame_event_status status = move_cursor_rel(ses,
doc_view,
+ last-points[0].x - x1, last-points[0].y - y1);
+
+ ses-navigate_mode = NAVIGATE_LINKWISE;
+ return status;
+ }
}
return FRAME_EVENT_OK;
}
@@ -708,7 +718,12 @@ move_link_vertical(struct session *ses, struct
document_view *doc_view, int dir_
if (!link) continue;
for (; link = document-lines2[y]; link++) {
if (link-points[0].y == y) {
- return move_cursor_rel(ses, doc_view, 0, y -
y1);
+ enum frame_event_status status =
move_cursor_rel(ses,
+ doc_view, 0, y - y1);
+
+ if (vs-current_link != -1)
+ ses-navigate_mode = NAVIGATE_LINKWISE;
+ return status;
}
}
}
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] Sponsor development of the key motion.
Woohoo. it works properly now. You can post this into the elinks list and I
will ask them to include it.
Thanks again.
On Tue, Aug 14, 2007 at 11:48:42PM +0530, Ligesh wrote:
This bug has to be fixed properly, otherwise, this is really interfering
with the default elinks behaviour. If we can fix this cursor geometry issue,
I will surely ask them to include it in the mainstream.
Thanks a lot.
On Tue, Aug 14, 2007 at 07:59:14PM +0200, Witold Filipczyk wrote:
Here is the patch.
Kalle, Jonas, could apply them (key motion patches) to the mainstream
ELinks?
move-link-down-line, move-link-prev-line, etc.:
Change mode to NAVIGATE_LINKWISE to preserve the link position when
going back.
---
commit 14b37d0362f9963cb2803d08d2c3e6e84574cdbe
tree 062545598ae45bf519f7e825b0302542061bbf34
parent 2045574edca170a47b1e9f1e05cd210bdae8a49a
author Witold Filipczyk [EMAIL PROTECTED] Tue, 14 Aug 2007 19:56:02 +0200
committer Witold Filipczyk [EMAIL PROTECTED] Tue, 14 Aug 2007 19:56:02
+0200
src/viewer/text/view.c | 25 -
1 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/src/viewer/text/view.c b/src/viewer/text/view.c
index 887f301..a0ebefa 100644
--- a/src/viewer/text/view.c
+++ b/src/viewer/text/view.c
@@ -201,8 +201,13 @@ move_link_prev_line(struct session *ses, struct
document_view *doc_view)
if (!last) last = link;
else if (link-points[0].x last-points[0].x) last =
link;
}
- if (last)
- return move_cursor_rel(ses, doc_view, last-points[0].x
- x1, last-points[0].y - y1);
+ if (last) {
+ enum frame_event_status status = move_cursor_rel(ses,
doc_view,
+ last-points[0].x - x1, last-points[0].y - y1);
+
+ ses-navigate_mode = NAVIGATE_LINKWISE;
+ return status;
+ }
}
return FRAME_EVENT_OK;
}
@@ -245,8 +250,13 @@ move_link_next_line(struct session *ses, struct
document_view *doc_view)
if (!last) last = link;
else if (link-points[0].x last-points[0].x) last =
link;
}
- if (last)
- return move_cursor_rel(ses, doc_view, last-points[0].x
- x1, last-points[0].y - y1);
+ if (last) {
+ enum frame_event_status status = move_cursor_rel(ses,
doc_view,
+ last-points[0].x - x1, last-points[0].y - y1);
+
+ ses-navigate_mode = NAVIGATE_LINKWISE;
+ return status;
+ }
}
return FRAME_EVENT_OK;
}
@@ -708,7 +718,12 @@ move_link_vertical(struct session *ses, struct
document_view *doc_view, int dir_
if (!link) continue;
for (; link = document-lines2[y]; link++) {
if (link-points[0].y == y) {
- return move_cursor_rel(ses, doc_view, 0, y -
y1);
+ enum frame_event_status status =
move_cursor_rel(ses,
+ doc_view, 0, y - y1);
+
+ if (vs-current_link != -1)
+ ses-navigate_mode = NAVIGATE_LINKWISE;
+ return status;
}
}
}
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev
___
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] Sponsor development of the key motion.
Sorry, I didn't realize that we were in the elinks mailing list. Anyway, it seems, the patch now works fine, and it doesn't modify elinks' earlier behaviour either, making the new key motion a really non-intrusive feature. I would like to know if the maintainers can comment on this. Also, it would be nice if you have a paypal account, to which someone can donate if they want to. Thanks a lot for the great software. On Tue, Aug 14, 2007 at 11:58:20PM +0530, Ligesh wrote: Woohoo. it works properly now. You can post this into the elinks list and I will ask them to include it. Thanks again. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] disable mouse (was: Sponsor development of the key motion.)
On Fri, Aug 10, 2007 at 10:11:14AM +0200, Jonas Fonseca wrote: Kalle Olavi Niemitalo [EMAIL PROTECTED] wrote Fri, Aug 10, 2007: Ligesh [EMAIL PROTECTED] writes: Also I want to know if I can disable the need to press shift key while copy/pasting from/to elinks. It appears the toggle-mouse action (not bound to a key by default) would stop ELinks from requesting mouse events. Or configure ELinks not to support mouse input with --disable-mouse. Yes! This is what I really wanted. I do not use mouse, other than for copy pasting in xterm. I didn't actually know that Elinks had real mouse support. Thanks. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] Sponsor development of the key motion.
There is one problem left, and it is that the cursor doesn't change position when you move from one page to another. The cursor should ideally be at the top or it should be in the location where you left it, but with the new patch, the cursor just stays at the geometrical position. Btw, I would like to know how I can contribute to the elinks project. Witold has agreed that I can split my donation into $75-$75, with the latter going towards elinks dev. Thanks. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] Sponsor development of the key motion.
Also, I lead developer, can you please open an account with paypal, so that if in the future, someone like me feels generous, he can donate. You can use to pay for hosting or whatever. I think it is a standard practice in open source. Please create a paypal account and send me a request. Thanks. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
[elinks-dev] Sponsor development of the key motion.
Hi, I had requested a specific 2 dimensional keyboard motion some time back. It was like this: the up/down arrows will move straight up and down, and will stop on a line that contains a link anywhere on that line. The up/down arrows will not move right/left at all. They will just stop on a line which contains the link anywhere, even if the exact location of the cursor does not have a link. The right-left would of course move along the links on a single line. The right-left would also wrap-around, so that after the farthest right link, the right button will wrap to the left most link on the left line. But up/down moves only straight. I would like to know if I can sponsor this feature. Also I want to know if I can disable the need to press shift key while copy/pasting from/to elinks. Thanks a lot in advance. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
[elinks-dev] Re: Feature Requests
On Fri, Jun 23, 2006 at 05:06:09AM +, Miciah Dashiel Butler Masters wrote: On Tue, Jun 20, 2006 at 11:52:35AM +0530, Ligesh wrote: On Tue, Jun 20, 2006 at 06:03:21AM +, Miciah Dashiel Butler Masters wrote: So I am talking about simple editing, for instance, in the input URL box. The general editing for simple data everywhere; filling in forms etc. I'll see about adding a few actions tomorrow. I am sure you know it, but the code is in the inpfield.c file. There is a switch case, and you need to add one a case ACT_EDIT_KILL_WORD above the ACT_EDIT_KILL_TO_BOL. There is a lot of code duplication between the general UI widgets and document form controls, which I would like to clean up, but I eventually just wrote a patch for the functionality presently under discussion: http://pasky.or.cz/gitweb.cgi?p=elinks.git;a=commit;h=29ffe71bc1b0ed6322105c1ebcb565f6793ea81e Thanks a lot. I will get the latest code. Btw, is there any chance for the movement system as I had explained. :-) Thanks a lot. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
[elinks-dev] Re: Feature Requests
On Sat, Jun 24, 2006 at 06:31:47AM +, Miciah Dashiel Butler Masters wrote: On Sat, Jun 24, 2006 at 10:48:59AM +0530, Ligesh wrote: On Fri, Jun 23, 2006 at 08:47:59PM +, Miciah Dashiel Butler Masters wrote: This should be easy enough. Should I just use isalnum instead of isspace? Next question: Should this be configurable? We already have too many options. Yeah true. No. It is not configurable. They are separate motions altogether. And the kill-word-back actually means that it will do till a metachar. What do you mean? Are you asserting that because it has 'word' in the name, it should stop at non-alphanumeric characters? I can tell you how it is in bash. Bash has two actions. backward-kill-word: This does what I had proposed. Kill a previous word till it reaches a metachar (non-alphanumeric). unix-word-rubout: This deletes the previous characters till it encounters a space. So I think in kill-word-back, it should be alnum. *If YOU want* you can implement a 'unix-word-rubout' too, but that's not really needed. I personally dislike the concept of 'unix-word-rubout'. Especially when you type in a url, you would want to remove the last directory, and not the entire string. So I presonally would prefer kill-word-back to use '!isalnum' rather than 'isspace'. So yes, just replacing isspace, with !isalnum should fix it. Thanks a lot. ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
