[elm-discuss] Re: Demo project that fails Google Closure Advanced Optimizations

2016-10-20 Thread Robin Heggelund Hansen
If you get the chance, try to change the generated code from the elm 
compiler and change statements that performs a `'ctor' in obj` tests. 
Change them to `typeof obj.ctor === 'undefined'` or some such. There is one 
in the eqHelp function (called by `=`) and one in the toString function.

The reason this will fail with google closure is that the ctor property is 
renamed when used with advanced optimizations, and so 'ctor' checks will 
fail.

torsdag 20. oktober 2016 21.42.55 UTC+2 skrev OvermindDL1 følgende:
>
> I know it fails on our large Elm project at work, we have to run with 
> standard optimizations of the Google Closure compiler, but I did not 
> research in to far since generated code is not code that I control and I 
> needed to get things done.  If I get time I'll try to run it again and get 
> some data on it.
>
>
> On Thursday, October 20, 2016 at 11:16:16 AM UTC-6, Robin Heggelund Hansen 
> wrote:
>>
>> I was wondering if anyone had a project that fails to run properly when 
>> applied with the Advanced Optimizations of the Google Closure Compiler?
>> I want to figure out what the problems are so that I can submit a PRs to 
>> fix the problem.
>> Pretty sure I've figured out what the problems are, but I need to 
>> replicate my success on larger projects than the few test cases I've made.
>>
>

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[elm-discuss] Re: Demo project that fails Google Closure Advanced Optimizations

2016-10-20 Thread OvermindDL1
I know it fails on our large Elm project at work, we have to run with 
standard optimizations of the Google Closure compiler, but I did not 
research in to far since generated code is not code that I control and I 
needed to get things done.  If I get time I'll try to run it again and get 
some data on it.


On Thursday, October 20, 2016 at 11:16:16 AM UTC-6, Robin Heggelund Hansen 
wrote:
>
> I was wondering if anyone had a project that fails to run properly when 
> applied with the Advanced Optimizations of the Google Closure Compiler?
> I want to figure out what the problems are so that I can submit a PRs to 
> fix the problem.
> Pretty sure I've figured out what the problems are, but I need to 
> replicate my success on larger projects than the few test cases I've made.
>

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.