[elm-discuss] Re: Elm post: feedback requested

2016-11-29 Thread Richard Haven
I liked the iterative process. I even liked the recap at the end (I usually 
don't like chapter summaries).

I appreciate that you gave a warning against trying to optimize early and 
when to stop optimizing. Some might be tempted to create a helper function 
for the specific record to reduce the injected function to be the attribute 
name and the new value.

While Elm does allow one to omit a number of unit tests, it does not allow 
the omission of functional tests, and one must have those before one starts 
to refactor. Perhaps you can address this.

Cheers

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [elm-discuss] Re: Elm post: feedback requested

2016-11-29 Thread Wouter In t Velt
Op dinsdag 29 november 2016 10:25:50 UTC+1 schreef John Orford:
>
> Just a note - sometimes a little repetition is helpful when learning or 
> teaching... At least that's what I tell myself when I find I am repeating 
> myself :)
>

Fully agree! Hope I made that clear by adding the workflow paragraph (first 
repeat, then clean) at the end.
Changed the subtitle anyway to remove the suggestion that any repetition is 
bad..

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [elm-discuss] Re: Elm post: feedback requested

2016-11-29 Thread John Orford
Just a note - sometimes a little repetition is helpful when learning or
teaching... At least that's what I tell myself when I find I am repeating
myself :)

On Tue, 29 Nov 2016 at 10:13 Wouter In t Velt 
wrote:

> Thanks Max. I've taken out the somewhat repetitive paragraphs, to make the
> article itself also more compact and readable :)
>
> As for using Dict, the exercise basically shows how to extract functions
> by rolling your own List equivalent of Dict.update.
> Using Dict from the start would be less clear for the example.
> For collections where updating individual items is the dominant
> operations, I would agree that a Dict is more suitable.
> I have added a note about List vs Dict at the end.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Elm Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elm-discuss+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[elm-discuss] Re: Elm post: feedback requested

2016-11-29 Thread Wouter In t Velt
Thanks Max. I've taken out the somewhat repetitive paragraphs, to make the 
article itself also more compact and readable :)

As for using Dict, the exercise basically shows how to extract functions by 
rolling your own List equivalent of Dict.update.
Using Dict from the start would be less clear for the example. 
For collections where updating individual items is the dominant operations, 
I would agree that a Dict is more suitable.
I have added a note about List vs Dict at the end.

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[elm-discuss] Re: Elm post: feedback requested

2016-11-28 Thread Max Goldstein
The thing that stands out to me is that this post on removing repetition 
seems a little repetitive. The three sections starting with Spot the 
Pattern seem to have mostly the same information.

Also, you mention Dict.update -- maybe the best data structure here is not 
a list but a dictionary keyed on the id? Then you could update the item in 
(basically) constant time.

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.