Re: [O] Bug: Small error in [[info:org#The clock table]] [9.1.3 (9.1.3-10-gadfbfd-elpaplus @ /home/jorge/.emacs.d/elpa/org-plus-contrib-20171127/)]

2017-11-29 Thread Nicolas Goaziou
Hello,

Jorge Morais Neto  writes:

> The mentioned manual section says:
> `C-c C-c  or  C-c C-x C-u (`org-dblock-update')'
>  Update dynamic block at point.  The cursor needs to be in the
>  `#+BEGIN' line of the dynamic block.
>
> However, the docstring only says
> User command for updating dynamic blocks.
> Update the dynamic block at point.  With prefix ARG, update all dynamic
> blocks in the buffer.
>
> It does not say that the cursor must be in the #+BEGIN line.  And
> according to my one quick test, it does not need to.
>
> I verified this error also occurs in Master.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou



[O] Bug: Small error in [[info:org#The clock table]] [9.1.3 (9.1.3-10-gadfbfd-elpaplus @ /home/jorge/.emacs.d/elpa/org-plus-contrib-20171127/)]

2017-11-29 Thread Jorge Morais Neto
The mentioned manual section says:
`C-c C-c  or  C-c C-x C-u (`org-dblock-update')'
 Update dynamic block at point.  The cursor needs to be in the
 `#+BEGIN' line of the dynamic block.

However, the docstring only says
User command for updating dynamic blocks.
Update the dynamic block at point.  With prefix ARG, update all dynamic
blocks in the buffer.

It does not say that the cursor must be in the #+BEGIN line.  And
according to my one quick test, it does not need to.

I verified this error also occurs in Master.

Regards

-- 
- I am Brazilian.  I hope my English is correct and I welcome feedback
- Please adopt free formats like PDF, ODF, Org, LaTeX, Opus, WebM and 7z
- Free (as in free speech) software for Android: https://f-droid.org/



Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-29 Thread Nicolas Goaziou
Hello,

Doro Rose  writes:

> Nicolas Goaziou  writes:
>
>> Hello,
>>
>> Doro Rose  writes:
>>
>>> In summary, yes I'm accessing user settings but in a rather
>>> noninvasive way. Unfortunately I can't think of a more elegant way to
>>> do this.
>>
>> Let's put it differently then. Isn't it the job of the user, who changed
>> their prompt, to configure properly "inf-haskell" library? I don't get
>> why it should be a task for "ob-haskell".
>>
>> This is a genuine question: I don't use Haskell at all.
>>
>> Regards,
>
> Well the "inf-haskell" library is fine as it is, i.e. the code sent to its 
> buffer
> is evaluated correctly in the corresponding buffer.
> The problem occurs when sending code  to that buffer via org-babel, since
> the interpreter output isn't parsed correctly in 
> `org-babel-comint-with-output`.
>
> As an org-babel user my expectation would be for that to just work out of the
> box. -> Without having to figure out that I need to set internal variables 
> defined in
> "inf-haskell" or that I need  to add `ansi-color-filter-apply` to
> `comint-preoutput-filter-functions`.

Fair enough. Could you provide a proper commit message and send the
patch again?

Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] make org-comment-dwim comment headings if on a heading

2017-11-29 Thread Nicolas Goaziou
Alex Branham  writes:

> Patch attached, thanks!

Applied. Thank you.

Regards,



Re: [O] [PATCH] Preserve point when calling org-capture in gnus virtual group

2017-11-29 Thread Nicolas Goaziou
Matt Lundin  writes:

> Thanks! And here is another patch to fix the same issue in temporary
> nnir search groups in gnus.

Applied. Thank you.

Regards,



Re: [O] How to log changes to orgmode files?

2017-11-29 Thread Kyle Meyer
Mirko Vukovic  writes:

> When I invoke ChangeLog, it is pre-populated with the file name only.
> There is no finer information about the location of the modification.  For
> instance, I would like to use the tree heading name or ID.
>
> Is there a standard way of logging changes?

If I understand correctly what you want, I think you can get it by
setting add-log-current-defun-function.  For example,

   (add-hook 'org-mode-hook
 (lambda ()
   (setq-local add-log-current-defun-function
   (lambda () (ignore-errors (org-get-heading t))

Untested, and you probably don't want to add an anonymous function to
org-mode-hook, but hopefully it helps.

-- 
Kyle



Re: [O] How to log changes to orgmode files?

2017-11-29 Thread Colin Baxter
Hello Mirko,
> Mirko Vukovic  writes:

> Hello, I am writing a report in org-mode (with pdf export). The
> file is under git version control. I would like to log changes I
> make to the document.

> When I invoke ChangeLog, it is pre-populated with the file name
> only. There is no finer information about the location of the
> modification. For instance, I would like to use the tree heading
> name or ID.

> Is there a standard way of logging changes?

> Thanks,

The LaTeX packages "gitinfo2" and "mVersion" might be what you want. Beware
that gitinfo2 sometimes conflicts with the options "usenames" and
"dvipsnames" for packages "color" and "xcolor". 

Best wishes.

-- 
Colin Baxter
m43...@yandex.com
-
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8
-
The sole cause of all human misery is the inability of people to sit
quietly in their rooms.  Blaise Pascal, 1670



Re: [O] [PATCH] Preserve point when calling org-capture in gnus virtual group

2017-11-29 Thread Matt Lundin
Nicolas Goaziou  writes:

> Matt Lundin  writes:
>
>> When calling org-capture in gnus virtual groups (for instance, groups
>> created through searches), I found that the region captured was
>> different than the region I had selected. This is because one of the
>> functions called in org-gnus-store-link moves the point to the end of
>> the buffer. The attached patch fixes the issue.
>
> Applied. Thank you.

Thanks! And here is another patch to fix the same issue in temporary
nnir search groups in gnus.

Best,
Matt

>From 87299d4646b5c3895332e63b5c0419e8a1b7d027 Mon Sep 17 00:00:00 2001
From: Matt Lundin 
Date: Wed, 29 Nov 2017 12:37:07 -0600
Subject: [PATCH] Preserve point when storing link in Gnus nnir groups

* lisp/org-gnus.el: (org-gnus-store-link) This fixes a similar issue
  as commit 84b329516efbe92ea5385f2aa2ad2779ab44b427, but for
  nnir search groups in gnus.
---
 lisp/org-gnus.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index 27a968f75..f0f5ca2fa 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -123,7 +123,8 @@ If `org-store-link' was called with a prefix arg the meaning of
 		(save-excursion
 		  (car (nnvirtual-map-article (gnus-summary-article-number)
 	   (`(nnir . ,_)
-		(nnir-article-group (gnus-summary-article-number)))
+		(save-excursion
+		  (nnir-article-group (gnus-summary-article-number
 	   (_ gnus-newsgroup-name)))
 	(header (with-current-buffer gnus-summary-buffer
 		  (gnus-summary-article-header)))
-- 
2.15.0



[O] What about a space when inserting a src-block?

2017-11-29 Thread Marco Wahl
Hi!

My impression is that one always types a blank after calling
`org-insert-structure-template' {C-c C-x w s} for creating a src block.

Suggestion: Realize the insert of a space after "#+begin_src" in
`org-insert-structure-template'.

WDYT?


Best regards,
 Marco





Re: [O] Results with #+begin_example/#+end_example don't get overwritten

2017-11-29 Thread Nicolas Goaziou
Hello,

Kaushal Modi  writes:

> No, I wasn't suggesting a use case where someone writes the #+RESULTS:
> contents manually.
>
> Here's what can happen though:
>
> A user could have this to begin with:

[...]

> Then for whatever reason, they choose to delete the RESULTS manually.. and
> the blank line after that too!

IMO, this is still a manual operation on RESULTS keyword.

> That's why I proposed earlier to wrap the Org generated results in
> something like #+begin_results/#+end_results.

I think this would add too much cruft in the document.

> The current behavior is risky, or at least should somehow be
> documented.

Documentation can certainly help. I wouldn't qualify it as risky
however. In any case, it not riskier than the many other ways to fumble
in Org.

Regards,

-- 
Nicolas Goaziou



[O] How to log changes to orgmode files?

2017-11-29 Thread Mirko Vukovic
Hello,

I am writing a report in org-mode (with pdf export).  The file is under git
version control.  I would like to log changes I make to the document.

When I invoke ChangeLog, it is pre-populated with the file name only.
There is no finer information about the location of the modification.  For
instance, I would like to use the tree heading name or ID.

Is there a standard way of logging changes?

Thanks,

Mirko


Re: [O] [PATCH] Preserve point when calling org-capture in gnus virtual group

2017-11-29 Thread Nicolas Goaziou
Hello,

Matt Lundin  writes:

> When calling org-capture in gnus virtual groups (for instance, groups
> created through searches), I found that the region captured was
> different than the region I had selected. This is because one of the
> functions called in org-gnus-store-link moves the point to the end of
> the buffer. The attached patch fixes the issue.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] C++ code block not linked [SOLVED]

2017-11-29 Thread Roger Mason
Hello,

Nick Dokos  writes:

> All very good info, but why did the OP not have a g++?  Using a
> non-linux operating system? Using a non-GNU tool chain? Inquiring
> minds want to know...

Running on FreeBSD 10.3, which uses clang/clang++ by default.  That
said, I _do_ have gcc 5.4.0 installed and accessible as gcc/g++, so I
don't know why it did not work.

Cheers,
Roger



Re: [O] [PATCH] make org-comment-dwim comment headings if on a heading

2017-11-29 Thread Alex Branham

On Wed 29 Nov 2017 at 13:46, Nicolas Goaziou  wrote:
> I also added TINYCHANGE at the end of the commit message. Please
> consider signing FSF papers if you haven't done so. If you did, let me
> know it so I can update our registry.

I've signed the papers. 

>
> Would you mind writing an entry in ORG-NEWS? It could go in
> "Miscellaneous" section.

Patch attached, thanks!

>
> Thank you!
>
> Regards,

>From 1d62a9c612c97dd35929a40c49d86a5812a853e9 Mon Sep 17 00:00:00 2001
From: Alex Branham 
Date: Wed, 29 Nov 2017 09:21:58 -0600
Subject: [PATCH] ORG-NEWS: Document new behavior of org-comment-dwim on
 headings

---
 etc/ORG-NEWS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index b41804edb..402fc8e52 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -188,6 +188,7 @@ file links, which lead to them being broken in web browsers. Now both
 of these exporters will properly export to =irc:= links, which will
 open properly in irc clients from web browsers.
 
+*** ~org-comment-dwim~ (bound to =M-;=) now comments headings, if point is on a heading
 * Version 9.1
 
 ** Incompatible changes
-- 
2.15.0



[O] [PATCH] Preserve point when calling org-capture in gnus virtual group

2017-11-29 Thread Matt Lundin
When calling org-capture in gnus virtual groups (for instance, groups
created through searches), I found that the region captured was
different than the region I had selected. This is because one of the
functions called in org-gnus-store-link moves the point to the end of
the buffer. The attached patch fixes the issue.

Thanks,
Matt

>From 7f41fbb98c7cbaa09af8f78b06a57587e4f583a1 Mon Sep 17 00:00:00 2001
From: Matt Lundin 
Date: Wed, 29 Nov 2017 09:17:55 -0600
Subject: [PATCH] Preserve position of point in gnus virtual group

* lisp/org-gnus.el: (org-gnus-store-link) Add a save-excursion to
  protect the position of point. Otherwise, when calling org-capture
  in an article with a virtual group, the point is moved and the
  region captured is incorrect.
---
 lisp/org-gnus.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index 687bc08b1..27a968f75 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -120,7 +120,8 @@ If `org-store-link' was called with a prefix arg the meaning of
  (let* ((group
 	 (pcase (gnus-find-method-for-group gnus-newsgroup-name)
 	   (`(nnvirtual . ,_)
-		(car (nnvirtual-map-article (gnus-summary-article-number
+		(save-excursion
+		  (car (nnvirtual-map-article (gnus-summary-article-number)
 	   (`(nnir . ,_)
 		(nnir-article-group (gnus-summary-article-number)))
 	   (_ gnus-newsgroup-name)))
-- 
2.15.0



Re: [O] Bug: Template Expansion with prompt-specific history [9.1.2 (9.1.2-37-g3f8d67-elpa @ /Users/ke/.emacs.d/elpa/org-20171113/)]

2017-11-29 Thread Nicolas Goaziou
Hello,

Karl Eichwalder  writes:

> Template expansion no longer works as documented:
>
>  %^{PROMPT}  prompt the user for a string and replace this sequence with 
> it.
>  You may specify a default value and a completion table with
>  %^{prompt|default|completion2|completion3...}.
>  The arrow keys access a prompt-specific history.
>
> After the last update, the prompt-specific history is gone for me.
> Unfortunately, I di not remember which org version I used before the
> update.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] make org-comment-dwim comment headings if on a heading

2017-11-29 Thread Nicolas Goaziou
Hello,

Alex Branham  writes:

> I've attached the updated patch (with a test), but the test fails
> because calling M-x comment-dwim in an org buffer on a heading results
> in the old behavior of comment-dwim rather than the new behavior.
> Calling M-x org-comment-dwim directly works as I expect (and M-; works
> like this too). Do you have any idea what might be going on? I thought
> they would behave the same since comment-dwim is mapped to
> org-comment-dwim, but that doesn't seem to be the case...

Mapping means `org-comment-dwim' binding replaces `comment-dwim'
binding, which doesn't mean both functions are mapped to each other.

The tests in "test-org.el" were broken: they tested `comment-dwim'
instead of `org-comment-dwim'. I fixed the tests, then applied your
patch.

I also added TINYCHANGE at the end of the commit message. Please
consider signing FSF papers if you haven't done so. If you did, let me
know it so I can update our registry.

Would you mind writing an entry in ORG-NEWS? It could go in
"Miscellaneous" section.

Thank you!

Regards,

-- 
Nicolas Goaziou