Re: [O] org master: make fails

2018-06-02 Thread Nicolas Goaziou
Hello,

Julius Dittmar  writes:

> GNU Emacs 24.3.1 in one instance, the other not older than that (can't
> check the details right now).

I think upgrading Emacs to at least 24.4 should solve the issue.

Regards,

-- 
Nicolas Goaziou



Re: [O] [BUG] org-insert-structure-template on region selected text will delete some characters

2018-06-02 Thread Nicolas Goaziou
Hello,

stardiviner  writes:

> For example:
>
> Region select on:
>
> ENTRYPOINT ["/usr/sbin/nginx"]
>
> When I press =[C-c C-,]= on this region, the region content will be wrapped 
> with src block,
> but it deleted the last "]".
>
> This is a bug I think.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: Args out of range error in HTML export [9.1.13 (9.1.13-elpa @ /home/neil/.emacs.d/elpa/org-20180514/)]

2018-06-02 Thread Nicolas Goaziou
Hello,

Neil Jerram  writes:

> With this Org source:
>
> #+BEGIN_SRC sh
> {
> cat <   failsafeInboundHostPorts:
> EOF
> }
> #+END_SRC
>
> With `C-c C-e h h', to export that as HTML, I get:
>
> Debugger entered--Lisp error: (args-out-of-range # 0 1)
>   parse-partial-sexp(1 0)
>   syntax-ppss(0)
>   sh--inside-noncommand-expression(0)
>   sh--inside-noncommand-expression(10)
>   sh-font-lock-open-heredoc(10 "EOF" 16)
>   sh-syntax-propertize-function(1 50)
>   syntax-propertize(50)
>   font-lock-fontify-syntactically-region(1 50 nil)
>   font-lock-default-fontify-region(1 50 nil)
>   font-lock-fontify-region(1 50 nil)
>   font-lock-default-fontify-buffer()

This issue doesn't seem related to Org. You can try inserting the code
above in an sh-mode buffer and observe that Emacs has trouble fontifying
the buffer properly.

As you noticed, inserting a space or a newline at the beginning of the
buffer seems to help.

Regards,

-- 
Nicolas Goaziou



Re: [O] org-detangle seems broken

2018-06-02 Thread Nicolas Goaziou
Hello,

Frederick Giasson  writes:

> It appears that org-detangle is broken. I am using spacemacs, but even with
> a vanilla Emacs (emacs -Q) it appears to be broken.
>
> When I tangle a file with =:comments link= every things works as expected
> and the comments are added in the tangled file.
>
> When I just detangle that tangled file, everything get detangled as
> expected.
>
> If I change one or two lines, it normally works as expected.
>
> If I change more than 4 lines, I always get the error message "Not in a
> block file".
>
> Some debugging shows that the function =org-element-at-point= sometimes tag
> the element as =paragraph= instead of =src-block=, like if it doesn't know
> where it is... somehow.
>
> Does anybody use that function without experiencing this (apparent major)
> issue?

Could you provide an ECM demonstrating the issue?

Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] Add support for Babel with Eshell, (updated PATCH)

2018-06-02 Thread Nicolas Goaziou
Hello,

stardiviner  writes:

> Aha, Thanks, Nicolas, I almost forget this patch. That's great!

Speaking of which, there's an issue in
`org-babel-eshell-initiate-session'.

First, it uses (get-buffer (current-buffer)), which is equivalent to
(current-buffer). But, more importantly, it doesn't do anything with it?
So what is the point of the `progn' in that function?

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] Add new keyword :coding for #+include directive

2018-06-02 Thread Nicolas Goaziou
Hello,

pierre.techouey...@free.fr (Pierre Téchoueyres) writes:

> Hello Nicolas,
> I'm sorry for the delay, this problem drove me crazy for a few days.
> So I started again from the beginning and, of course, I am now unable to
> replicate my original test case.
> So, I think you could delete the
> 0001-Manage-the-encoding-of-files-with-include-.patch patch.
> I am really sorry for the inconvenience.

No problem. It also drove me crazy.

> I hope we can go ahead with the other patch to add a ":coding" keyword
> to the include directive.
>
> To resume the goal:
> The include keyword works well with encodings like cp850 if, and only
> if, there are some indications of the encoding in the file (as local
> variables for example). But sometimes, there is no such information and
> you can not modify the file (for various reasons. ex: the file is
> generated automatically).

I applied the first patch in "next" branch, with a slight refactoring.

Thank you.

Regards,

-- 
Nicolas Goaziou0x80A93738