Re: [PATCH] org.el: Use `call-process' to launch external viewers (was: Re: [BUG] org-open-file immediately termininates when calling xdg-open that calls emacsclient)

2022-07-23 Thread Ihor Radchenko
Max Nikulin  writes:

>> I have reported this to Emacs. The more precise steps are in
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55672
>
> As expected, nobody wishes to dig into obscure X11 issue.
>
> You may try the attached patch. I do not consider it as unambiguous 
> improvement since almost all errors are swallowed due to requirement to 
> interpret viewer command using shell. The same approach settled on 
> `browse-url' after several fixes, but there at least wrong executable 
> name may be reported.

For reference, I am no longer able to reproduce the problem using the
provided recipe. Since the report, I have upgraded my system libraries
and Emacs (to the latest commit on master).

Now, I am not really sure if this patch is going to be an improvement.
Unless you have objections, I am marking the patch cancelled - I no
longer see any clear benefit of the patch.

Cancelled.

Best,
Ihor





Re: [BUG] Avoid folding drawers using `org-clock-goto'

2022-07-23 Thread Tor Kringeland
Ihor Radchenko  writes:

> Could you please elaborate why you prefer not folding drawers in
> `org-clock-goto'?

If I already unfolded a drawer (for example with notes), then I want to
keep it open, at least as long as the heading itself is unfolded.  For
example if I have

#+begin_example
* some text
  :LOGBOOK:
  CLOCK: [2022-07-24 Sun 03:33]
  - Note taken on [2022-07-24 Sun 03:33] \\
a note
  :END:
#+end_example

and I jump back to this (unfolded) heading, I want to have the same
overview.  Currently `org-clock-goto' folds the drawer, so instead I get

#+begin_example
* some text
  :LOGBOOK:...
#+end_example

which is unexpected.  If someone wants this behavior I think it'd be
more prudent to add it to `org-clock-goto-hook'.


Re: [BUG] Avoid folding drawers using `org-clock-goto'

2022-07-23 Thread Ihor Radchenko
Tor Kringeland  writes:

> When calling `org-clock-goto' the drawers of the heading it goes to are
> closed, if they're open.

It may or may not be a bug depending on your preferences.
Though we indeed changed this default as a side effect of other change.
See https://orgmode.org/list/87tu9tpnbt.fsf@localhost

Could you please elaborate why you prefer not folding drawers in
`org-clock-goto'?

Best,
Ihor



[PROPOSED-PATCH] ox-publish: fix typo in function name

2022-07-23 Thread Paul Eggert
* lisp/ox-publish.el (org-publish-cache-mtime-of-src):
Rename from org-publish-cache-ctime-of-src, since it
has always cached mtime not ctime.  All uses changed.
---
 lisp/ox-publish.el | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/lisp/ox-publish.el b/lisp/ox-publish.el
index 5c6ad94c9..e3d67b695 100644
--- a/lisp/ox-publish.el
+++ b/lisp/ox-publish.el
@@ -379,7 +379,7 @@ still decide about that independently."
   "Update publishing timestamp for file FILENAME.
 If there is no timestamp, create one."
   (let ((key (org-publish-timestamp-filename filename pub-dir pub-func))
-   (stamp (org-publish-cache-ctime-of-src filename)))
+   (stamp (org-publish-cache-mtime-of-src filename)))
 (org-publish-cache-set key stamp)))
 
 (defun org-publish-remove-all-timestamps ()
@@ -1287,7 +1287,7 @@ the file including them will be republished as well."
   (let* ((key (org-publish-timestamp-filename filename pub-dir pub-func))
 (pstamp (org-publish-cache-get key))
 (org-inhibit-startup t)
-included-files-ctime)
+included-files-mtime)
 (when (equal (file-name-extension filename) "org")
   (let ((visiting (find-buffer-visiting filename))
(buf (find-file-noselect filename))
@@ -1308,15 +1308,15 @@ the file including them will be republished as well."
   (substring m 0 (match-beginning 0))
 m)
  (when filename
-   (push (org-publish-cache-ctime-of-src
+   (push (org-publish-cache-mtime-of-src
   (expand-file-name filename))
- included-files-ctime)))
+ included-files-mtime)))
  (unless visiting (kill-buffer buf)
 (or (null pstamp)
-   (let ((ctime (org-publish-cache-ctime-of-src filename)))
- (or (time-less-p pstamp ctime)
- (cl-some (lambda (ct) (time-less-p ctime ct))
-  included-files-ctime))
+   (let ((mtime (org-publish-cache-mtime-of-src filename)))
+ (or (time-less-p pstamp mtime)
+ (cl-some (lambda (ct) (time-less-p mtime ct))
+  included-files-mtime))
 
 (defun org-publish-cache-set-file-property
   (filename property value  project-name)
@@ -1361,8 +1361,8 @@ does not exist."
 (error "`org-publish-cache-set' called, but no cache present"))
   (puthash key value org-publish-cache))
 
-(defun org-publish-cache-ctime-of-src (file)
-  "Get the ctime of FILE as an integer."
+(defun org-publish-cache-mtime-of-src (file)
+  "Get the mtime of FILE as an integer."
   (let ((attr (file-attributes
   (expand-file-name (or (file-symlink-p file) file)
 (file-name-directory file)
-- 
2.37.1




[BUG] Avoid folding drawers using `org-clock-goto'

2022-07-23 Thread Tor Kringeland
When calling `org-clock-goto' the drawers of the heading it goes to are
closed, if they're open.


Re: [PATCH] oc-csl: Add support for sub-bibliographies

2022-07-23 Thread András Simonyi
Dear All,

On Sat, 23 Jul 2022 at 05:59, Ihor Radchenko  wrote:
> Could you please create a dedicated subsection under "15 Citation> handling" 
> instead of documenting PRINT_BIBLIOGRAPHY together with export
> processors? The section should contain a general overview of what
> PRINT_BIBLIOGRAPHY does and that it can appear multiple times. Then,
> further sub-sub-section will detail on CSL and LaTeX-based processors.

Dear Ihor, thanks a lot for your comments, I've attached a new version
in which I tried to implement your suggestions.

best wishes,
András
From d77255421e05f8e1f090e89b17334aed0bdf4fe4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A1s=20Simonyi?= 
Date: Wed, 20 Jul 2022 23:54:32 +0200
Subject: [PATCH] * doc/org-manual.org: Document "PRINT_BIBLIOGRAPHY" options

---
 doc/org-manual.org | 56 +-
 1 file changed, 55 insertions(+), 1 deletion(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index 26d18f533..e45acc0f0 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -16810,11 +16810,65 @@ conformant to the Harvard style and the specification of the
 Wolkers-Kluwer publisher; since it relies on the ~bibtex~ processor of
 your LaTeX installation, it won't export to anything but PDF.
 
+** Bibliography printing 
+
 The =PRINT_BIBLIOGRAPHY= keyword specifies where the bibliography
-should print.
+should print (note the colon):
 
 : #+print_bibliography:
 
+A document may contain more than one =PRINT_BIBLIOGRAPHY= keywords,
+and the keyword can be used with or without additional options.
+Options can be used, for example, to print only entries that belong to
+a certain category or control formatting.  The set of supported
+=PRINT_BIBLIOGRAPHY= options and their interpretation varies between
+the different citation export processors, and several of them do not
+support passing options at all.
+
+*** Bibliography options
+
+The "biblatex" and "csl" export processors support bibliography
+options through a property list attached to the =PRINT_BIBLIOGRAPHY=
+keyword.  For example,
+
+: #+print_bibliography: :type book :keyword algebra
+
+Values including spaces must be surrounded with double quotes.  If you
+need to use a key multiple times, you can separate its values with
+commas, but without any space in-between:
+
+: #+print_bibliography: :keyword algebra,logic :title "Primary Sources"
+
+The "biblatex" export processor accepts all options supported by
+BibLaTeX's ~\printbibliography~ command, while the "csl" processor
+accepts the following ones:
+
+- =:keyword = :: Print only entries whose
+  keyword field contains all given keywords.
+
+- =:notkeyword = :: Print only entries whose
+  keyword field does not contain any of the given keywords.
+
+- =:type = :: Print only entries whose type is
+  ==.  Entry type is the BibTeX/BibLaTeX entry type if this
+  information is available (the entry was read from a BibTeX/BibLaTeX
+  bibliography) and the CSL entry type otherwise.
+
+- =:nottype = :: Print only entries whose
+  type is not among the given entry types.  Entry type is determined
+  as in the case of =:type=.
+
+- =:csltype = :: Print only entries whose CSL entry type
+  (possibly based on a conversion from BibTeX/BibLaTeX to CSL) is
+  ==.
+
+- =:notcsltype = :: Print only entries whose
+  CSL entry type (possibly based on a conversion from BibTeX/BibLaTeX
+  to CSL) is not among the listed entry types.
+
+- =:filter = :: Print only entries for which the given
+  Emacs Lisp predicate returns a non-~nil~ value.
+
 * Working with Source Code
 :PROPERTIES:
 :DESCRIPTION: Export, evaluate, and tangle code blocks.
-- 
2.25.1



Improvements in the default LaTeX preamble (was: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists)

2022-07-23 Thread Juan Manuel Macías
Max Nikulin writes:

> My vote is to configure babel by default if it is possible to provide
> default preamble that allows reasonable quality of PDF for simple Org
> documents with no explicit configuration.
>
> Ideally, the following should be possible out of the box. When no
> advanced features are involved, user should be able to just export
> document to e.g. having printed version of their notes during a
> meeting, to send a summary to the boss. etc. It should be possible for
> users completely ignorant in respect to LaTeX.
>
> Likely language is not enough and e.g. paper size should be guessed
> (LC_PAPER?) as well.
>
> If a document require careful tuning then a couple of extra lines in
> the org file or a couple of additional custom variables in the init
> file should not be a problem.

I think that my position, after all these discussions here and in other
threads, needs a couple of clarifications:

- I am in favor of Org producing a consistent "standard" preamble for
  LaTeX out-of-the-box, so that users get a technically optimal PDF
  without messing with LaTeX code. This would include not only issues
  related to document languages (babel and polyglossia) but also fonts
  (especially XelaTeX and LuaLaTeX support), page layout (with geometry
  package), publishing support and some other things that can be
  proposed here. In this regard, I have changed the subject of this
  thread, if that's okay with you.

- I can agree that all of the above is by default. But it seems
  essential to me that there is at least the possibility of giving all
  that a nil value at a global level, for users who need more control
  and want to write (La)TeX code or want to load the entire preamble
  from an external document (a .tex file or a .sty file) . Which is not
  incompatible with document-level control and fine-tuning (*only* if
  the above is enabled).

Best regards,

Juan Manuel 




Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Juan Manuel Macías
Hi Ihor and Kai,

Ihor Radchenko writes:

> Hmm. You are actually right.
> Juan, can you please take a look. It looks like you missed
> "org-latex--format-spec" in the patch. It should use the new
> org-latex-language-alist variable instead.

Attached a new patch to fix (I hope) the org-latex-language-alist issue
in org-latex--format-spec.

Best regards,

Juan Manuel 

>From 95ce88336f6d2106968250379767ce2fe690fe2c Mon Sep 17 00:00:00 2001
From: Juan Manuel Macias 
Date: Sat, 23 Jul 2022 17:42:50 +0200
Subject: [PATCH] lisp/ox-latex.el: Fix obsolete variables for babel and
 polyglossia

* (org-latex--format-spec): Use the new variable `org-latex-language-alist'
---
 lisp/ox-latex.el | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index 6cd751409..ee059d5ce 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -1860,10 +1860,12 @@ INFO is a plist used as a communication channel."
 (defun org-latex--format-spec (info)
   "Create a format-spec for document meta-data.
 INFO is a plist used as a communication channel."
-  (let ((language (let ((lang (plist-get info :language)))
-		(or (cdr (assoc-string lang org-latex-babel-language-alist t))
-			(nth 1 (assoc-string lang org-latex-polyglossia-language-alist t))
-			lang
+  (let ((language (let* ((lang (plist-get info :language))
+		 (l (assoc lang org-latex-language-alist)))
+(cond ((and (consp l) (= (length l) 4))
+	   (nth 2 (assoc-string lang org-latex-language-alist t)))
+	  ((and (consp l) (< (length l) 4))
+	   (nth 1 (assoc-string lang org-latex-language-alist t)))
 `((?a . ,(org-export-data (plist-get info :author) info))
   (?t . ,(org-export-data (plist-get info :title) info))
   (?s . ,(org-export-data (plist-get info :subtitle) info))
-- 
2.37.1



Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Max Nikulin

On 23/07/2022 20:06, Ihor Radchenko wrote:

Max Nikulin writes:


If it still fails, could you try isolating whether it's a specific
`should' clause which is the problem, if it fails with any of them?


It is `map-do' that causes the problem. Maybe earlier implementation in
Emacs-26 has some peculiarities. It is the version available from the
system repository for Ubuntu-20.04 LTS focal.


Tests do not fail on my side using Emacs 26.3


It is strange. I tried the latest 2 patches applied on the top of

127e7fee4 2022-07-23 22:16:54 +0800 Ihor Radchenko: ox-latex: Keep 
obsolete variable values removed in 97cfb959d


and I got the same failure as a week ago. Maybe I will try to debug 
`map-do' tomorrow. Previous time my impression was that map-do was 
completely broken. I never used it before, but I assumed that it is used 
in the patch in a proper way. I do not expect that the cause is minimal 
testing environment in a LXC container (e.g. missing XDG directories).





Re: Recent folding issues

2022-07-23 Thread Jack Kamm
Ihor Radchenko  writes:

> Thanks for another detailed report!
> Fixed on main via 39005dc09.
>
> Let me know if you notice any other inconsistencies.

Thanks very much Ihor! Much appreciated :)

I'll let you know if I notice any other issues -- everything seems to be 
working well so far.

Best,
Jack



Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Max Nikulin

On 23/07/2022 12:01, Ihor Radchenko wrote:

Juan Manuel Macías writes:


Here is a new version of the patch, with the fixes added.


Thanks! Considering that the followup discussion deviated from the
substance of the patch towards related design issues,


I believed that the subject of discussion is how much values should be 
added to the alist in addition to babel and polyglossia options: 
fontenc, paper size, etc.


I hope, not so much third party packages use the changed variables, so 
committing the patch can hardly be harmful even in the case of 
additional change of the list format in future.





Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Max Nikulin

On 22/07/2022 21:07, Juan Manuel Macías wrote:


Forget this. On second thought, I think that the option you proposed
"#+LaTeX_Header: % \usepackage{babel}" is much better.

(I don't know where my head was and I didn't remember there was a
string-match, so your suggestion is the shortest way. However, the line
would have to be (with arguments):

#+LaTeX_Header: % \usepackage[something]{babel}

or

#+LaTeX_Header: % \usepackage[something]{polyglossia}

or modify the regexp in org-latex-guess-babel/polyglossia-language.


It was you who suggested

\documentclass[russian]{article}
\usepackage{babel}

At least at first glance it works in texlive-2019 (Ubuntu-20.04), so it 
is not a feature from the latest release. Unless commented out,
"#+latex_header: \usepackage{babel}" may be considered as an instruction 
to add value of #+language: to \documentclass option. I do not expect 
that adjusted regexp will cause a problem.



Anyway, whatever the choice, I would vote for Org not to load babel or
polyglossia by default, and for the default option of the custom
variable that handles that globally to be nil. For example, I'm in the
group of users that load babel using an external preamble (a .tex or a
.sty file or a 'latex-class'), and frankly I don't want to have to add a
new line to all my documents to prevent Org from reloading babel for me
and return an error on the compilation.


Doesn't the purpose of a custom variable is to set it to a suitable 
value in the init file making it unnecessary adding configuration to 
each org file? I did not expected that setting it to e.g. nil will be 
real burden for users like you.


My vote is to configure babel by default if it is possible to provide 
default preamble that allows reasonable quality of PDF for simple Org 
documents with no explicit configuration.


Ideally, the following should be possible out of the box. When no 
advanced features are involved, user should be able to just export 
document to e.g. having printed version of their notes during a meeting, 
to send a summary to the boss. etc. It should be possible for users 
completely ignorant in respect to LaTeX.


Likely language is not enough and e.g. paper size should be guessed 
(LC_PAPER?) as well.


If a document require careful tuning then a couple of extra lines in the 
org file or a couple of additional custom variables in the init file 
should not be a problem.





Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Juan Manuel Macías
Hi Kai,

Kai von Fintel writes:

> I do think that the code on lines 1864 and 1865 of =ox-latex.el=
> (https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el#n1864)
> should not use the old variable names. Since you’ve now defined the
> old variables in =org-compat.el=, my exports work, so I’m ok for the
> moment. But I don’t understand why they are still used in the
> definition of =org-latex--format-spec=.

I think you're right. My bad, sorry for that: I have not accounted for
`org-latex--format-spec' in my patch. I will send a new patch soon to fix
this.

Best regards,

Juan Manuel 



Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Kai von Fintel  writes:

>>> (defun org-latex--format-spec (info)
>>>   "Create a format-spec for document meta-data.
>>> INFO is a plist used as a communication channel."
>>>   (let ((language (let ((lang (plist-get info :language)))
>>> (or (cdr (assoc-string lang org-latex-babel-language-alist 
>>> t))
>>> (nth 1 (assoc-string lang 
>>> org-latex-polyglossia-language-alist t))
>>> lang
>>>
>>> This borks my latex exports.
> ...
> Thanks, Ihor. Your change fixed my issue.
>
> I do think that the code on lines 1864 and 1865 of =ox-latex.el= 
> (https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el#n1864)
>  should not use the old variable names. Since you’ve now defined the old 
> variables in =org-compat.el=, my exports work, so I’m ok for the moment. But 
> I don’t understand why they are still used in the definition of 
> =org-latex--format-spec=.
>
> But of course I’m far from familiar with the org code base.

Hmm. You are actually right.
Juan, can you please take a look. It looks like you missed
"org-latex--format-spec" in the patch. It should use the new
org-latex-language-alist variable instead.

Best,
Ihor



Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Kai von Fintel



On 23 Jul 2022, at 17:22, Ihor Radchenko wrote:

> Kai von Fintel  writes:
>
> Debugger entered--Lisp error: (void-variable 
> org-latex-babel-language-alist)
>  org-latex--format-spec(
>>>
>>> org-latex-babel-language-alist is the new variable introduced in the
>>> patch. You seem to be loading "mixed" Org versions - built-in + latest.
>>
>> No, I’m looking just at the HEAD version of =ox-latex.el= at 
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el
>>
>> The new variable is =org-latex-language-alist=, defined on line 175f.
>>
>> But, =org-latex—format-spec=, defined on line 1860ff, uses the old variable 
>> names:
>>
>> (defun org-latex--format-spec (info)
>>   "Create a format-spec for document meta-data.
>> INFO is a plist used as a communication channel."
>>   (let ((language (let ((lang (plist-get info :language)))
>>  (or (cdr (assoc-string lang org-latex-babel-language-alist 
>> t))
>>  (nth 1 (assoc-string lang 
>> org-latex-polyglossia-language-alist t))
>>  lang
>>
>> This borks my latex exports.
>
> This is unrelated to the error you are seeing. void-variable error is
> thrown for org-latex-babel-language-alist, so I still suggest checking
> the place in your config where you are loading Org.
>
> However, you did raise an important omission in the patch - the variable
> value was lost in the patch. It was not supposed to happen. I now
> restored (in 127e7fee4) the defconst statements and moved them into
> org-compat.el. Thus, they can be used by third-party code for the time
> being.

Thanks, Ihor. Your change fixed my issue.

I do think that the code on lines 1864 and 1865 of =ox-latex.el= 
(https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el#n1864)
 should not use the old variable names. Since you’ve now defined the old 
variables in =org-compat.el=, my exports work, so I’m ok for the moment. But I 
don’t understand why they are still used in the definition of 
=org-latex--format-spec=.

But of course I’m far from familiar with the org code base.

— Kai.



Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Juan Manuel Macías  writes:

> Ihor Radchenko writes:
>
> Thanks, Ihor. And sorry again for my typos...

No problem.

> If it's okay with you, I can send another patch with the updated
> information in NEWS and the Manual. And we can continue the subsequent
> discussion related of babel, polyglossia et alii in another thread.

Sure. Or you can keep the same thread, probably changing the subject to
something people can notice better (M-x message-change-subject).

Best,
Ihor



Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Kai von Fintel  writes:

 Debugger entered--Lisp error: (void-variable 
 org-latex-babel-language-alist)
  org-latex--format-spec(
>>
>> org-latex-babel-language-alist is the new variable introduced in the
>> patch. You seem to be loading "mixed" Org versions - built-in + latest.
>
> No, I’m looking just at the HEAD version of =ox-latex.el= at 
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el
>
> The new variable is =org-latex-language-alist=, defined on line 175f.
>
> But, =org-latex—format-spec=, defined on line 1860ff, uses the old variable 
> names:
>
> (defun org-latex--format-spec (info)
>   "Create a format-spec for document meta-data.
> INFO is a plist used as a communication channel."
>   (let ((language (let ((lang (plist-get info :language)))
>   (or (cdr (assoc-string lang org-latex-babel-language-alist 
> t))
>   (nth 1 (assoc-string lang 
> org-latex-polyglossia-language-alist t))
>   lang
>
> This borks my latex exports.

This is unrelated to the error you are seeing. void-variable error is
thrown for org-latex-babel-language-alist, so I still suggest checking
the place in your config where you are loading Org.

However, you did raise an important omission in the patch - the variable
value was lost in the patch. It was not supposed to happen. I now
restored (in 127e7fee4) the defconst statements and moved them into
org-compat.el. Thus, they can be used by third-party code for the time
being.

Best,
Ihor



Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Juan Manuel Macías
Ihor Radchenko writes:

> Thanks! Considering that the followup discussion deviated from the
> substance of the patch towards related design issues, I have decided to
> marge the patch as is. We can decide on handling AUTO staff later - it
> would be a major change to remove and the details of an alternative are
> not yet worked out.
>
> Applied onto main via 97cfb959d after adding some double spaces
> between sentences and upcasing the beginning of some sentences.

Thanks, Ihor. And sorry again for my typos...

If it's okay with you, I can send another patch with the updated
information in NEWS and the Manual. And we can continue the subsequent
discussion related of babel, polyglossia et alii in another thread.

Best regards,

Juan Manuel 



Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Kai von Fintel
On 23 Jul 2022, at 16:59, Ihor Radchenko wrote:

> Kai von Fintel  writes:
>
>> I believe that that this patch has made it impossible to export to latex, 
>> because the function =org-latex--format-spec= in =ox-latex.el= still refers 
>> to the old variables, which are now not bound:
>>
>>> Debugger entered--Lisp error: (void-variable org-latex-babel-language-alist)
>>>  org-latex--format-spec(
>
> org-latex-babel-language-alist is the new variable introduced in the
> patch. You seem to be loading "mixed" Org versions - built-in + latest.

No, I’m looking just at the HEAD version of =ox-latex.el= at 
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el

The new variable is =org-latex-language-alist=, defined on line 175f.

But, =org-latex—format-spec=, defined on line 1860ff, uses the old variable 
names:

(defun org-latex--format-spec (info)
  "Create a format-spec for document meta-data.
INFO is a plist used as a communication channel."
  (let ((language (let ((lang (plist-get info :language)))
(or (cdr (assoc-string lang org-latex-babel-language-alist 
t))
(nth 1 (assoc-string lang 
org-latex-polyglossia-language-alist t))
lang

This borks my latex exports.

— Kai.



Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Kai von Fintel  writes:

> I believe that that this patch has made it impossible to export to latex, 
> because the function =org-latex--format-spec= in =ox-latex.el= still refers 
> to the old variables, which are now not bound:
>
>> Debugger entered--Lisp error: (void-variable org-latex-babel-language-alist)
>>  org-latex--format-spec(

org-latex-babel-language-alist is the new variable introduced in the
patch. You seem to be loading "mixed" Org versions - built-in + latest.

Best,
Ihor



BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Kai von Fintel
I believe that that this patch has made it impossible to export to latex, 
because the function =org-latex--format-spec= in =ox-latex.el= still refers to 
the old variables, which are now not bound:

> Debugger entered--Lisp error: (void-variable org-latex-babel-language-alist)
>  org-latex--format-spec(

etc.

— Kai.



Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Ihor Radchenko
Max Nikulin  writes:

>> If it still fails, could you try isolating whether it's a specific
>> `should' clause which is the problem, if it fails with any of them?
>
> It is `map-do' that causes the problem. Maybe earlier implementation in 
> Emacs-26 has some peculiarities. It is the version available from the 
> system repository for Ubuntu-20.04 LTS focal.

Tests do not fail on my side using Emacs 26.3

Best,
Ihor



Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Max Nikulin

On 23/07/2022 14:48, Hugo Heagren wrote:


I've already assigned copyright to the FSF for work on Emacs (see
attached certificate). Do I need to do anything else for org-mode in
particular?


Great, I hope, it is enough, but my answer is not authoritative.


Emacs-26.3:
make test-dirty BTEST_RE=test-ol/insert-link-insert-description
[failing test]


If it still fails, could you try isolating whether it's a specific
`should' clause which is the problem, if it fails with any of them?


It is `map-do' that causes the problem. Maybe earlier implementation in 
Emacs-26 has some peculiarities. It is the version available from the 
system repository for Ubuntu-20.04 LTS focal.




Re: [BUG] Markdown export broken without toc and with broken links [9.6 (9.6-??-e9da29b)]

2022-07-23 Thread Ihor Radchenko
Janek F  writes:

> With the following configuration (on top of vanilla Doom, but that doesn't 
> seem to be related), when trying to export to Markdown an org-mode file with 
> broken links, the export omits all content under headlines:
>
> (setq org-export-with-toc nil
>   org-export-with-broken-links 't)
>
> For Example:
>
> Test [[id:broken]]
> * Headline
> This is not exported
>
> exports to:
>
> Test
>
> The position of the broken link does not matter, just that there is one.

Fixed on bugfix via 14532ec6a.

Thanks for reporting!

Best,
Ihor