[Accepted] [O] Fix html export of footnotes with lists, tables, quotes, etc.
Patch 700 (http://patchwork.newartisans.com/patch/700/) is now Accepted. Maintainer comment: none This relates to the following submission: http://mid.gmane.org/%3CAANLkTi%3DbFiJvyJZy4vsEvP%2BbMDastWXSB6u72LDPLVqs%40mail.gmail.com%3E Here is the original message containing the patch: Content-Type: text/plain; charset=utf-8 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [O] Fix html export of footnotes with lists, tables, quotes, etc. Date: Fri, 18 Mar 2011 16:52:05 - From: Puneeth Chaganti puncha...@gmail.com X-Patchwork-Id: 700 Message-Id: AANLkTi=bfijvyjzy4vsevp+bmdastwxsb6u72ldpl...@mail.gmail.com To: emacs-orgmode emacs-orgmode@gnu.org Hi, Attached is a patch that allows having lists, tables, blockquotes and other org blocks in footnotes. Source code blocks still don't work. diff --git a/lisp/org-html.el b/lisp/org-html.el index c6f26b5..11ef9ef 100644 --- a/lisp/org-html.el +++ b/lisp/org-html.el @@ -1690,9 +1690,12 @@ lang=\%s\ xml:lang=\%s\ (save-excursion (goto-char (point-min)) - (while (re-search-forward p class=\footnote\[^\000]*?\\(/p\\|\\'\\) nil t) - (push (match-string 0) footnotes) - (replace-match t t))) + (while (re-search-forward + \\(\\(p class=\footnote\\\)[^\000]*?\\)\\(\\(\\2\\)\\|\\'\\) + nil t) + (push (match-string 1) footnotes) + (replace-match \\4 t nil) + (goto-char (match-beginning 0 (when footnotes (insert (format org-export-html-footnotes-section (nth 4 lang-words)
Re: [Accepted] [O] Fix html export of footnotes with lists, tables, quotes, etc.
On Wed, Mar 23, 2011 at 7:38 PM, Bastien Guerry b...@altern.org wrote: Patch 700 (http://patchwork.newartisans.com/patch/700/) is now Accepted. Thanks. But, it looks like the commit message doesn't get into patchwork or is it that Bastien changed my bad commit message? My commit message also mentioned that src code blocks don't work, and it possibly because of new lines being inserted. Bastien, did you remove it because it was irrelevant? If the commit message was changed because, Bastien didn't notice it, can someone tell me the right way to send patches? I just want to reduce Bastien's trouble and this is leading to duplication of work, as well. Thanks, Puneeth
Re: [Accepted] [O] Fix html export of footnotes with lists, tables, quotes, etc.
Hi Bastien, On Wed, Mar 23, 2011 at 8:00 PM, Bastien b...@altern.org wrote: Hi Puneeth, Puneeth Chaganti puncha...@gmail.com writes: But, it looks like the commit message doesn't get into patchwork or is it that Bastien changed my bad commit message? My commit message also mentioned that src code blocks don't work, and it possibly because of new lines being inserted. Your commit message went to the patchwork and I cleaned it up, yes. Okay. Bastien, did you remove it because it was irrelevant? I probably should have kept this information, sorry. I prefered to have a commit message saying what the commit does and not what it does not -- thinking another commit will come soon and complete it. It's alright. I didn't have the time to look into it. But now I'm motivated to look into it. ;) If the commit message was changed because, Bastien didn't notice it, can someone tell me the right way to send patches? I noticed it, don't worry :) Okay. :) I just want to reduce Bastien's trouble and this is leading to duplication of work, as well. Thanks a lot for that -- the best way to send patches/commits to the list is by using the command git send-email. Otherwise, the message of the email is taken as the commit message by patchwork, and that I need to reedit a bit. But any other way is okay too, as long as I have the information. Ok. I am behind a proxy and not very sure how to get this working. Will look into this again, hopefully, this time with some success. Thanks, Puneeth
Re: [Accepted] [O] Fix html export of footnotes with lists, tables, quotes, etc.
Hi Puneeth, Puneeth Chaganti puncha...@gmail.com writes: But, it looks like the commit message doesn't get into patchwork or is it that Bastien changed my bad commit message? My commit message also mentioned that src code blocks don't work, and it possibly because of new lines being inserted. Your commit message went to the patchwork and I cleaned it up, yes. Bastien, did you remove it because it was irrelevant? I probably should have kept this information, sorry. I prefered to have a commit message saying what the commit does and not what it does not -- thinking another commit will come soon and complete it. If the commit message was changed because, Bastien didn't notice it, can someone tell me the right way to send patches? I noticed it, don't worry :) I just want to reduce Bastien's trouble and this is leading to duplication of work, as well. Thanks a lot for that -- the best way to send patches/commits to the list is by using the command git send-email. Otherwise, the message of the email is taken as the commit message by patchwork, and that I need to reedit a bit. But any other way is okay too, as long as I have the information. Best, -- Bastien
