Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

2023-01-17 Thread Bastien Guerry
Ihor Radchenko  writes:

> Bastien, please let me know if you have any objections.

None, thanks for taking action here.

-- 
 Bastien



Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

2023-01-17 Thread Ihor Radchenko
Ihor Radchenko  writes:

> We should fix this before Org 9.6.1.
> I will leave the decision about exact Emacs version to Bastien.
>
> One notable fact is that Debian oldstable we use on CI [1] appears to
> use Emacs 26.1. So, we are probably safe to declare Emacs 26.1
> compatibility.
>
> [1] https://builds.sr.ht/api/jobs/915058/manifest

Given that we have started getting some bug reports about Org not
working in Emacs 25, I just bumped the version requirement on bugfix.
This will prevents Emacs 25 installing incompatible versions of Org.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c7b976a05

Bastien, please let me know if you have any objections.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

2023-01-01 Thread Ihor Radchenko
Ihor Radchenko  writes:

> Max Nikulin  writes:
>
>> lisp/org.el:10:;; Package-Requires: ((emacs "25.1"))
>
> We should indeed bump the minimal required Emacs version.
> Should we use Emacs 26.3 as the minimal version?

We should fix this before Org 9.6.1.
I will leave the decision about exact Emacs version to Bastien.

One notable fact is that Debian oldstable we use on CI [1] appears to
use Emacs 26.1. So, we are probably safe to declare Emacs 26.1
compatibility.

[1] https://builds.sr.ht/api/jobs/915058/manifest

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

2022-12-18 Thread Ihor Radchenko
Max Nikulin  writes:

> lisp/org.el:10:;; Package-Requires: ((emacs "25.1"))

We should indeed bump the minimal required Emacs version.
Should we use Emacs 26.3 as the minimal version?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 



Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

2022-12-18 Thread Tim Cross


Timothy  writes:

> Hi Max,
>
>> Notice emacs-25.1 in the elpa package description:
>
> Yea, I’m pretty sure this is just an oversight. This should be bumped to 26.
>

Yep, that would be my assumption as well. Support is for the two
previous releases i.e. 27.x and 26.x.



Re: [BUG] Org-9.6 declares compatibility with Emacs-25.1

2022-12-17 Thread Timothy
Hi Max,

> Notice emacs-25.1 in the elpa package description:

Yea, I’m pretty sure this is just an oversight. This should be bumped to 26.

All the best,
Timothy

-- 
Timothy (‘tecosaur’/‘TEC’), Org mode contributor.
Learn more about Org mode at .
Support Org development at ,
or support my work at .


[BUG] Org-9.6 declares compatibility with Emacs-25.1

2022-12-17 Thread Max Nikulin

Hi,

Notice emacs-25.1 in the elpa package description:

 Status: Available Obsolete from gnu -- Install
Archive: gnu
Version: 9.6
 Commit: b3da427ebb1c401355aa4cba9baeaa92f87ccb2f
Summary: Outline-based notes management and organizer
   Requires: emacs-25.1
   Homepage: https://orgmode.org
   Keywords: outlines hypermedia calendar wp
 Maintainer: Bastien Guerry 
 Author: Carsten Dominik 
Other versions: 9.6 (installed), 9.5.2 (installed), 9.3 (builtin).

and

lisp/org.el:10:;; Package-Requires: ((emacs "25.1"))

Attempt to use Org with emacs-25.2.2 (Ubuntu-18.04 LTS bionic) causes an 
error

File mode specification error: (void-function temporary-file-directory)

and the buffer remains in the fundamental mode.

My expectations:
- either Package-Requires is updated to emacs-26.1
- or Org is modified to be usable at least with limited set of features 
and it is clarified why Package-Requires may be less than the version 
declared by 
https://orgmode.org/worg/org-maintenance.html#emacs-compatibility.



Debugger entered--Lisp error: (void-function temporary-file-directory)
  (temporary-file-directory)
  (expand-file-name (format "babel-stable-%d" (random 1000)) 
(temporary-file-directory))
  (setq dir (expand-file-name (format "babel-stable-%d" (random 1000)) 
(temporary-file-directory)))
  (while (or (not dir) (file-exists-p dir)) (setq dir (expand-file-name (format 
"babel-stable-%d" (random 1000)) (temporary-file-directory
  (let (dir) (while (or (not dir) (file-exists-p dir)) (setq dir (expand-file-name 
(format "babel-stable-%d" (random 1000)) (temporary-file-directory 
(make-directory dir) dir)
  (if noninteractive nil (let (dir) (while (or (not dir) (file-exists-p dir)) (setq dir 
(expand-file-name (format "babel-stable-%d" (random 1000)) 
(temporary-file-directory (make-directory dir) dir))
  (defvar org-babel-temporary-stable-directory (if noninteractive nil (let (dir) (while (or (not 
dir) (file-exists-p dir)) (setq dir (expand-file-name (format "babel-stable-%d" (random 
1000)) (temporary-file-directory (make-directory dir) dir)) "Directory to hold temporary 
files created to execute code blocks.\nUsed by `org-babel-temp-file'.  This directory will be 
removed on\nEmacs shutdown.")
  eval-buffer(# nil 
"/home/ubuntu/org-mode/lisp/ob-core.el" nil t)  ; Reading at buffer position 128878
  load-with-code-conversion("/home/ubuntu/org-mode/lisp/ob-core.el" 
"/home/ubuntu/org-mode/lisp/ob-core.el" nil t)
  require(ob-core)
  eval-buffer(# nil 
"/home/ubuntu/org-mode/lisp/ob-emacs-lisp.el" nil t)  ; Reading at buffer position 
1072
  load-with-code-conversion("/home/ubuntu/org-mode/lisp/ob-emacs-lisp.el" 
"/home/ubuntu/org-mode/lisp/ob-emacs-lisp.el" nil t)
  require(ob-emacs-lisp)
  (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat 
"org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" 
lang
  (let ((active (cdr pair)) (lang (symbol-name (car pair (if active (require (intern (concat 
"ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) (fmakunbound 
(intern (concat "org-babel-expand-body:" lang)
  (let ((pair (car --dolist-tail--))) (let ((active (cdr pair)) (lang (symbol-name (car pair (if active 
(require (intern (concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" 
lang))) (fmakunbound (intern (concat "org-babel-expand-body:" lang) (setq --dolist-tail-- (cdr 
--dolist-tail--)))
  (while --dolist-tail-- (let ((pair (car --dolist-tail--))) (let ((active (cdr pair)) (lang (symbol-name 
(car pair (if active (require (intern (concat "ob-" lang))) (fmakunbound (intern (concat 
"org-babel-execute:" lang))) (fmakunbound (intern (concat "org-babel-expand-body:" 
lang) (setq --dolist-tail-- (cdr --dolist-tail--
  (let ((--dolist-tail-- org-babel-load-languages)) (while --dolist-tail-- (let ((pair (car 
--dolist-tail--))) (let ((active (cdr pair)) (lang (symbol-name (car pair (if active (require (intern 
(concat "ob-" lang))) (fmakunbound (intern (concat "org-babel-execute:" lang))) 
(fmakunbound (intern (concat "org-babel-expand-body:" lang) (setq --dolist-tail-- (cdr 
--dolist-tail--)
  org-babel-do-load-languages(org-babel-load-languages ((emacs-lisp . t)))
  custom-initialize-reset(org-babel-load-languages (funcall (function (closure 
(crm-separator org-babel-load-languages org-id-overriding-file-name 
org-indent-indentation-per-level org-element--timestamp-regexp 
org-element-cache-map-continue-from org-element-paragraph-separate 
org-agenda-buffer-name org-inlinetask-min-level t) nil (quote ((emacs-lisp . 
t)))
  custom-declare-variable(org-babel-load-languages (funcall (function (closure (crm-separator org-babel-load-languages org-id-overriding-file-name org-indent-indentation-per-level org-element--timestamp-regexp org-element-cache-map-continue-from org-element-paragraph-separate org-agenda-buffer-name