Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

[stardiviner]

After dive into scel source code, I use cmake build fix. This seems an 
old problem. Now fixed.



On 03/26/2018 07:38 PM, stardiviner wrote:


You `(require 'sclang)` cause error on `(require 'sclang-vars)` 
failed. Because there is no file `sclang-vars.el`. Only file 
`sclang-vars.el.in` for built-time defaults. When user load sclang 
from source code of `scel`. This will cause error.


Really don't understand why you have to `(require 'sclang)` instead of 
`(require 'sclang-interp)`? Can you tell me why?



On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:

Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim

Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

[stardiviner]

You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed. 
Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in` 
for built-time defaults. When user load sclang from source code of 
`scel`. This will cause error.


Really don't understand why you have to `(require 'sclang)` instead of 
`(require 'sclang-interp)`? Can you tell me why?



On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:

Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim

Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

[Nicolas Goaziou]

Hello,

Maxim Cournoyer  writes:

> The attached patch fixes a byte compilation issue in ob-sclang.el.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

[stardiviner]

Hi, @MaximI'm the author of `ob-sclang.el`.

Whyneed to require `sclang` instead of `sclang-interp`? ob-sclangused 
functions are all in `sclang-interp.el` file. No need to require 
`sclang`. And I checked out `scel` source code, have not found update.


Might because `sclang-interp`?


On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:

Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim

[O] [PATCH] contrib: ob-sclang: Fix compilation issue.

[Maxim Cournoyer]

Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim

>From 0cbc7a1526cd5a87de776de86948bded399063c9 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer 
Date: Sat, 24 Mar 2018 19:13:42 -0400
Subject: [PATCH] contrib: ob-sclang: Fix compilation issue.

* contrib/lisp/ob-sclang.el: Require sclang instead of sclang-interp.
---
 contrib/lisp/ob-sclang.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/lisp/ob-sclang.el b/contrib/lisp/ob-sclang.el
index ac47b9834..dcd4b6f74 100644
--- a/contrib/lisp/ob-sclang.el
+++ b/contrib/lisp/ob-sclang.el
@@ -24,7 +24,7 @@
 
 ;;; Commentary:
 
-;; `ob-sclang' requires `sclang-interp' from SuperCollider.
+;; `ob-sclang' requires `sclang' from SuperCollider.
 ;; Usually SuperCollider dependencies for Emacs are at /usr/share/emacs/site-lisp/SuperCollider/
 ;; You can install SuperCollider following this article:
 ;; https://github.com/supercollider/supercollider#building-the-source-code
@@ -60,7 +60,7 @@
 (require 'org)
 (require 'ob)
 
-(require 'sclang-interp)
+(require 'sclang)
 
 (defgroup ob-sclang nil
   "org-mode blocks for SuperCollider SCLang."
-- 
2.16.1